Metrics: changed port from 8080 to 8082 #2818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cheina97. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
|
/rebase test=true |
08d96b4 to
4e7ec9c
Compare
fra98
reviewed
Nov 18, 2024
4e7ec9c to
72207ec
Compare
|
/rebase test=true |
|
@cheina97 this is probably breaking something since both tests (overlapped and not) are broken while waiting for the connection to be set up in the peer command |
72207ec to
f8b1002
Compare
|
/build |
fra98
approved these changes
Nov 22, 2024
f8b1002 to
b868016
Compare
|
/rebase test=true |
1 similar comment
|
/rebase test=true |
|
/build |
|
/rebase test=true |
b868016 to
c9c7fae
Compare
|
/rebase test=true |
1 similar comment
|
/rebase test=true |
b80647c to
3b01983
Compare
|
/rebase test=true |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the ports used for metrics from 8080 to 8082. This is useful to avoid using port 8080 with host network pods, as port 8080 should be used by another service on the host.