Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Docs] Add declarative peering section #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

[Docs] Add declarative peering section #2813

merged 1 commit into from
Nov 28, 2024

Conversation

@claudiolor
Copy link
Contributor

Description

This PR add the documentation for the creation of peerings via a declarative approach, by applying CRs.

How Has This Been Tested?

N/A

@adamjensenbot
Copy link
Collaborator

Hi @claudiolor. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@claudiolor claudiolor force-pushed the clo/declarive-peering-docs branch from 64eee72 to c334f63 Compare November 13, 2024 10:39
@claudiolor claudiolor force-pushed the clo/declarive-peering-docs branch from c334f63 to ee2231d Compare November 13, 2024 10:41
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 13, 2024
View reviewed changes
frisso
frisso reviewed Nov 14, 2024
View reviewed changes
frisso
frisso reviewed Nov 14, 2024
View reviewed changes
frisso
frisso reviewed Nov 14, 2024
View reviewed changes
frisso
frisso reviewed Nov 14, 2024
View reviewed changes
frisso
frisso reviewed Nov 14, 2024
View reviewed changes
frisso
frisso reviewed Nov 14, 2024
View reviewed changes
frisso
frisso requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@frisso frisso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me.
Minor comments, mainly small rephrasing.

@claudiolor claudiolor force-pushed the clo/declarive-peering-docs branch 2 times, most recently from f4b8613 to 142d250 Compare November 15, 2024 12:08
fracappa
fracappa reviewed Nov 21, 2024
View reviewed changes
@claudiolor claudiolor force-pushed the clo/declarive-peering-docs branch from ecb60ad to bbbc4f8 Compare November 21, 2024 15:01
fra98
fra98 approved these changes Nov 26, 2024
View reviewed changes
@claudiolor claudiolor force-pushed the clo/declarive-peering-docs branch from bbbc4f8 to aa56b45 Compare November 28, 2024 16:21
@fra98
Copy link
Member

fra98 commented Nov 28, 2024

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the clo/declarive-peering-docs branch from aa56b45 to d4d3b83 Compare November 28, 2024 17:08
@fra98
Copy link
Member

fra98 commented Nov 28, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Nov 28, 2024
@adamjensenbot adamjensenbot merged commit 4e5704f into liqotech:master Nov 28, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frisso frisso frisso approved these changes

@fra98 fra98 fra98 approved these changes

+1 more reviewer

@fracappa fracappa fracappa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@claudiolor @adamjensenbot @fra98 @frisso @fracappa