Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Network] avoid panic when setting gateway secretRef #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 29, 2025
Merged

[Network] avoid panic when setting gateway secretRef #3049

merged 3 commits into from
May 29, 2025

Conversation

@fra98
Copy link
Member

@fra98 fra98 commented May 22, 2025

Description

This PR fixes a bug causing the WireGuard gateway server controller to panic if a secretRef is specified on the GatewayServer resource.

The controller now checks the secretRef in the spec rather than the status, which is updated only after ensuring that the referenced secret exists and is correctly labeled.
The docs for the declarative peering have also been updated to add a missing label on the WireGuard secret manifest.

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added fix Fixes a bug in the codebase. docs Updates or adds documentation labels May 22, 2025
@fra98
Copy link
Member Author

fra98 commented May 22, 2025

/test

@fra98 fra98 marked this pull request as ready for review May 22, 2025 13:22
@fra98 fra98 requested review from aleoli and claudiolor May 22, 2025 13:22
@fra98 fra98 mentioned this pull request May 22, 2025
Closed
2 tasks
@fra98 fra98 force-pushed the frt/panic-gw-secret-ref branch from ab7a774 to 892d78e Compare May 23, 2025 15:19
@fra98
Copy link
Member Author

fra98 commented May 28, 2025

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frt/panic-gw-secret-ref branch from 892d78e to 1aa53ec Compare May 28, 2025 09:23
@fra98
Copy link
Member Author

fra98 commented May 29, 2025

/rebase test=true

@fra98
Copy link
Member Author

fra98 commented May 29, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label May 29, 2025
@adamjensenbot adamjensenbot merged commit 91bfa13 into liqotech:master May 29, 2025
24 of 26 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label May 29, 2025
@BrewTestBot BrewTestBot mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claudiolor claudiolor claudiolor approved these changes

@aleoli aleoli aleoli approved these changes

Assignees

No one assigned

Labels

docs Updates or adds documentation fix Fixes a bug in the codebase. size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fra98 @adamjensenbot @claudiolor @aleoli