Hi @mayooot. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

• /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
  when the rebase operation is completed)
• /merge: Merge this PR into the master branch
• /build Build Liqo components
• /test Launch the E2E and Unit tests
• /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

• feat: 🚀 New Feature
• fix: 🐛 Bug Fix
• refactor: 🧹 Code Refactoring
• docs: 📝 Documentation
• style: 💄 Code Style
• perf: 🐎 Performance Improvement
• test: ✅ Tests
• chore: 🚚 Dependencies Management
• build: 📦 Builds Management
• ci: 👷 CI/CD
• revert: ⏪ Reverts Previous Changes

This looks very good to me, thanks!
Final words to @claudiolor , who has a deeper understanding of the source code.

@claudiolor Please check it.

Hi @mayooot thank you so much for your PR :D

I would not create a new command with a single letter of difference to another as it seems to me really prone to user errors, while instead I would reuse the same command with some aliases so that liqoctl offload namespace can be liqoctl offload namespaces or liqoctl offload ns and add the --selector option to it.
So according to this, we can allow the user to provide more than one namespace name removing this option from the command.
At this point we can move the logic of offload/handler.go from line 75 below on a separate function, so that we iterate over the namespaces indicated by the user or the ones retrieved via the label selector and call this function for each of the namespaces.

Of course, we should return an error if the user specified both the name of the namespaces of the label selectors or none of them.

In this way I think we are reducing the possibility that a user makes a mistake, we are giving the possibility to offload more than one namespace by name at a time and there is no need to duplicate code in order to introduce a new command.
Let me know what you think about it :)

@claudiolor You're right, namespace and namespaces do make it easy to get confused.
I tried to minimize changes to the source code during development, so I added a new command that minimizes the impact on the original functionality.

It's right to make changes to the namespace command directly, so that the processing of a single namespace and multiple namespaces can be put into a Run function, and it's more optimized for the user.

I will update the code as we discussed.
Thanks a lot!

@claudiolor I've done that.
It can be used below:

$ liqoctl offload namespace lowkey01
 INFO  Offloading of namespace "lowkey01" correctly enabled
 INFO  Offloading completed successfully

$ liqoctl offload namespace lowkey02 lowkey03 lowkey04
 INFO  Offloading of namespace "lowkey02" correctly enabled
 INFO  Offloading completed successfully
 INFO  Offloading of namespace "lowkey03" correctly enabled
 INFO  Offloading completed successfully
 INFO  Offloading of namespace "lowkey04" correctly enabled
 INFO  Offloading completed successfully

$ liqoctl offload namespace --label-selector="bunch=yes"
 INFO  Offloading of namespace "highkey01" correctly enabled
 INFO  Offloading completed successfully
 INFO  Offloading of namespace "highkey02" correctly enabled
 INFO  Offloading completed successfully
 INFO  Offloading of namespace "highkey03" correctly enabled
 INFO  Offloading completed successfully

Hi @mayooot thanks a lot! :) I will check it ASAP

@mayooot This looks very good to me (@claudiolor for more precise notes on the code).
To be completed, we would need two more steps:

• align also the 'unoffload' command with the new features
• align the documentation (https://docs.liqo.io/en/latest/usage/namespace-offloading.html) with the new features

@claudiolor All done. Cloud you check it when you have a moment?

Thank you for fixing the issues I reported! 💯 Once the small issue I underlined is fixed we can consider the offload command completed. To merge this PR we still need to implement a similar behavior with the unoffload command and the documentation needs to be updated accordingly.

Ok, I've fixed the bugs, and I'll implement unoffload command ASAP.

@claudiolor All is done. Please check it and let me know your suggestions about the code and docs :)

Thanks @mayooot, I will check these changes ASAP

Thank you for implementing also unoffload!

• I left just a couple of comment.
• Before merging we also need to update the automatically generated liqoctl documentation, you can update the documentation by launching make ctldocs, then you can commit the updated files.

Once those two points are addressed I believe we can merge

@claudiolor I'm done here :)

@mayooot thank you! @aleoli can you please check and merge this?

/test

Hi @mayooot! It looks good to me.

Could you please squash all your commits into a single commit? Then we can proceed with the merge. Thanks!

Hi @mayooot! It looks good to me.

Could you please squash all your commits into a single commit? Then we can proceed with the merge. Thanks!

Sure, I just squashed them.

/rebase test=true

/merge