Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[lit-labs/compiler] Add package.json and initialize package #4017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndrewJakubowicz merged 4 commits into from
Jul 14, 2023
Merged

[lit-labs/compiler] Add package.json and initialize package #4017

AndrewJakubowicz merged 4 commits into from
Jul 14, 2023

Conversation

@AndrewJakubowicz
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz commented Jul 13, 2023

This is part of incrementally landing the lit-labs/compiler for easier review.

Prototype: #3984
Issue: #189
RFC: lit/rfcs#21

Context

This is the first PR which lands a private package.json and ignore files, ready for implementation to start being landed.

No testing required.

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: b373171

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -11% - +5% (-2.69ms - +1.31ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 71.57ms - 75.03ms
  • lit-html-kitchen-sink: unsure 🔍 -11% - +2% (-3.42ms - +0.66ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -4% - +2% (-0.39ms - +0.18ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +4% (-0.26ms - +2.15ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +2% (-1.10ms - +0.75ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 864.54ms - 878.34ms
  • lit-html-kitchen-sink: unsure 🔍 -2% - +9% (-1.29ms - +7.03ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +4% (-6.49ms - +12.58ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +1% (-2.83ms - +1.34ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +0% (-18.24ms - +3.91ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 825.29ms - 836.83ms
  • reactive-element-list: unsure 🔍 -1% - +1% (-12.77ms - +8.52ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
103.10ms - 109.41ms-

update

VersionAvg timevs
1120.31ms - 1173.05ms-

update-reflect

VersionAvg timevs
1097.07ms - 1123.55ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
42.84ms - 45.77ms-unsure 🔍
-6% - +5%
-2.75ms - +2.26ms		unsure 🔍
-2% - +7%
-0.79ms - +2.98ms
tip-of-tree
tip-of-tree		42.51ms - 46.58msunsure 🔍
-5% - +6%
-2.26ms - +2.75ms		-unsure 🔍
-2% - +9%
-1.02ms - +3.69ms
previous-release
previous-release		42.02ms - 44.40msunsure 🔍
-7% - +2%
-2.98ms - +0.79ms		unsure 🔍
-8% - +2%
-3.69ms - +1.02ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
111.63ms - 118.97ms-slower ❌
1% - 10%
0.88ms - 10.34ms		unsure 🔍
-4% - +6%
-3.98ms - +7.18ms
tip-of-tree
tip-of-tree		106.70ms - 112.68msfaster ✔
1% - 9%
0.88ms - 10.34ms		-unsure 🔍
-8% - +1%
-9.18ms - +1.15ms
previous-release
previous-release		109.50ms - 117.91msunsure 🔍
-6% - +3%
-7.18ms - +3.98ms		unsure 🔍
-1% - +8%
-1.15ms - +9.18ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
21.36ms - 23.86ms-unsure 🔍
-4% - +9%
-0.84ms - +2.02ms		unsure 🔍
-11% - +6%
-2.52ms - +1.47ms
tip-of-tree
tip-of-tree		21.31ms - 22.72msunsure 🔍
-9% - +4%
-2.02ms - +0.84ms		-unsure 🔍
-12% - +2%
-2.83ms - +0.59ms
previous-release
previous-release		21.58ms - 24.70msunsure 🔍
-7% - +11%
-1.47ms - +2.52ms		unsure 🔍
-3% - +13%
-0.59ms - +2.83ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
12.88ms - 13.98ms-unsure 🔍
-12% - +4%
-1.71ms - +0.58ms		unsure 🔍
-6% - +6%
-0.84ms - +0.80ms
tip-of-tree
tip-of-tree		12.98ms - 15.00msunsure 🔍
-4% - +13%
-0.58ms - +1.71ms		-unsure 🔍
-5% - +13%
-0.64ms - +1.72ms
previous-release
previous-release		12.84ms - 14.06msunsure 🔍
-6% - +6%
-0.80ms - +0.84ms		unsure 🔍
-12% - +4%
-1.72ms - +0.64ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
341.56ms - 359.59ms-unsure 🔍
-5% - +1%
-18.67ms - +5.43ms		unsure 🔍
-2% - +5%
-6.17ms - +18.37ms
tip-of-tree
tip-of-tree		349.20ms - 365.19msunsure 🔍
-2% - +5%
-5.43ms - +18.67ms		-slower ❌
0% - 7%
1.19ms - 24.25ms
previous-release
previous-release		336.16ms - 352.79msunsure 🔍
-5% - +2%
-18.37ms - +6.17ms		faster ✔
0% - 7%
1.19ms - 24.25ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
69.89ms - 73.30ms-unsure 🔍
-4% - +3%
-2.59ms - +2.04ms		unsure 🔍
-4% - +2%
-3.04ms - +1.60ms
tip-of-tree
tip-of-tree		70.31ms - 73.43msunsure 🔍
-3% - +4%
-2.04ms - +2.59ms		-unsure 🔍
-4% - +2%
-2.66ms - +1.77ms
previous-release
previous-release		70.74ms - 73.88msunsure 🔍
-2% - +4%
-1.60ms - +3.04ms		unsure 🔍
-2% - +4%
-1.77ms - +2.66ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
141.98ms - 148.23ms-unsure 🔍
-3% - +3%
-3.81ms - +4.96ms		unsure 🔍
-4% - +2%
-6.02ms - +2.52ms
tip-of-tree
tip-of-tree		141.45ms - 147.60msunsure 🔍
-3% - +3%
-4.96ms - +3.81ms		-unsure 🔍
-4% - +1%
-6.56ms - +1.91ms
previous-release
previous-release		143.94ms - 149.77msunsure 🔍
-2% - +4%
-2.52ms - +6.02ms		unsure 🔍
-1% - +5%
-1.91ms - +6.56ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
64.80ms - 68.45ms-unsure 🔍
-6% - +3%
-3.83ms - +1.73ms		unsure 🔍
-7% - +1%
-4.58ms - +0.70ms
tip-of-tree
tip-of-tree		65.57ms - 69.77msunsure 🔍
-3% - +6%
-1.73ms - +3.83ms		-unsure 🔍
-5% - +3%
-3.73ms - +1.95ms
previous-release
previous-release		66.66ms - 70.47msunsure 🔍
-1% - +7%
-0.70ms - +4.58ms		unsure 🔍
-3% - +6%
-1.95ms - +3.73ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1104.21ms - 1134.35ms-unsure 🔍
-3% - +2%
-30.24ms - +18.76ms		unsure 🔍
-2% - +2%
-24.36ms - +17.04ms
tip-of-tree
tip-of-tree		1105.71ms - 1144.33msunsure 🔍
-2% - +3%
-18.76ms - +30.24ms		-unsure 🔍
-2% - +2%
-21.89ms - +26.05ms
previous-release
previous-release		1108.74ms - 1137.14msunsure 🔍
-2% - +2%
-17.04ms - +24.36ms		unsure 🔍
-2% - +2%
-26.05ms - +21.89ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1113.43ms - 1139.73ms-unsure 🔍
-2% - +2%
-24.78ms - +17.13ms		unsure 🔍
-3% - +1%
-29.32ms - +9.99ms
tip-of-tree
tip-of-tree		1114.09ms - 1146.72msunsure 🔍
-2% - +2%
-17.13ms - +24.78ms		-unsure 🔍
-2% - +1%
-27.74ms - +16.06ms
previous-release
previous-release		1121.64ms - 1150.85msunsure 🔍
-1% - +3%
-9.99ms - +29.32ms		unsure 🔍
-1% - +2%
-16.06ms - +27.74ms		-

tachometer-reporter-action v2 for Benchmarks

augustjk
augustjk approved these changes Jul 13, 2023
View reviewed changes
@AndrewJakubowicz AndrewJakubowicz merged commit 72e962d into main Jul 14, 2023
@AndrewJakubowicz AndrewJakubowicz deleted the real-initial-compiler-commit branch July 14, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rictic rictic rictic approved these changes

@augustjk augustjk augustjk approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndrewJakubowicz @rictic @augustjk