[lit-labs/compiler] Logic for compiling templates containing ChildParts #4047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This implementation has intentionally been simplified to make reviewing easier. Attribute part handling, uncompiled files, and many other subtleties have been skipped but will be added in followup.
🦋 Changeset detectedLatest commit: 2c328f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
43081j
reviewed
Jul 26, 2023
43081j
reviewed
Jul 26, 2023
rictic
reviewed
Jul 26, 2023
Collaborator
rictic
left a comment
There was a problem hiding this comment.
Great work, this is looking really good!
rictic
approved these changes
Jul 27, 2023
augustjk
approved these changes
Jul 27, 2023
Member
augustjk
left a comment
There was a problem hiding this comment.
Nice! Just a couple minor notes.
Contributor
Author
|
Thank you! |
This was referenced Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #189
RFC: lit/rfcs#21
Full prototype PR: #3984
Note to reviewer: Review this commit by commit – and skip reviewing
parse5-utilscause I deleted it after feedback from @43081j.Context
This PR splits out some initial compiler behavior from the full prototype PR in a reviewable chunk. This PR adds the core functionality that can be built upon in followup changes (and have been de-risked in the prototype).
Features
ChildParts. Other template parts such as attribute and element parts will be included in a followup.This is a private only change, and no public entrypoints are being added.
In my opinion, the best place to start the review is at the
CompiledTemplatePass.getTransformer()function which contains the high level flow of the transform:CompiledTemplatePassinstance.CompiledTemplates and replacinghtmltagged templates withCompiledTemplateResults.Testing
Tests are contained in the
test_filesdirectory. Each*.jsor*.tshas a compiled*.golden.jswhich can be generated vianpm run update-goldens, and contains the expected generated output.The test files included in this change are a subset of the tests in the prototype PR which pass with this change.
Risk
There is minimal risk to merging this PR if GitHub actions succeed. Risk is reduced because
lit-labs/compileris a private package and not published to NPM yet.Thank you