Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[lit-labs/compiler] gracefully handle bindings in tag name position #4071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndrewJakubowicz merged 3 commits into from
Aug 7, 2023
Merged

[lit-labs/compiler] gracefully handle bindings in tag name position #4071

AndrewJakubowicz merged 3 commits into from
Aug 7, 2023

Conversation

@AndrewJakubowicz
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz commented Aug 4, 2023 •
edited
Loading

Issue: #189
RFC: lit/rfcs#21
Full prototype PR: #3984

Why

In DEV mode, this results in the error: Bindings in tag names are not supported.

How

If a marker exists in the tag name then we know that the user supplied a binding in tag name position, and can stop compiling the template.

Test plan

Tested by adding a golden.

Alternative

We could add a diagnostic here – however I've opted for a simpler but correct solution as there is no diagnostic support wired into the compiler, and this is one of the last cases we need to handle.

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: bc2acf3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -7% - +7% (-1.68ms - +1.72ms)
    this-change vs tip-of-tree

render

  • this-change: 103.06ms - 107.80ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +7% (-1.34ms - +2.92ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +4% (-2.68ms - +3.13ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +8% (-1.10ms - +5.72ms)
    this-change vs tip-of-tree

update

  • this-change: 1124.00ms - 1145.25ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +7% (-2.71ms - +7.55ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +3% (-5.45ms - +4.56ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-25.64ms - +20.75ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 1095.85ms - 1119.59ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-23.33ms - +13.04ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
103.06ms - 107.80ms-

update

VersionAvg timevs
1124.00ms - 1145.25ms-

update-reflect

VersionAvg timevs
1095.85ms - 1119.59ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
41.80ms - 44.83ms-unsure 🔍
-3% - +7%
-1.34ms - +2.92ms		unsure 🔍
-3% - +6%
-1.44ms - +2.70ms
tip-of-tree
tip-of-tree		41.02ms - 44.03msunsure 🔍
-7% - +3%
-2.92ms - +1.34ms		-unsure 🔍
-5% - +4%
-2.22ms - +1.90ms
previous-release
previous-release		41.28ms - 44.09msunsure 🔍
-6% - +3%
-2.70ms - +1.44ms		unsure 🔍
-4% - +5%
-1.90ms - +2.22ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
105.81ms - 112.46ms-unsure 🔍
-3% - +7%
-2.71ms - +7.55ms		unsure 🔍
-5% - +7%
-4.92ms - +7.64ms
tip-of-tree
tip-of-tree		102.80ms - 110.62msunsure 🔍
-7% - +2%
-7.55ms - +2.71ms		-unsure 🔍
-7% - +5%
-7.67ms - +5.55ms
previous-release
previous-release		102.45ms - 113.10msunsure 🔍
-7% - +4%
-7.64ms - +4.92ms		unsure 🔍
-5% - +7%
-5.55ms - +7.67ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
24.56ms - 26.86ms-unsure 🔍
-7% - +7%
-1.68ms - +1.72ms		unsure 🔍
-8% - +6%
-1.99ms - +1.50ms
tip-of-tree
tip-of-tree		24.43ms - 26.95msunsure 🔍
-7% - +7%
-1.72ms - +1.68ms		-unsure 🔍
-8% - +6%
-2.08ms - +1.55ms
previous-release
previous-release		24.64ms - 27.26msunsure 🔍
-6% - +8%
-1.50ms - +1.99ms		unsure 🔍
-6% - +8%
-1.55ms - +2.08ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
69.75ms - 74.44ms-unsure 🔍
-4% - +4%
-2.68ms - +3.13ms		unsure 🔍
-3% - +5%
-2.16ms - +3.72ms
tip-of-tree
tip-of-tree		70.16ms - 73.59msunsure 🔍
-4% - +4%
-3.13ms - +2.68ms		-unsure 🔍
-3% - +4%
-1.90ms - +3.02ms
previous-release
previous-release		69.55ms - 73.08msunsure 🔍
-5% - +3%
-3.72ms - +2.16ms		unsure 🔍
-4% - +3%
-3.02ms - +1.90ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
147.39ms - 154.89ms-unsure 🔍
-4% - +3%
-5.45ms - +4.56ms		unsure 🔍
-4% - +3%
-6.02ms - +5.17ms
tip-of-tree
tip-of-tree		148.27ms - 154.91msunsure 🔍
-3% - +4%
-4.56ms - +5.45ms		-unsure 🔍
-3% - +4%
-5.30ms - +5.34ms
previous-release
previous-release		147.41ms - 155.72msunsure 🔍
-3% - +4%
-5.17ms - +6.02ms		unsure 🔍
-4% - +3%
-5.34ms - +5.30ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
72.21ms - 77.07ms-unsure 🔍
-2% - +8%
-1.10ms - +5.72ms		slower ❌
0% - 9%
0.39ms - 6.37ms
tip-of-tree
tip-of-tree		69.94ms - 74.71msunsure 🔍
-8% - +1%
-5.72ms - +1.10ms		-unsure 🔍
-3% - +6%
-1.88ms - +4.02ms
previous-release
previous-release		69.52ms - 72.99msfaster ✔
1% - 8%
0.39ms - 6.37ms		unsure 🔍
-6% - +3%
-4.02ms - +1.88ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1139.95ms - 1177.14ms-unsure 🔍
-2% - +2%
-25.64ms - +20.75ms		unsure 🔍
-3% - +2%
-29.24ms - +18.07ms
tip-of-tree
tip-of-tree		1147.12ms - 1174.86msunsure 🔍
-2% - +2%
-20.75ms - +25.64ms		-unsure 🔍
-2% - +1%
-23.29ms - +17.02ms
previous-release
previous-release		1149.51ms - 1178.75msunsure 🔍
-2% - +3%
-18.07ms - +29.24ms		unsure 🔍
-1% - +2%
-17.02ms - +23.29ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1152.78ms - 1177.06ms-unsure 🔍
-2% - +1%
-23.33ms - +13.04ms		unsure 🔍
-2% - +2%
-20.56ms - +19.18ms
tip-of-tree
tip-of-tree		1156.52ms - 1183.60msunsure 🔍
-1% - +2%
-13.04ms - +23.33ms		-unsure 🔍
-1% - +2%
-16.30ms - +25.21ms
previous-release
previous-release		1149.88ms - 1181.33msunsure 🔍
-2% - +2%
-19.18ms - +20.56ms		unsure 🔍
-2% - +1%
-25.21ms - +16.30ms		-

tachometer-reporter-action v2 for Benchmarks

augustjk
augustjk reviewed Aug 4, 2023
View reviewed changes
@AndrewJakubowicz AndrewJakubowicz merged commit d384705 into main Aug 7, 2023
@AndrewJakubowicz AndrewJakubowicz deleted the dynamic-tag-name-handling branch August 7, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augustjk augustjk augustjk left review comments

@rictic rictic rictic approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndrewJakubowicz @rictic @augustjk