[lit-labs/compiler] Fix svg tag being accidentally compiled #4086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0b75628 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultsthis-change
render
update
update-reflect
this-change, tip-of-tree, previous-release
render
update
nop-update
this-change, tip-of-tree, previous-release
render
update
this-change, tip-of-tree, previous-release
render
update
update-reflect
|
augustjk
approved these changes
Aug 11, 2023
| templateImport.propertyName.text !== 'html' | ||
| (templateImport.propertyName && | ||
| templateImport.propertyName.text !== 'html') || | ||
| (!templateImport.propertyName && templateImport.name.text !== 'html') |
Member
There was a problem hiding this comment.
does this mean that in the case of no alias, the import specifier is like this?
import {<name>} from <moduleSpecifier>;
so if there is no propertyName, we check that name is the right value?
Contributor
Author
There was a problem hiding this comment.
That is exactly right, I added your example without the alias to the source code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #189
RFC: lit/rfcs#21
Full prototype PR: #3984
Context
I have a test branch which compiles lit-html_tests and runs tests and it caught that
svgtemplates were not correctly handled.import {svg} from 'lit'was marking thesvgtag as a compilable template.Fix
The original check handles the complex cases, but misses the simple case. For example an import of
import {html as svg, svg as html} from 'lit'works prior to this change because we have been assuming there will be an aliased property name.This change adds a check for direct imports. Note that the aliased golden continues to work (I just fixed punctuation).
Test plan
Unit tested by adding a new golden.