[lit-labs/compiler] Do not compile templates with invalid template or textarea tags #4095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 11e01a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultsthis-change
render
update
update-reflect
this-change, tip-of-tree, previous-release
render
update
nop-update
this-change, tip-of-tree, previous-release
render
update
this-change, tip-of-tree, previous-release
render
update
update-reflect
|
justinfagnani
approved these changes
Aug 14, 2023
rictic
reviewed
Aug 14, 2023
| return false; | ||
| } | ||
| if ( | ||
| /^(?:textarea|template)$/i!.test(node.tagName) && |
Collaborator
There was a problem hiding this comment.
This regex works, but it's somewhat tricky! tagName is always all caps, so we don't need to worry about that. A regexp can be faster if it doesn't have to ignore case, so consider writing it with all caps. But since this code isn't that performance sensitive, consider just checking membership in a set.
Breaking that part of the conditional out into a local variable also lets us name it, which is helpful for documentation.
Looking at the HTML spec, for elements with a Text content model, I wonder if we should also check for <title>, <style>, <rp>, and an <option> with a label attribute but not a value attribute
Contributor
Author
There was a problem hiding this comment.
Is this something to improve in lit-html as well (regarding the other elements)?
I can refactor compiler.
augustjk
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #189
RFC: lit/rfcs#21
Full prototype PR: #3984
Context
This is similar in spirit to #4088, where there is a runtime DEV_MODE check in lit-html that the compiler needs to handle.
Initially, handling by marking the templates as uncompilable such that the check remains in runtime.
In the future will add diagnostics to these cases.
Fix
Take the same logic as lit-html https://github.com/lit/lit/blob/lit-html%402.8.0/packages/lit-html/src/lit-html.ts#L893-L911, and use it to mark a template as uncompilable.
Test plan
Tested by using the lit-html_test tests, and ensuring the invalid goldens do not compile.
Future work is adding diagnostics to the compiler.