Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(gen-manifest): npm files, main field #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndrewJakubowicz merged 4 commits into from
Aug 22, 2023
Merged

fix(gen-manifest): npm files, main field #4126

AndrewJakubowicz merged 4 commits into from
Aug 22, 2023

Conversation

@bennypowers
Copy link
Collaborator

@bennypowers bennypowers commented Aug 22, 2023

  • corrects the main entry in package.json
  • adds build artifacts to package.json files

@bennypowers
fix(gen-manifest): npm files, main field
4b1a6f6 
- corrects the `main` entry in package.json
- adds build artifacts to package.json `files`
@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 4bf8ecf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/gen-manifest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +6% (-1.87ms - +1.45ms)
    this-change vs tip-of-tree

render

  • this-change: 95.95ms - 101.18ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +9% (-0.21ms - +3.35ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +4% (-1.61ms - +2.97ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: faster ✔ 0% - 8% (0.13ms - 5.61ms)
    this-change vs tip-of-tree

update

  • this-change: 967.59ms - 1001.45ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +9% (-1.98ms - +8.95ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +3% (-4.81ms - +4.38ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-21.93ms - +23.24ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 935.03ms - 968.99ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-22.16ms - +22.03ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
95.95ms - 101.18ms-

update

VersionAvg timevs
967.59ms - 1001.45ms-

update-reflect

VersionAvg timevs
935.03ms - 968.99ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
38.49ms - 41.18ms-unsure 🔍
-1% - +9%
-0.21ms - +3.35ms		unsure 🔍
-6% - +3%
-2.31ms - +1.41ms
tip-of-tree
tip-of-tree		37.10ms - 39.44msunsure 🔍
-8% - +0%
-3.35ms - +0.21ms		-faster ✔
1% - 9%
0.28ms - 3.76ms
previous-release
previous-release		39.00ms - 41.57msunsure 🔍
-4% - +6%
-1.41ms - +2.31ms		slower ❌
1% - 10%
0.28ms - 3.76ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
100.77ms - 108.71ms-unsure 🔍
-2% - +9%
-1.98ms - +8.95ms		unsure 🔍
-3% - +8%
-3.06ms - +8.05ms
tip-of-tree
tip-of-tree		97.50ms - 105.01msunsure 🔍
-8% - +2%
-8.95ms - +1.98ms		-unsure 🔍
-6% - +4%
-6.40ms - +4.41ms
previous-release
previous-release		98.36ms - 106.14msunsure 🔍
-8% - +3%
-8.05ms - +3.06ms		unsure 🔍
-4% - +6%
-4.41ms - +6.40ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
23.51ms - 25.45ms-unsure 🔍
-8% - +6%
-1.87ms - +1.45ms		unsure 🔍
-5% - +8%
-1.28ms - +2.00ms
tip-of-tree
tip-of-tree		23.34ms - 26.04msunsure 🔍
-6% - +8%
-1.45ms - +1.87ms		-unsure 🔍
-6% - +10%
-1.32ms - +2.46ms
previous-release
previous-release		22.79ms - 25.45msunsure 🔍
-8% - +5%
-2.00ms - +1.28ms		unsure 🔍
-10% - +5%
-2.46ms - +1.32ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
65.71ms - 69.49ms-unsure 🔍
-2% - +4%
-1.61ms - +2.97ms		unsure 🔍
-1% - +6%
-0.63ms - +3.69ms
tip-of-tree
tip-of-tree		65.62ms - 68.21msunsure 🔍
-4% - +2%
-2.97ms - +1.61ms		-unsure 🔍
-1% - +4%
-0.81ms - +2.51ms
previous-release
previous-release		65.02ms - 67.10msunsure 🔍
-5% - +1%
-3.69ms - +0.63ms		unsure 🔍
-4% - +1%
-2.51ms - +0.81ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
142.16ms - 148.48ms-unsure 🔍
-3% - +3%
-4.81ms - +4.38ms		unsure 🔍
-2% - +4%
-3.20ms - +5.75ms
tip-of-tree
tip-of-tree		142.20ms - 148.86msunsure 🔍
-3% - +3%
-4.38ms - +4.81ms		-unsure 🔍
-2% - +4%
-3.11ms - +6.08ms
previous-release
previous-release		140.88ms - 147.21msunsure 🔍
-4% - +2%
-5.75ms - +3.20ms		unsure 🔍
-4% - +2%
-6.08ms - +3.11ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
63.63ms - 67.10ms-faster ✔
0% - 8%
0.13ms - 5.61ms		faster ✔
0% - 7%
0.08ms - 5.00ms
tip-of-tree
tip-of-tree		66.11ms - 70.35msslower ❌
0% - 9%
0.13ms - 5.61ms		-unsure 🔍
-4% - +5%
-2.42ms - +3.07ms
previous-release
previous-release		66.17ms - 69.65msslower ❌
0% - 8%
0.08ms - 5.00ms		unsure 🔍
-4% - +4%
-3.07ms - +2.42ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1009.51ms - 1044.25ms-unsure 🔍
-2% - +2%
-21.93ms - +23.24ms		unsure 🔍
-3% - +2%
-26.51ms - +18.22ms
tip-of-tree
tip-of-tree		1011.79ms - 1040.66msunsure 🔍
-2% - +2%
-23.24ms - +21.93ms		-unsure 🔍
-2% - +1%
-24.97ms - +15.37ms
previous-release
previous-release		1016.93ms - 1045.11msunsure 🔍
-2% - +3%
-18.22ms - +26.51ms		unsure 🔍
-2% - +2%
-15.37ms - +24.97ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1020.55ms - 1051.22ms-unsure 🔍
-2% - +2%
-22.16ms - +22.03ms		unsure 🔍
-2% - +2%
-20.21ms - +19.36ms
tip-of-tree
tip-of-tree		1020.04ms - 1051.86msunsure 🔍
-2% - +2%
-22.03ms - +22.16ms		-unsure 🔍
-2% - +2%
-20.59ms - +19.87ms
previous-release
previous-release		1023.80ms - 1048.81msunsure 🔍
-2% - +2%
-19.36ms - +20.21ms		unsure 🔍
-2% - +2%
-19.87ms - +20.59ms		-

tachometer-reporter-action v2 for Benchmarks

justinfagnani
justinfagnani reviewed Aug 22, 2023
View reviewed changes
justinfagnani
justinfagnani approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

AndrewJakubowicz
AndrewJakubowicz approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you!

@AndrewJakubowicz AndrewJakubowicz merged commit 28c33d2 into lit:main Aug 22, 2023
@bennypowers bennypowers deleted the fix/gen-manifest/npm-files-and-main branch August 23, 2023 04:43
@bennypowers bennypowers mentioned this pull request Aug 29, 2023
Closed
@lit-robot lit-robot mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bennypowers @justinfagnani @AndrewJakubowicz