fix(analyzer): readonly fields #4135

bennypowers · 2023-08-24T07:42:44Z

constructor-assigned, non-decorated fields (i have my doubts about how well i implement this)
non-decorated readonly typescript class fields
non-decorated javascript class fields with @readonly jsdoc
non-decorated getter-only accessors (i.e. readonly: true)
non-decorated accessor pairs

changeset-bot · 2023-08-24T07:42:47Z

🦋 Changeset detected

Latest commit: b3f0929

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/analyzer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-08-24T07:43:01Z

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

nop-update

this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +11% (-0.75ms - +2.57ms)
^{this-change vs tip-of-tree}

render

this-change: 80.24ms - 83.63ms
this-change, tip-of-tree, previous-release: unsure 🔍 -7% - +3% (-2.47ms - +0.85ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.90ms - +1.27ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +1% (-1.73ms - +0.50ms)
^{this-change vs tip-of-tree}

update

this-change: 867.93ms - 886.14ms
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +7% (-1.24ms - +6.00ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-2.44ms - +1.96ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-14.55ms - +8.07ms)
^{this-change vs tip-of-tree}

update-reflect

this-change: 829.06ms - 845.10ms
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-12.44ms - +9.85ms)
^{this-change vs tip-of-tree}

Results

⏳ Benchmarks are currently running. Results below are out of date.

this-change

Browser: chrome-headless 116.0.5845.96
Sample size: 50
Built by: Benchmarks #5309
Commit: 26004a4

render

Version	Avg time	vs
	80.24ms - 83.63ms	-

update

Version	Avg time	vs
	867.93ms - 886.14ms	-

update-reflect

Version	Avg time	vs
	829.06ms - 845.10ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 116.0.5845.96
Sample size: 30
Built by: Benchmarks #5309
Commit: 26004a4

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	30.83ms - 33.36ms	-	unsure 🔍 -7% - +3% -2.47ms - +0.85ms	unsure 🔍 -7% - +3% -2.30ms - +0.95ms
tip-of-tree tip-of-tree	31.83ms - 33.98ms	unsure 🔍 -3% - +8% -0.85ms - +2.47ms	-	unsure 🔍 -4% - +5% -1.34ms - +1.62ms
previous-release previous-release	31.75ms - 33.79ms	unsure 🔍 -3% - +7% -0.95ms - +2.30ms	unsure 🔍 -5% - +4% -1.62ms - +1.34ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	85.48ms - 90.68ms	-	unsure 🔍 -2% - +7% -1.24ms - +6.00ms	unsure 🔍 -4% - +4% -3.11ms - +3.50ms
tip-of-tree tip-of-tree	83.17ms - 88.21ms	unsure 🔍 -7% - +1% -6.00ms - +1.24ms	-	unsure 🔍 -6% - +1% -5.43ms - +1.06ms
previous-release previous-release	85.84ms - 89.92ms	unsure 🔍 -4% - +4% -3.50ms - +3.11ms	unsure 🔍 -1% - +6% -1.06ms - +5.43ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	23.28ms - 25.91ms	-	unsure 🔍 -3% - +11% -0.75ms - +2.57ms	unsure 🔍 -5% - +11% -1.19ms - +2.49ms
tip-of-tree tip-of-tree	22.68ms - 24.70ms	unsure 🔍 -10% - +3% -2.57ms - +0.75ms	-	unsure 🔍 -8% - +6% -1.89ms - +1.38ms
previous-release previous-release	22.66ms - 25.23ms	unsure 🔍 -10% - +5% -2.49ms - +1.19ms	unsure 🔍 -6% - +8% -1.38ms - +1.89ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 116.0.5845.96
Sample size: 50
Built by: Benchmarks #5309
Commit: 26004a4

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	57.56ms - 59.22ms	-	unsure 🔍 -2% - +2% -0.90ms - +1.27ms	unsure 🔍 -1% - +3% -0.80ms - +1.62ms
tip-of-tree tip-of-tree	57.51ms - 58.90ms	unsure 🔍 -2% - +2% -1.27ms - +0.90ms	-	unsure 🔍 -2% - +2% -0.89ms - +1.35ms
previous-release previous-release	57.10ms - 58.86ms	unsure 🔍 -3% - +1% -1.62ms - +0.80ms	unsure 🔍 -2% - +2% -1.35ms - +0.89ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	121.04ms - 124.35ms	-	unsure 🔍 -2% - +2% -2.44ms - +1.96ms	unsure 🔍 -3% - +2% -3.25ms - +1.95ms
tip-of-tree tip-of-tree	121.49ms - 124.38ms	unsure 🔍 -2% - +2% -1.96ms - +2.44ms	-	unsure 🔍 -2% - +2% -2.88ms - +2.06ms
previous-release previous-release	121.34ms - 125.34ms	unsure 🔍 -2% - +3% -1.95ms - +3.25ms	unsure 🔍 -2% - +2% -2.06ms - +2.88ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 116.0.5845.96
Sample size: 50
Built by: Benchmarks #5309
Commit: 26004a4

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	48.25ms - 49.83ms	-	unsure 🔍 -3% - +1% -1.73ms - +0.50ms	faster ✔ 1% - 5% 0.54ms - 2.74ms
tip-of-tree tip-of-tree	48.86ms - 50.44ms	unsure 🔍 -1% - +4% -0.50ms - +1.73ms	-	unsure 🔍 -4% - +0% -2.12ms - +0.07ms
previous-release previous-release	49.92ms - 51.44ms	slower ❌ 1% - 6% 0.54ms - 2.74ms	unsure 🔍 -0% - +4% -0.07ms - +2.12ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	871.97ms - 889.01ms	-	unsure 🔍 -2% - +1% -14.55ms - +8.07ms	unsure 🔍 -2% - +1% -16.85ms - +6.53ms
tip-of-tree tip-of-tree	876.30ms - 891.17ms	unsure 🔍 -1% - +2% -8.07ms - +14.55ms	-	unsure 🔍 -1% - +1% -12.84ms - +9.01ms
previous-release previous-release	877.65ms - 893.65ms	unsure 🔍 -1% - +2% -6.53ms - +16.85ms	unsure 🔍 -1% - +1% -9.01ms - +12.84ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	857.86ms - 873.29ms	-	unsure 🔍 -1% - +1% -12.44ms - +9.85ms	unsure 🔍 -2% - +1% -15.65ms - +6.50ms
tip-of-tree tip-of-tree	858.83ms - 874.91ms	unsure 🔍 -1% - +1% -9.85ms - +12.44ms	-	unsure 🔍 -2% - +1% -14.58ms - +8.03ms
previous-release previous-release	862.20ms - 878.10ms	unsure 🔍 -1% - +2% -6.50ms - +15.65ms	unsure 🔍 -1% - +2% -8.03ms - +14.58ms	-

_{tachometer-reporter-action v2 for Benchmarks}

bennypowers · 2023-08-24T07:46:12Z

At the moment, the accessors aren't even added to the fieldsMap

justinfagnani

awesome!

packages/labs/analyzer/test-files/js/properties/element-a.js

packages/labs/analyzer/test-files/ts/properties/src/element-a.ts

packages/labs/analyzer/src/lib/javascript/classes.ts

justinfagnani · 2023-08-24T14:29:44Z

packages/labs/analyzer/test-files/js/properties/element-a.js

+
  constructor() {
    super();
+    this.constructorAssignOnly = 0;


can we make something readonly that's in the LitElement static properties block?

I'd still want to cover the case of a javascript file with a constructor-assigned field

imo readonly is an additional layer to that

packages/labs/analyzer/src/test/lit-element/properties_test.ts

justinfagnani

🎉

test(analyzer): readonly fields

947a25b

bennypowers added 4 commits August 24, 2023 10:58

fix(analyzer): readonly class fields

c7c485d

feat(analyzer): constructor-assigned non-reactive fields

38bc649

docs: changelog

8c716d3

fix(analyer): accessors

26004a4

bennypowers marked this pull request as ready for review August 24, 2023 08:56

bennypowers requested a review from kevinpschaaf as a code owner August 24, 2023 08:56

justinfagnani reviewed Aug 24, 2023

View reviewed changes

docs: comments from review

b3f0929

justinfagnani approved these changes Aug 24, 2023

View reviewed changes

justinfagnani merged commit 5ff19a0 into lit:main Aug 24, 2023

bennypowers deleted the fix/analyzer/readonly-propertylike branch August 24, 2023 17:05

bennypowers mentioned this pull request Aug 29, 2023

[tools]: adopt the lit analyzer RedHat-UX/red-hat-design-system#1133

Closed

lit-robot mentioned this pull request Aug 30, 2023

Version Packages #4162

Merged

bennypowers mentioned this pull request Sep 4, 2023

[labs/analyzer] add mixin support #4147

Merged

fix(analyzer): readonly fields #4135

fix(analyzer): readonly fields #4135

Uh oh!

Conversation

bennypowers commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

Uh oh!

bennypowers commented Aug 24, 2023

Uh oh!

justinfagnani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

justinfagnani Aug 24, 2023

Choose a reason for hiding this comment

Uh oh!

bennypowers Aug 24, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinfagnani left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bennypowers commented Aug 24, 2023 •

edited

Loading

changeset-bot bot commented Aug 24, 2023 •

edited

Loading

github-actions bot commented Aug 24, 2023 •

edited

Loading