Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(analyzer): ecma private members #4148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bennypowers merged 3 commits into from
Aug 28, 2023
Merged

fix(analyzer): ecma private members #4148

bennypowers merged 3 commits into from
Aug 28, 2023

Conversation

@bennypowers
Copy link
Collaborator

@bennypowers bennypowers commented Aug 27, 2023

Closes #4127

@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: af30008

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/analyzer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +17% (-0.72ms - +4.27ms)
    this-change vs tip-of-tree

render

  • this-change: 99.30ms - 102.75ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +4% (-2.34ms - +1.85ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +4% (-0.79ms - +2.62ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +2% (-1.87ms - +1.29ms)
    this-change vs tip-of-tree

update

  • this-change: 1097.99ms - 1115.38ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +8% (-6.64ms - +8.98ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +4% (-2.34ms - +5.72ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-8.43ms - +20.75ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 1059.86ms - 1075.43ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-6.79ms - +19.41ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
99.30ms - 102.75ms-

update

VersionAvg timevs
1097.99ms - 1115.38ms-

update-reflect

VersionAvg timevs
1059.86ms - 1075.43ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
41.47ms - 44.26ms-unsure 🔍
-5% - +4%
-2.34ms - +1.85ms		unsure 🔍
-3% - +7%
-1.36ms - +2.81ms
tip-of-tree
tip-of-tree		41.55ms - 44.68msunsure 🔍
-4% - +5%
-1.85ms - +2.34ms		-unsure 🔍
-3% - +8%
-1.23ms - +3.17ms
previous-release
previous-release		40.59ms - 43.69msunsure 🔍
-7% - +3%
-2.81ms - +1.36ms		unsure 🔍
-7% - +3%
-3.17ms - +1.23ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
104.01ms - 114.08ms-unsure 🔍
-6% - +8%
-6.64ms - +8.98ms		unsure 🔍
-6% - +8%
-6.12ms - +8.42ms
tip-of-tree
tip-of-tree		101.91ms - 113.85msunsure 🔍
-8% - +6%
-8.98ms - +6.64ms		-unsure 🔍
-7% - +7%
-7.96ms - +7.93ms
previous-release
previous-release		102.65ms - 113.14msunsure 🔍
-8% - +6%
-8.42ms - +6.12ms		unsure 🔍
-7% - +7%
-7.93ms - +7.96ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
25.32ms - 29.34ms-unsure 🔍
-3% - +17%
-0.72ms - +4.27ms		unsure 🔍
-6% - +14%
-1.51ms - +3.53ms
tip-of-tree
tip-of-tree		24.07ms - 27.03msunsure 🔍
-15% - +2%
-4.27ms - +0.72ms		-unsure 🔍
-11% - +5%
-2.88ms - +1.35ms
previous-release
previous-release		24.80ms - 27.83msunsure 🔍
-13% - +5%
-3.53ms - +1.51ms		unsure 🔍
-5% - +11%
-1.35ms - +2.88ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
66.99ms - 69.81ms-unsure 🔍
-1% - +4%
-0.79ms - +2.62ms		unsure 🔍
-2% - +4%
-1.02ms - +2.61ms
tip-of-tree
tip-of-tree		66.53ms - 68.44msunsure 🔍
-4% - +1%
-2.62ms - +0.79ms		-unsure 🔍
-2% - +2%
-1.61ms - +1.36ms
previous-release
previous-release		66.46ms - 68.75msunsure 🔍
-4% - +1%
-2.61ms - +1.02ms		unsure 🔍
-2% - +2%
-1.36ms - +1.61ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
144.89ms - 150.54ms-unsure 🔍
-2% - +4%
-2.34ms - +5.72ms		unsure 🔍
-0% - +5%
-0.53ms - +6.77ms
tip-of-tree
tip-of-tree		143.15ms - 148.89msunsure 🔍
-4% - +2%
-5.72ms - +2.34ms		-unsure 🔍
-2% - +4%
-2.26ms - +5.12ms
previous-release
previous-release		142.28ms - 146.91msunsure 🔍
-5% - +0%
-6.77ms - +0.53ms		unsure 🔍
-3% - +2%
-5.12ms - +2.26ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
63.36ms - 65.77ms-unsure 🔍
-3% - +2%
-1.87ms - +1.29ms		unsure 🔍
-3% - +2%
-1.79ms - +1.47ms
tip-of-tree
tip-of-tree		63.84ms - 65.88msunsure 🔍
-2% - +3%
-1.29ms - +1.87ms		-unsure 🔍
-2% - +3%
-1.37ms - +1.64ms
previous-release
previous-release		63.63ms - 65.83msunsure 🔍
-2% - +3%
-1.47ms - +1.79ms		unsure 🔍
-3% - +2%
-1.64ms - +1.37ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1109.83ms - 1131.27ms-unsure 🔍
-1% - +2%
-8.43ms - +20.75ms		unsure 🔍
-1% - +1%
-14.67ms - +16.11ms
tip-of-tree
tip-of-tree		1104.50ms - 1124.28msunsure 🔍
-2% - +1%
-20.75ms - +8.43ms		-unsure 🔍
-2% - +1%
-20.26ms - +9.39ms
previous-release
previous-release		1108.79ms - 1130.87msunsure 🔍
-1% - +1%
-16.11ms - +14.67ms		unsure 🔍
-1% - +2%
-9.39ms - +20.26ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1109.55ms - 1127.93ms-unsure 🔍
-1% - +2%
-6.79ms - +19.41ms		unsure 🔍
-1% - +1%
-11.93ms - +14.11ms
tip-of-tree
tip-of-tree		1103.09ms - 1121.77msunsure 🔍
-2% - +1%
-19.41ms - +6.79ms		-unsure 🔍
-2% - +1%
-18.35ms - +7.90ms
previous-release
previous-release		1108.43ms - 1126.88msunsure 🔍
-1% - +1%
-14.11ms - +11.93ms		unsure 🔍
-1% - +2%
-7.90ms - +18.35ms		-

tachometer-reporter-action v2 for Benchmarks

@bennypowers bennypowers enabled auto-merge (squash) August 27, 2023 06:04
bennypowers
bennypowers commented Aug 27, 2023
View reviewed changes
@justinfagnani justinfagnani self-requested a review August 28, 2023 15:34
justinfagnani
justinfagnani approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

packages/labs/analyzer/src/lib/javascript/classes.ts
if (
!typescript.isIdentifier(node.name) &&
!typescript.isPrivateIdentifier(node.name)
) {
Copy link
Collaborator

@justinfagnani justinfagnani Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No action needed: thinking out loud. Regarding this diagnostic below, I wonder if it really deserves being a warning. It's not a problem with the code, it's a limitation of the analyzer. I hope we have a way of ignoring errors at the line and project level.

@bennypowers bennypowers merged commit 5d68e64 into main Aug 28, 2023
@bennypowers bennypowers deleted the fix/analyzer/ecma-private-methods branch August 28, 2023 15:44
@bennypowers bennypowers mentioned this pull request Jul 6, 2023
Closed
@lit-robot lit-robot mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[labs/analyzer]: ecma #private methods marked as public

2 participants

@bennypowers @justinfagnani