Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: remove private labs/compiler package from release notes #4190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndrewJakubowicz merged 1 commit into from
Sep 12, 2023
Merged

chore: remove private labs/compiler package from release notes #4190

AndrewJakubowicz merged 1 commit into from
Sep 12, 2023

Conversation

@AndrewJakubowicz
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz commented Sep 12, 2023

Context

During release (#4189), noticed that there was a compiler version bump. That isn't required yet for a private package.

This change means the compiler will not get version bumped.

Low risk change.

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023

⚠️ No Changeset found

Latest commit: 49b505d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 2 packages
Name Type
@lit/localize-tools Patch
@lit-labs/ssr Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -9% - +3% (-1.73ms - +0.65ms)
    this-change vs tip-of-tree

render

  • this-change: 69.86ms - 72.79ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +4% (-1.47ms - +1.26ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.53ms - +1.51ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-0.52ms - +0.99ms)
    this-change vs tip-of-tree

update

  • this-change: 760.32ms - 770.93ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +6% (-2.41ms - +4.12ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-1.76ms - +2.21ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-8.70ms - +5.89ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 735.18ms - 743.45ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-4.96ms - +5.10ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
69.86ms - 72.79ms-

update

VersionAvg timevs
760.32ms - 770.93ms-

update-reflect

VersionAvg timevs
735.18ms - 743.45ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
27.12ms - 28.85ms-unsure 🔍
-5% - +4%
-1.47ms - +1.26ms		unsure 🔍
-4% - +5%
-1.24ms - +1.30ms
tip-of-tree
tip-of-tree		27.03ms - 29.15msunsure 🔍
-5% - +5%
-1.26ms - +1.47ms		-unsure 🔍
-5% - +6%
-1.28ms - +1.54ms
previous-release
previous-release		27.02ms - 28.89msunsure 🔍
-5% - +4%
-1.30ms - +1.24ms		unsure 🔍
-5% - +5%
-1.54ms - +1.28ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
73.13ms - 78.22ms-unsure 🔍
-3% - +6%
-2.41ms - +4.12ms		unsure 🔍
-4% - +6%
-3.31ms - +4.33ms
tip-of-tree
tip-of-tree		72.77ms - 76.87msunsure 🔍
-5% - +3%
-4.12ms - +2.41ms		-unsure 🔍
-5% - +4%
-3.85ms - +3.16ms
previous-release
previous-release		72.32ms - 78.01msunsure 🔍
-6% - +4%
-4.33ms - +3.31ms		unsure 🔍
-4% - +5%
-3.16ms - +3.85ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.54ms - 20.09ms-unsure 🔍
-9% - +3%
-1.73ms - +0.65ms		unsure 🔍
-8% - +4%
-1.69ms - +0.77ms
tip-of-tree
tip-of-tree		18.95ms - 20.76msunsure 🔍
-3% - +9%
-0.65ms - +1.73ms		-unsure 🔍
-6% - +7%
-1.24ms - +1.40ms
previous-release
previous-release		18.82ms - 20.74msunsure 🔍
-4% - +9%
-0.77ms - +1.69ms		unsure 🔍
-7% - +6%
-1.40ms - +1.24ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
50.65ms - 52.01ms-unsure 🔍
-1% - +3%
-0.53ms - +1.51ms		unsure 🔍
-2% - +2%
-0.77ms - +1.07ms
tip-of-tree
tip-of-tree		50.08ms - 51.60msunsure 🔍
-3% - +1%
-1.51ms - +0.53ms		-unsure 🔍
-3% - +1%
-1.33ms - +0.63ms
previous-release
previous-release		50.56ms - 51.80msunsure 🔍
-2% - +2%
-1.07ms - +0.77ms		unsure 🔍
-1% - +3%
-0.63ms - +1.33ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
112.19ms - 115.09ms-unsure 🔍
-2% - +2%
-1.76ms - +2.21ms		unsure 🔍
-2% - +2%
-1.83ms - +1.72ms
tip-of-tree
tip-of-tree		112.07ms - 114.77msunsure 🔍
-2% - +2%
-2.21ms - +1.76ms		-unsure 🔍
-2% - +1%
-1.97ms - +1.41ms
previous-release
previous-release		112.67ms - 114.72msunsure 🔍
-2% - +2%
-1.72ms - +1.83ms		unsure 🔍
-1% - +2%
-1.41ms - +1.97ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
43.73ms - 44.83ms-unsure 🔍
-1% - +2%
-0.52ms - +0.99ms		unsure 🔍
-2% - +1%
-1.03ms - +0.57ms
tip-of-tree
tip-of-tree		43.53ms - 44.56msunsure 🔍
-2% - +1%
-0.99ms - +0.52ms		-unsure 🔍
-3% - +1%
-1.24ms - +0.31ms
previous-release
previous-release		43.94ms - 45.09msunsure 🔍
-1% - +2%
-0.57ms - +1.03ms		unsure 🔍
-1% - +3%
-0.31ms - +1.24ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
775.82ms - 786.29ms-unsure 🔍
-1% - +1%
-8.70ms - +5.89ms		unsure 🔍
-1% - +1%
-6.50ms - +7.60ms
tip-of-tree
tip-of-tree		777.37ms - 787.54msunsure 🔍
-1% - +1%
-5.89ms - +8.70ms		-unsure 🔍
-1% - +1%
-4.98ms - +8.89ms
previous-release
previous-release		775.78ms - 785.22msunsure 🔍
-1% - +1%
-7.60ms - +6.50ms		unsure 🔍
-1% - +1%
-8.89ms - +4.98ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
770.43ms - 776.94ms-unsure 🔍
-1% - +1%
-4.96ms - +5.10ms		unsure 🔍
-1% - +1%
-5.96ms - +4.39ms
tip-of-tree
tip-of-tree		769.78ms - 777.45msunsure 🔍
-1% - +1%
-5.10ms - +4.96ms		-unsure 🔍
-1% - +1%
-6.41ms - +4.71ms
previous-release
previous-release		770.44ms - 778.50msunsure 🔍
-1% - +1%
-4.39ms - +5.96ms		unsure 🔍
-1% - +1%
-4.71ms - +6.41ms		-

tachometer-reporter-action v2 for Benchmarks

@AndrewJakubowicz AndrewJakubowicz merged commit fcb1d4a into main Sep 12, 2023
@AndrewJakubowicz AndrewJakubowicz deleted the fix-release branch September 12, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aomarks aomarks aomarks approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@rictic rictic Awaiting requested review from rictic

@e111077 e111077 Awaiting requested review from e111077

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewJakubowicz @aomarks