Version Packages #4192

lit-robot · 2023-09-12T17:52:40Z

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@lit-labs/[email protected]

Patch Changes

#4171 c9f12f65 - Fix an infinite loop that occurred when multiple providers were declared for a single context on the same host. This is an error, but we shouldn't go into an infinite loop over it.

@lit-labs/[email protected]

Patch Changes

#4172 dc1d323f - Revert custom children type added in [labs/react] Fix type compatibility with Preact when adding children #4142 and instead use our copy of PropsWithoutRef type so that preact/compat typing will work.
Preact users facing type errors using wrapped components should configure "paths" in their tsconfig.json so that react types will instead resolve to preact/compat as described in Preact's TypeScript documentation.
Going with preact/compat also solves compatibility issues arising from TypeScript >= 5.1 changing JSX tag type check.

@lit-labs/[email protected]

Patch Changes

#4188 4b1dc1b6 Thanks @jimsimon! - Improve "partIndex" error message to include the offending template, details about common causes, and a link to the docs.
#4175 84bb0523 Thanks @43081j! - Update parse5/tools to simplify importing of node types from the default tree adapter
#4168 444599eb Thanks @43081j! - Upgrade parse5 to 7.x in localize-tools and import from root of parse5 where possible

@lit/[email protected]

Patch Changes

#4175 84bb0523 Thanks @43081j! - Update parse5/tools to simplify importing of node types from the default tree adapter
#4168 444599eb Thanks @43081j! - Upgrade parse5 to 7.x in localize-tools and import from root of parse5 where possible

github-actions · 2023-09-12T17:52:54Z

📊 Tachometer Benchmark Results

Summary

nop-update

this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +8% (-1.26ms - +1.63ms)
^{this-change vs tip-of-tree}

render

this-change: 70.88ms - 82.81ms
this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +7% (-0.77ms - +1.88ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.94ms - +1.02ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.83ms - +0.75ms)
^{this-change vs tip-of-tree}

update

this-change: 799.86ms - 814.34ms
this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +7% (-3.31ms - +5.15ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-2.74ms - +2.02ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-10.18ms - +11.44ms)
^{this-change vs tip-of-tree}

update-reflect

this-change: 770.42ms - 782.72ms
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-10.87ms - +10.46ms)
^{this-change vs tip-of-tree}

Results

this-change

Browser: chrome-headless 116.0.5845.140
Sample size: 50
Built by: Benchmarks #5484
Commit: 3c8c8cf

render

Version	Avg time	vs
	70.88ms - 82.81ms	-

update

Version	Avg time	vs
	799.86ms - 814.34ms	-

update-reflect

Version	Avg time	vs
	770.42ms - 782.72ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 116.0.5845.140
Sample size: 30
Built by: Benchmarks #5484
Commit: 3c8c8cf

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	27.26ms - 29.21ms	-	unsure 🔍 -3% - +7% -0.77ms - +1.88ms	unsure 🔍 -0% - +10% +0.00ms - +2.69ms
tip-of-tree tip-of-tree	26.78ms - 28.57ms	unsure 🔍 -7% - +3% -1.88ms - +0.77ms	-	unsure 🔍 -2% - +8% -0.50ms - +2.08ms
previous-release previous-release	25.96ms - 27.81ms	faster ✔ 0% - 9% 0.00ms - 2.69ms	unsure 🔍 -7% - +2% -2.08ms - +0.50ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	73.54ms - 80.23ms	-	unsure 🔍 -4% - +7% -3.31ms - +5.15ms	unsure 🔍 -2% - +9% -1.82ms - +6.34ms
tip-of-tree tip-of-tree	73.37ms - 78.56ms	unsure 🔍 -7% - +4% -5.15ms - +3.31ms	-	unsure 🔍 -3% - +7% -2.16ms - +4.83ms
previous-release previous-release	72.29ms - 76.97ms	unsure 🔍 -8% - +2% -6.34ms - +1.82ms	unsure 🔍 -6% - +3% -4.83ms - +2.16ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	19.04ms - 21.24ms	-	unsure 🔍 -6% - +8% -1.26ms - +1.63ms	unsure 🔍 -5% - +10% -0.99ms - +2.01ms
tip-of-tree tip-of-tree	19.01ms - 20.89ms	unsure 🔍 -8% - +6% -1.63ms - +1.26ms	-	unsure 🔍 -5% - +9% -1.06ms - +1.71ms
previous-release previous-release	18.61ms - 20.64ms	unsure 🔍 -10% - +5% -2.01ms - +0.99ms	unsure 🔍 -9% - +5% -1.71ms - +1.06ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 116.0.5845.140
Sample size: 50
Built by: Benchmarks #5484
Commit: 3c8c8cf

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	50.22ms - 51.62ms	-	unsure 🔍 -2% - +2% -0.94ms - +1.02ms	unsure 🔍 -1% - +2% -0.72ms - +1.14ms
tip-of-tree tip-of-tree	50.19ms - 51.57ms	unsure 🔍 -2% - +2% -1.02ms - +0.94ms	-	unsure 🔍 -1% - +2% -0.75ms - +1.09ms
previous-release previous-release	50.10ms - 51.32ms	unsure 🔍 -2% - +1% -1.14ms - +0.72ms	unsure 🔍 -2% - +1% -1.09ms - +0.75ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	109.41ms - 112.79ms	-	unsure 🔍 -2% - +2% -2.74ms - +2.02ms	unsure 🔍 -1% - +3% -0.84ms - +3.48ms
tip-of-tree tip-of-tree	109.78ms - 113.14ms	unsure 🔍 -2% - +2% -2.02ms - +2.74ms	-	unsure 🔍 -0% - +4% -0.47ms - +3.83ms
previous-release previous-release	108.43ms - 111.13ms	unsure 🔍 -3% - +1% -3.48ms - +0.84ms	unsure 🔍 -3% - +0% -3.83ms - +0.47ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 116.0.5845.140
Sample size: 50
Built by: Benchmarks #5484
Commit: 3c8c8cf

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	44.04ms - 45.05ms	-	unsure 🔍 -2% - +2% -0.83ms - +0.75ms	unsure 🔍 -3% - +0% -1.56ms - +0.11ms
tip-of-tree tip-of-tree	43.98ms - 45.19ms	unsure 🔍 -2% - +2% -0.75ms - +0.83ms	-	unsure 🔍 -3% - +0% -1.58ms - +0.21ms
previous-release previous-release	44.60ms - 45.94ms	unsure 🔍 -0% - +4% -0.11ms - +1.56ms	unsure 🔍 -0% - +4% -0.21ms - +1.58ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	810.83ms - 827.16ms	-	unsure 🔍 -1% - +1% -10.18ms - +11.44ms	unsure 🔍 -1% - +2% -8.07ms - +12.80ms
tip-of-tree tip-of-tree	811.29ms - 825.45ms	unsure 🔍 -1% - +1% -11.44ms - +10.18ms	-	unsure 🔍 -1% - +1% -7.87ms - +11.35ms
previous-release previous-release	810.13ms - 823.13ms	unsure 🔍 -2% - +1% -12.80ms - +8.07ms	unsure 🔍 -1% - +1% -11.35ms - +7.87ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	801.34ms - 814.98ms	-	unsure 🔍 -1% - +1% -10.87ms - +10.46ms	unsure 🔍 -1% - +2% -6.18ms - +12.20ms
tip-of-tree tip-of-tree	800.16ms - 816.57ms	unsure 🔍 -1% - +1% -10.46ms - +10.87ms	-	unsure 🔍 -1% - +2% -7.04ms - +13.47ms
previous-release previous-release	798.99ms - 811.31ms	unsure 🔍 -2% - +1% -12.20ms - +6.18ms	unsure 🔍 -2% - +1% -13.47ms - +7.04ms	-

_{tachometer-reporter-action v2 for Benchmarks}

Version Packages

3c8c8cf

lit-robot requested review from benjamind and kevinpschaaf as code owners September 12, 2023 17:52

AndrewJakubowicz requested review from AndrewJakubowicz, justinfagnani and rictic September 12, 2023 17:56

AndrewJakubowicz approved these changes Sep 12, 2023

View reviewed changes

AndrewJakubowicz mentioned this pull request Sep 12, 2023

Version Packages #4189

Closed

justinfagnani approved these changes Sep 12, 2023

View reviewed changes

AndrewJakubowicz merged commit a120184 into main Sep 12, 2023

AndrewJakubowicz deleted the changeset-release/main branch September 12, 2023 20:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Version Packages #4192

Version Packages #4192

Uh oh!

lit-robot commented Sep 12, 2023

Uh oh!

github-actions bot commented Sep 12, 2023 •

edited

Loading

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Version Packages #4192

Version Packages #4192

Uh oh!

Conversation

lit-robot commented Sep 12, 2023

Releases

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

@lit/[email protected]

Patch Changes

Uh oh!

github-actions bot commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Sep 12, 2023 •

edited

Loading