Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/analyzer] Add TypeScript nodes to analyzer model objects #4260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 2 commits into from
Oct 27, 2023
Merged

[labs/analyzer] Add TypeScript nodes to analyzer model objects #4260

justinfagnani merged 2 commits into from
Oct 27, 2023

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Oct 4, 2023

This makes it easier to get to TypeScript nodes from analyzer model objects. This will be useful in linters, tests, decorator transforms, etc.

@justinfagnani justinfagnani requested a review from 43081j October 4, 2023 18:20
@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 8dcc86d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@lit-labs/analyzer Minor
@lit-labs/cli Patch
@lit-labs/gen-manifest Patch
@lit-labs/gen-utils Patch
@lit-labs/gen-wrapper-angular Patch
@lit-labs/gen-wrapper-react Patch
@lit-labs/gen-wrapper-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +5% (-0.49ms - +0.76ms)
    this-change vs tip-of-tree

render

  • this-change: 66.25ms - 69.66ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +2% (-2.29ms - +0.66ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +4% (-0.54ms - +2.01ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.97ms - +1.01ms)
    this-change vs tip-of-tree

update

  • this-change: 739.21ms - 753.51ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +1% (-3.19ms - +0.73ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-1.01ms - +2.17ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-7.03ms - +4.61ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 727.00ms - 735.88ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +0% (-13.59ms - +0.52ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
66.25ms - 69.66ms-

update

VersionAvg timevs
739.21ms - 753.51ms-

update-reflect

VersionAvg timevs
727.00ms - 735.88ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
25.25ms - 27.49ms-unsure 🔍
-8% - +2%
-2.29ms - +0.66ms		unsure 🔍
-4% - +7%
-0.96ms - +1.90ms
tip-of-tree
tip-of-tree		26.23ms - 28.15msunsure 🔍
-3% - +9%
-0.66ms - +2.29ms		-unsure 🔍
-0% - +10%
-0.02ms - +2.60ms
previous-release
previous-release		25.01ms - 26.79msunsure 🔍
-7% - +4%
-1.90ms - +0.96ms		unsure 🔍
-9% - -0%
-2.60ms - +0.02ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
57.00ms - 59.47ms-unsure 🔍
-5% - +1%
-3.19ms - +0.73ms		unsure 🔍
-3% - +4%
-1.45ms - +2.45ms
tip-of-tree
tip-of-tree		57.94ms - 60.99msunsure 🔍
-1% - +6%
-0.73ms - +3.19ms		-unsure 🔍
-1% - +7%
-0.41ms - +3.88ms
previous-release
previous-release		56.22ms - 59.24msunsure 🔍
-4% - +2%
-2.45ms - +1.45ms		unsure 🔍
-6% - +1%
-3.88ms - +0.41ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
15.32ms - 16.28ms-unsure 🔍
-3% - +5%
-0.49ms - +0.76ms		unsure 🔍
-5% - +4%
-0.75ms - +0.67ms
tip-of-tree
tip-of-tree		15.26ms - 16.08msunsure 🔍
-5% - +3%
-0.76ms - +0.49ms		-unsure 🔍
-5% - +3%
-0.85ms - +0.50ms
previous-release
previous-release		15.31ms - 16.37msunsure 🔍
-4% - +5%
-0.67ms - +0.75ms		unsure 🔍
-3% - +5%
-0.50ms - +0.85ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
48.94ms - 50.91ms-unsure 🔍
-1% - +4%
-0.54ms - +2.01ms		slower ❌
0% - 5%
0.17ms - 2.46ms
tip-of-tree
tip-of-tree		48.39ms - 49.99msunsure 🔍
-4% - +1%
-2.01ms - +0.54ms		-unsure 🔍
-1% - +3%
-0.41ms - +1.57ms
previous-release
previous-release		48.04ms - 49.19msfaster ✔
0% - 5%
0.17ms - 2.46ms		unsure 🔍
-3% - +1%
-1.57ms - +0.41ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
105.59ms - 107.92ms-unsure 🔍
-1% - +2%
-1.01ms - +2.17ms		unsure 🔍
-2% - +2%
-1.68ms - +1.92ms
tip-of-tree
tip-of-tree		105.09ms - 107.26msunsure 🔍
-2% - +1%
-2.17ms - +1.01ms		-unsure 🔍
-2% - +1%
-2.21ms - +1.28ms
previous-release
previous-release		105.27ms - 108.01msunsure 🔍
-2% - +2%
-1.92ms - +1.68ms		unsure 🔍
-1% - +2%
-1.28ms - +2.21ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
45.03ms - 46.43ms-unsure 🔍
-2% - +2%
-0.97ms - +1.01ms		unsure 🔍
-3% - +1%
-1.44ms - +0.61ms
tip-of-tree
tip-of-tree		45.01ms - 46.41msunsure 🔍
-2% - +2%
-1.01ms - +0.97ms		-unsure 🔍
-3% - +1%
-1.46ms - +0.58ms
previous-release
previous-release		45.40ms - 46.89msunsure 🔍
-1% - +3%
-0.61ms - +1.44ms		unsure 🔍
-1% - +3%
-0.58ms - +1.46ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
762.72ms - 770.88ms-unsure 🔍
-1% - +1%
-7.03ms - +4.61ms		unsure 🔍
-1% - +1%
-4.83ms - +6.78ms
tip-of-tree
tip-of-tree		763.86ms - 772.15msunsure 🔍
-1% - +1%
-4.61ms - +7.03ms		-unsure 🔍
-0% - +1%
-3.66ms - +8.03ms
previous-release
previous-release		761.69ms - 769.95msunsure 🔍
-1% - +1%
-6.78ms - +4.83ms		unsure 🔍
-1% - +0%
-8.03ms - +3.66ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
755.27ms - 764.19ms-unsure 🔍
-2% - +0%
-13.59ms - +0.52ms		unsure 🔍
-1% - +0%
-10.72ms - +2.38ms
tip-of-tree
tip-of-tree		760.80ms - 771.73msunsure 🔍
-0% - +2%
-0.52ms - +13.59ms		-unsure 🔍
-1% - +1%
-4.91ms - +9.64ms
previous-release
previous-release		759.10ms - 768.70msunsure 🔍
-0% - +1%
-2.38ms - +10.72ms		unsure 🔍
-1% - +1%
-9.64ms - +4.91ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

The size of lit-html.js and lit-core.min.js are as expected.

@justinfagnani justinfagnani mentioned this pull request Oct 4, 2023
Merged
Base automatically changed from 3.0 to main October 9, 2023 16:54
@justinfagnani justinfagnani merged commit 7a9804a into main Oct 27, 2023
@justinfagnani justinfagnani deleted the analyzer-nodes branch October 27, 2023 22:33
This was referenced Oct 27, 2023
Closed
Merged
@CxsLucyfer CxsLucyfer mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@43081j 43081j 43081j approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinfagnani @43081j