Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[context] Fix erroneous JSDoc description on @provide() decorator #4286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
augustjk merged 4 commits into from
Oct 17, 2023
Merged

[context] Fix erroneous JSDoc description on @provide() decorator #4286

augustjk merged 4 commits into from
Oct 17, 2023

Conversation

@augustjk
Copy link
Member

@augustjk augustjk commented Oct 12, 2023

User reported erroneous JSDoc on the @provide() decorator
https://discord.com/channels/1012791295170859069/1012791295942590597/1161821452983603240

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 1b58cf8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@lit/context Patch
@lit-labs/context Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -12% - +2% (-2.07ms - +0.45ms)
    this-change vs tip-of-tree

render

  • this-change: 74.07ms - 77.75ms
  • this-change, tip-of-tree, previous-release: faster ✔ 2% - 11% (0.60ms - 3.11ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +3% (-1.28ms - +1.62ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +3% (-1.92ms - +1.76ms)
    this-change vs tip-of-tree

update

  • this-change: 797.91ms - 808.89ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -10% - +3% (-6.55ms - +1.69ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +1% (-3.32ms - +0.91ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-6.76ms - +9.30ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 790.14ms - 800.35ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-10.86ms - +5.47ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
74.07ms - 77.75ms-

update

VersionAvg timevs
797.91ms - 808.89ms-

update-reflect

VersionAvg timevs
790.14ms - 800.35ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
25.52ms - 27.41ms-faster ✔
2% - 11%
0.60ms - 3.11ms		unsure 🔍
-9% - +2%
-2.52ms - +0.67ms
tip-of-tree
tip-of-tree		27.49ms - 29.14msslower ❌
2% - 12%
0.60ms - 3.11ms		-unsure 🔍
-2% - +9%
-0.59ms - +2.45ms
previous-release
previous-release		26.11ms - 28.67msunsure 🔍
-3% - +10%
-0.67ms - +2.52ms		unsure 🔍
-9% - +2%
-2.45ms - +0.59ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
58.04ms - 60.75ms-unsure 🔍
-10% - +3%
-6.55ms - +1.69ms		unsure 🔍
-7% - +4%
-3.95ms - +2.54ms
tip-of-tree
tip-of-tree		57.93ms - 65.72msunsure 🔍
-3% - +11%
-1.69ms - +6.55ms		-unsure 🔍
-5% - +11%
-3.16ms - +6.61ms
previous-release
previous-release		57.16ms - 63.05msunsure 🔍
-4% - +7%
-2.54ms - +3.95ms		unsure 🔍
-11% - +5%
-6.61ms - +3.16ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
15.73ms - 16.65ms-unsure 🔍
-12% - +2%
-2.07ms - +0.45ms		unsure 🔍
-5% - +3%
-0.79ms - +0.54ms
tip-of-tree
tip-of-tree		15.83ms - 18.17msunsure 🔍
-3% - +13%
-0.45ms - +2.07ms		-unsure 🔍
-4% - +12%
-0.58ms - +1.95ms
previous-release
previous-release		15.83ms - 16.80msunsure 🔍
-3% - +5%
-0.54ms - +0.79ms		unsure 🔍
-11% - +3%
-1.95ms - +0.58ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
49.85ms - 52.00ms-unsure 🔍
-3% - +3%
-1.28ms - +1.62ms		unsure 🔍
-2% - +4%
-0.85ms - +1.92ms
tip-of-tree
tip-of-tree		49.78ms - 51.72msunsure 🔍
-3% - +3%
-1.62ms - +1.28ms		-unsure 🔍
-2% - +3%
-0.95ms - +1.67ms
previous-release
previous-release		49.52ms - 51.26msunsure 🔍
-4% - +2%
-1.92ms - +0.85ms		unsure 🔍
-3% - +2%
-1.67ms - +0.95ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
109.02ms - 111.59ms-unsure 🔍
-3% - +1%
-3.32ms - +0.91ms		unsure 🔍
-3% - +1%
-3.52ms - +0.70ms
tip-of-tree
tip-of-tree		109.83ms - 113.19msunsure 🔍
-1% - +3%
-0.91ms - +3.32ms		-unsure 🔍
-2% - +2%
-2.58ms - +2.17ms
previous-release
previous-release		110.04ms - 113.39msunsure 🔍
-1% - +3%
-0.70ms - +3.52ms		unsure 🔍
-2% - +2%
-2.17ms - +2.58ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
50.44ms - 52.86ms-unsure 🔍
-4% - +3%
-1.92ms - +1.76ms		unsure 🔍
-3% - +3%
-1.59ms - +1.59ms
tip-of-tree
tip-of-tree		50.35ms - 53.12msunsure 🔍
-3% - +4%
-1.76ms - +1.92ms		-unsure 🔍
-3% - +3%
-1.64ms - +1.80ms
previous-release
previous-release		50.63ms - 52.67msunsure 🔍
-3% - +3%
-1.59ms - +1.59ms		unsure 🔍
-3% - +3%
-1.80ms - +1.64ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
843.35ms - 854.39ms-unsure 🔍
-1% - +1%
-6.76ms - +9.30ms		unsure 🔍
-2% - +0%
-13.72ms - +3.05ms
tip-of-tree
tip-of-tree		841.77ms - 853.43msunsure 🔍
-1% - +1%
-9.30ms - +6.76ms		-unsure 🔍
-2% - +0%
-15.19ms - +1.99ms
previous-release
previous-release		847.89ms - 860.51msunsure 🔍
-0% - +2%
-3.05ms - +13.72ms		unsure 🔍
-0% - +2%
-1.99ms - +15.19ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
834.29ms - 845.62ms-unsure 🔍
-1% - +1%
-10.86ms - +5.47ms		unsure 🔍
-1% - +1%
-8.25ms - +7.05ms
tip-of-tree
tip-of-tree		836.77ms - 848.53msunsure 🔍
-1% - +1%
-5.47ms - +10.86ms		-unsure 🔍
-1% - +1%
-5.72ms - +9.92ms
previous-release
previous-release		835.40ms - 845.70msunsure 🔍
-1% - +1%
-7.05ms - +8.25ms		unsure 🔍
-1% - +1%
-9.92ms - +5.72ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

The size of lit-html.js and lit-core.min.js are as expected.

AndrewJakubowicz
AndrewJakubowicz approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AndrewJakubowicz AndrewJakubowicz mentioned this pull request Oct 14, 2023
Closed
@augustjk augustjk linked an issue Oct 17, 2023 that may be closed by this pull request
The JSDoc for the @provide decorator is wrong #4292
Closed
@augustjk augustjk force-pushed the fix-context-provide-doc branch from 88cf135 to 1b58cf8 Compare October 17, 2023 18:55
@augustjk augustjk enabled auto-merge (squash) October 17, 2023 18:56
@augustjk augustjk merged commit 1fb7a10 into main Oct 17, 2023
@augustjk augustjk deleted the fix-context-provide-doc branch October 17, 2023 19:18
This was referenced Oct 27, 2023
Closed
Merged
@CxsLucyfer CxsLucyfer mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

@rictic rictic Awaiting requested review from rictic

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The JSDoc for the @provide decorator is wrong

2 participants

@augustjk @AndrewJakubowicz