Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update dependency version range to accept Lit v2 #4299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
augustjk merged 9 commits into from
Oct 18, 2023
Merged

Update dependency version range to accept Lit v2 #4299

augustjk merged 9 commits into from
Oct 18, 2023

Conversation

@augustjk
Copy link
Member

@augustjk augustjk commented Oct 17, 2023

Affected packages:

  • '@lit-labs/scoped-registry-mixin': patch
  • '@lit-labs/preact-signals': patch
  • '@lit-labs/observers': patch
  • '@lit/localize-tools': patch
  • '@lit-labs/motion': patch
  • '@lit-labs/router': patch
  • '@lit/localize': patch

I haven't touched SSR and related packages yet as they'll require a more specific range of v2 to work.

I tested that these packages work with the lower version by manually installing [email protected] or @lit/[email protected] within the package directory and running their tests.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 4cae85e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@lit-labs/scoped-registry-mixin Patch
@lit-labs/preact-signals Patch
@lit-labs/observers Patch
@lit/localize-tools Patch
@lit-labs/motion Patch
@lit-labs/router Patch
@lit/localize Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +3% (-1.12ms - +0.72ms)
    this-change vs tip-of-tree

render

  • this-change: 90.02ms - 94.59ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +3% (-2.40ms - +1.01ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +3% (-0.95ms - +2.15ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +4% (-0.24ms - +2.63ms)
    this-change vs tip-of-tree

update

  • this-change: 1024.88ms - 1044.43ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -7% - +1% (-6.38ms - +1.04ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-1.86ms - +4.38ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-15.23ms - +11.81ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 1011.36ms - 1024.58ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-20.31ms - +6.43ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
90.02ms - 94.59ms-

update

VersionAvg timevs
1024.88ms - 1044.43ms-

update-reflect

VersionAvg timevs
1011.36ms - 1024.58ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
37.65ms - 40.04ms-unsure 🔍
-6% - +3%
-2.40ms - +1.01ms		unsure 🔍
-7% - +1%
-2.78ms - +0.35ms
tip-of-tree
tip-of-tree		38.32ms - 40.76msunsure 🔍
-3% - +6%
-1.01ms - +2.40ms		-unsure 🔍
-5% - +3%
-2.10ms - +1.06ms
previous-release
previous-release		39.05ms - 41.07msunsure 🔍
-1% - +7%
-0.35ms - +2.78ms		unsure 🔍
-3% - +5%
-1.06ms - +2.10ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
80.30ms - 82.78ms-unsure 🔍
-7% - +1%
-6.38ms - +1.04ms		faster ✔
0% - 6%
0.14ms - 5.21ms
tip-of-tree
tip-of-tree		80.71ms - 87.71msunsure 🔍
-1% - +8%
-1.04ms - +6.38ms		-unsure 🔍
-5% - +5%
-4.14ms - +4.13ms
previous-release
previous-release		82.00ms - 86.42msslower ❌
0% - 6%
0.14ms - 5.21ms		unsure 🔍
-5% - +5%
-4.13ms - +4.14ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.59ms - 20.89ms-unsure 🔍
-5% - +3%
-1.12ms - +0.72ms		unsure 🔍
-3% - +6%
-0.60ms - +1.22ms
tip-of-tree
tip-of-tree		19.79ms - 21.09msunsure 🔍
-4% - +6%
-0.72ms - +1.12ms		-unsure 🔍
-2% - +7%
-0.39ms - +1.42ms
previous-release
previous-release		19.29ms - 20.56msunsure 🔍
-6% - +3%
-1.22ms - +0.60ms		unsure 🔍
-7% - +2%
-1.42ms - +0.39ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
62.23ms - 64.59ms-unsure 🔍
-2% - +3%
-0.95ms - +2.15ms		unsure 🔍
-3% - +3%
-1.64ms - +1.88ms
tip-of-tree
tip-of-tree		61.82ms - 63.81msunsure 🔍
-3% - +1%
-2.15ms - +0.95ms		-unsure 🔍
-3% - +2%
-2.13ms - +1.17ms
previous-release
previous-release		61.98ms - 64.60msunsure 🔍
-3% - +3%
-1.88ms - +1.64ms		unsure 🔍
-2% - +3%
-1.17ms - +2.13ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
134.32ms - 139.10ms-unsure 🔍
-1% - +3%
-1.86ms - +4.38ms		unsure 🔍
-3% - +2%
-3.56ms - +3.31ms
tip-of-tree
tip-of-tree		133.46ms - 137.44msunsure 🔍
-3% - +1%
-4.38ms - +1.86ms		-unsure 🔍
-3% - +1%
-4.56ms - +1.78ms
previous-release
previous-release		134.38ms - 139.30msunsure 🔍
-2% - +3%
-3.31ms - +3.56ms		unsure 🔍
-1% - +3%
-1.78ms - +4.56ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
66.43ms - 68.31ms-unsure 🔍
-0% - +4%
-0.24ms - +2.63ms		unsure 🔍
-0% - +4%
-0.11ms - +2.32ms
tip-of-tree
tip-of-tree		65.10ms - 67.26msunsure 🔍
-4% - +0%
-2.63ms - +0.24ms		-unsure 🔍
-2% - +2%
-1.41ms - +1.24ms
previous-release
previous-release		65.50ms - 67.03msunsure 🔍
-3% - +0%
-2.32ms - +0.11ms		unsure 🔍
-2% - +2%
-1.24ms - +1.41ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1059.68ms - 1076.89ms-unsure 🔍
-1% - +1%
-15.23ms - +11.81ms		unsure 🔍
-1% - +1%
-14.09ms - +11.43ms
tip-of-tree
tip-of-tree		1059.57ms - 1080.43msunsure 🔍
-1% - +1%
-11.81ms - +15.23ms		-unsure 🔍
-1% - +1%
-13.68ms - +14.43ms
previous-release
previous-release		1060.20ms - 1079.04msunsure 🔍
-1% - +1%
-11.43ms - +14.09ms		unsure 🔍
-1% - +1%
-14.43ms - +13.68ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1059.23ms - 1076.47ms-unsure 🔍
-2% - +1%
-20.31ms - +6.43ms		unsure 🔍
-2% - +1%
-17.43ms - +6.90ms
tip-of-tree
tip-of-tree		1064.57ms - 1085.01msunsure 🔍
-1% - +2%
-6.43ms - +20.31ms		-unsure 🔍
-1% - +1%
-11.68ms - +15.03ms
previous-release
previous-release		1064.53ms - 1081.70msunsure 🔍
-1% - +2%
-6.90ms - +17.43ms		unsure 🔍
-1% - +1%
-15.03ms - +11.68ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

The size of lit-html.js and lit-core.min.js are as expected.

AndrewJakubowicz
AndrewJakubowicz approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏

rictic
rictic approved these changes Oct 18, 2023
View reviewed changes
packages/localize/package.json Outdated
"/init/"
],
"dependencies": {
"@lit/reactive-element": "^2.0.0",
Copy link
Collaborator

@rictic rictic Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be broadened too?

Copy link
Member Author

@augustjk augustjk Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, yes it should!

@augustjk augustjk merged commit fffa440 into main Oct 18, 2023
@augustjk augustjk deleted the lit-dep-versions branch October 18, 2023 22:03
@augustjk augustjk mentioned this pull request Oct 18, 2023
Merged
This was referenced Oct 27, 2023
Closed
Merged
@CxsLucyfer CxsLucyfer mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rictic rictic rictic approved these changes

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@augustjk @rictic @AndrewJakubowicz