Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/virtualizer] Update version range for lit #4291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graynorton merged 1 commit into from
Oct 14, 2023
Merged

[labs/virtualizer] Update version range for lit #4291

graynorton merged 1 commit into from
Oct 14, 2023

Conversation

@graynorton
Copy link
Contributor

@graynorton graynorton commented Oct 13, 2023

Virtualizer should work with both Lit 2 and Lit 3; update package.json to reflect this.

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

🦋 Changeset detected

Latest commit: cfd13cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/virtualizer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +10% (-0.90ms - +2.19ms)
    this-change vs tip-of-tree

render

  • this-change: 117.80ms - 121.33ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -10% - +5% (-4.40ms - +2.31ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +4% (-3.96ms - +2.82ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +3% (-1.97ms - +2.58ms)
    this-change vs tip-of-tree

update

  • this-change: 1265.91ms - 1287.83ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -10% - +1% (-10.29ms - +1.08ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +4% (-6.58ms - +6.53ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-19.98ms - +18.07ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 1236.36ms - 1259.59ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-21.66ms - +10.74ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
117.80ms - 121.33ms-

update

VersionAvg timevs
1265.91ms - 1287.83ms-

update-reflect

VersionAvg timevs
1236.36ms - 1259.59ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
41.98ms - 45.34ms-unsure 🔍
-10% - +5%
-4.40ms - +2.31ms		unsure 🔍
-7% - +3%
-3.18ms - +1.16ms
tip-of-tree
tip-of-tree		41.80ms - 47.60msunsure 🔍
-5% - +10%
-2.31ms - +4.40ms		-unsure 🔍
-7% - +7%
-3.17ms - +3.24ms
previous-release
previous-release		43.31ms - 46.03msunsure 🔍
-3% - +7%
-1.16ms - +3.18ms		unsure 🔍
-7% - +7%
-3.24ms - +3.17ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
90.56ms - 98.10ms-unsure 🔍
-10% - +1%
-10.29ms - +1.08ms		unsure 🔍
-4% - +7%
-3.22ms - +6.16ms
tip-of-tree
tip-of-tree		94.68ms - 103.19msunsure 🔍
-1% - +11%
-1.08ms - +10.29ms		-slower ❌
1% - 12%
0.98ms - 11.16ms
previous-release
previous-release		90.07ms - 95.66msunsure 🔍
-6% - +3%
-6.16ms - +3.22ms		faster ✔
1% - 11%
0.98ms - 11.16ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
22.25ms - 24.33ms-unsure 🔍
-4% - +10%
-0.90ms - +2.19ms		unsure 🔍
-6% - +9%
-1.46ms - +2.08ms
tip-of-tree
tip-of-tree		21.50ms - 23.79msunsure 🔍
-9% - +4%
-2.19ms - +0.90ms		-unsure 🔍
-9% - +6%
-2.17ms - +1.51ms
previous-release
previous-release		21.54ms - 24.42msunsure 🔍
-9% - +6%
-2.08ms - +1.46ms		unsure 🔍
-7% - +10%
-1.51ms - +2.17ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
71.28ms - 75.42ms-unsure 🔍
-5% - +4%
-3.96ms - +2.82ms		unsure 🔍
-4% - +4%
-2.87ms - +3.09ms
tip-of-tree
tip-of-tree		71.24ms - 76.61msunsure 🔍
-4% - +5%
-2.82ms - +3.96ms		-unsure 🔍
-4% - +6%
-2.75ms - +4.11ms
previous-release
previous-release		71.10ms - 75.38msunsure 🔍
-4% - +4%
-3.09ms - +2.87ms		unsure 🔍
-6% - +4%
-4.11ms - +2.75ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
164.75ms - 174.16ms-unsure 🔍
-4% - +4%
-6.58ms - +6.53ms		unsure 🔍
-4% - +3%
-7.59ms - +4.88ms
tip-of-tree
tip-of-tree		164.92ms - 174.04msunsure 🔍
-4% - +4%
-6.53ms - +6.58ms		-unsure 🔍
-4% - +3%
-7.46ms - +4.81ms
previous-release
previous-release		166.71ms - 174.90msunsure 🔍
-3% - +4%
-4.88ms - +7.59ms		unsure 🔍
-3% - +4%
-4.81ms - +7.46ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
73.13ms - 76.10ms-unsure 🔍
-3% - +3%
-1.97ms - +2.58ms		unsure 🔍
-3% - +4%
-1.89ms - +2.82ms
tip-of-tree
tip-of-tree		72.59ms - 76.03msunsure 🔍
-3% - +3%
-2.58ms - +1.97ms		-unsure 🔍
-3% - +4%
-2.35ms - +2.67ms
previous-release
previous-release		72.32ms - 75.97msunsure 🔍
-4% - +3%
-2.82ms - +1.89ms		unsure 🔍
-4% - +3%
-2.67ms - +2.35ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1324.10ms - 1351.54ms-unsure 🔍
-1% - +1%
-19.98ms - +18.07ms		unsure 🔍
-2% - +1%
-21.44ms - +13.66ms
tip-of-tree
tip-of-tree		1325.60ms - 1351.95msunsure 🔍
-1% - +1%
-18.07ms - +19.98ms		-unsure 🔍
-1% - +1%
-20.07ms - +14.19ms
previous-release
previous-release		1330.77ms - 1352.66msunsure 🔍
-1% - +2%
-13.66ms - +21.44ms		unsure 🔍
-1% - +2%
-14.19ms - +20.07ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1308.42ms - 1334.69ms-unsure 🔍
-2% - +1%
-21.66ms - +10.74ms		unsure 🔍
-2% - +1%
-24.49ms - +10.34ms
tip-of-tree
tip-of-tree		1317.52ms - 1336.50msunsure 🔍
-1% - +2%
-10.74ms - +21.66ms		-unsure 🔍
-1% - +1%
-16.48ms - +13.25ms
previous-release
previous-release		1317.19ms - 1340.07msunsure 🔍
-1% - +2%
-10.34ms - +24.49ms		unsure 🔍
-1% - +1%
-13.25ms - +16.48ms		-

tachometer-reporter-action v2 for Benchmarks

@graynorton graynorton requested a review from augustjk October 13, 2023 23:46
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

The size of lit-html.js and lit-core.min.js are as expected.

augustjk
augustjk approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I was looking at whether we need to specify a specific minor version of lit 2 but it appears virtualizer will work with 2.0.0 so this is good.

AndrewJakubowicz
AndrewJakubowicz approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you so much!

justinfagnani
justinfagnani approved these changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@graynorton graynorton merged commit 81806d4 into main Oct 14, 2023
@graynorton graynorton deleted the virtualizer-lit-range branch October 14, 2023 13:46
@steverep
Copy link
Contributor

steverep commented Oct 15, 2023

Can this also be applied to other packages (e.g. labs/context, labs/motion, etc.)? They all have the same issue.

This was referenced Oct 27, 2023
Closed
Merged
@CxsLucyfer CxsLucyfer mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

@augustjk augustjk augustjk approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@graynorton @steverep @justinfagnani @AndrewJakubowicz @augustjk