Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update devDependencies to not reference pre versions of internal packages #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
augustjk merged 4 commits into from
Oct 18, 2023
Merged

Update devDependencies to not reference pre versions of internal packages #4300

augustjk merged 4 commits into from
Oct 18, 2023

Conversation

@augustjk
Copy link
Member

@augustjk augustjk commented Oct 17, 2023

Found while going through package.json files.
Doing an empty changeset as dev dependency updates don't affect end users.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: be852f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +2% (-1.12ms - +0.43ms)
    this-change vs tip-of-tree

render

  • this-change: 76.60ms - 79.92ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +6% (-1.74ms - +1.64ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +3% (-1.24ms - +1.55ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +2% (-1.82ms - +0.92ms)
    this-change vs tip-of-tree

update

  • this-change: 833.65ms - 846.18ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -11% - +2% (-7.31ms - +1.59ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-2.95ms - +2.05ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-7.80ms - +5.63ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 816.67ms - 828.25ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-5.10ms - +8.11ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
76.60ms - 79.92ms-

update

VersionAvg timevs
833.65ms - 846.18ms-

update-reflect

VersionAvg timevs
816.67ms - 828.25ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
27.10ms - 28.99ms-unsure 🔍
-6% - +6%
-1.74ms - +1.64ms		unsure 🔍
-5% - +5%
-1.55ms - +1.27ms
tip-of-tree
tip-of-tree		26.70ms - 29.50msunsure 🔍
-6% - +6%
-1.64ms - +1.74ms		-unsure 🔍
-7% - +6%
-1.83ms - +1.67ms
previous-release
previous-release		27.14ms - 29.23msunsure 🔍
-5% - +6%
-1.27ms - +1.55ms		unsure 🔍
-6% - +7%
-1.67ms - +1.83ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
61.45ms - 64.95ms-unsure 🔍
-11% - +2%
-7.31ms - +1.59ms		unsure 🔍
-7% - +0%
-4.86ms - +0.13ms
tip-of-tree
tip-of-tree		61.97ms - 70.16msunsure 🔍
-3% - +12%
-1.59ms - +7.31ms		-unsure 🔍
-6% - +8%
-3.97ms - +4.96ms
previous-release
previous-release		63.79ms - 67.34msunsure 🔍
-0% - +8%
-0.13ms - +4.86ms		unsure 🔍
-7% - +6%
-4.96ms - +3.97ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
16.35ms - 17.38ms-unsure 🔍
-6% - +2%
-1.12ms - +0.43ms		unsure 🔍
-5% - +4%
-0.78ms - +0.70ms
tip-of-tree
tip-of-tree		16.63ms - 17.79msunsure 🔍
-3% - +7%
-0.43ms - +1.12ms		-unsure 🔍
-3% - +7%
-0.48ms - +1.10ms
previous-release
previous-release		16.37ms - 17.44msunsure 🔍
-4% - +5%
-0.70ms - +0.78ms		unsure 🔍
-6% - +3%
-1.10ms - +0.48ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
50.43ms - 52.67ms-unsure 🔍
-2% - +3%
-1.24ms - +1.55ms		unsure 🔍
-3% - +3%
-1.81ms - +1.41ms
tip-of-tree
tip-of-tree		50.56ms - 52.23msunsure 🔍
-3% - +2%
-1.55ms - +1.24ms		-unsure 🔍
-3% - +2%
-1.78ms - +1.07ms
previous-release
previous-release		50.59ms - 52.91msunsure 🔍
-3% - +4%
-1.41ms - +1.81ms		unsure 🔍
-2% - +3%
-1.07ms - +1.78ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
120.69ms - 124.33ms-unsure 🔍
-2% - +2%
-2.95ms - +2.05ms		unsure 🔍
-3% - +1%
-3.29ms - +1.36ms
tip-of-tree
tip-of-tree		121.24ms - 124.67msunsure 🔍
-2% - +2%
-2.05ms - +2.95ms		-unsure 🔍
-2% - +1%
-2.76ms - +1.73ms
previous-release
previous-release		122.03ms - 124.92msunsure 🔍
-1% - +3%
-1.36ms - +3.29ms		unsure 🔍
-1% - +2%
-1.73ms - +2.76ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
51.54ms - 53.55ms-unsure 🔍
-3% - +2%
-1.82ms - +0.92ms		unsure 🔍
-2% - +3%
-1.24ms - +1.65ms
tip-of-tree
tip-of-tree		52.07ms - 53.92msunsure 🔍
-2% - +3%
-0.92ms - +1.82ms		-unsure 🔍
-1% - +4%
-0.73ms - +2.04ms
previous-release
previous-release		51.31ms - 53.37msunsure 🔍
-3% - +2%
-1.65ms - +1.24ms		unsure 🔍
-4% - +1%
-2.04ms - +0.73ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
877.87ms - 886.56ms-unsure 🔍
-1% - +1%
-7.80ms - +5.63ms		unsure 🔍
-1% - +0%
-9.63ms - +3.43ms
tip-of-tree
tip-of-tree		878.18ms - 888.42msunsure 🔍
-1% - +1%
-5.63ms - +7.80ms		-unsure 🔍
-1% - +1%
-9.08ms - +5.06ms
previous-release
previous-release		880.44ms - 890.18msunsure 🔍
-0% - +1%
-3.43ms - +9.63ms		unsure 🔍
-1% - +1%
-5.06ms - +9.08ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
865.17ms - 875.99ms-unsure 🔍
-1% - +1%
-5.10ms - +8.11ms		unsure 🔍
-1% - +0%
-10.31ms - +3.92ms
tip-of-tree
tip-of-tree		865.28ms - 872.87msunsure 🔍
-1% - +1%
-8.11ms - +5.10ms		-unsure 🔍
-1% - +0%
-10.68ms - +1.29ms
previous-release
previous-release		869.15ms - 878.40msunsure 🔍
-0% - +1%
-3.92ms - +10.31ms		unsure 🔍
-0% - +1%
-1.29ms - +10.68ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

The size of lit-html.js and lit-core.min.js are as expected.

@AndrewJakubowicz
Copy link
Contributor

AndrewJakubowicz commented Oct 17, 2023

If we wanted to be very conservative we could do a small patch changeset entry. In the case that a dev dependency has some impact on the published package.

@augustjk augustjk merged commit 0372614 into main Oct 18, 2023
@augustjk augustjk deleted the cleanup-dev-deps branch October 18, 2023 00:24
@augustjk augustjk mentioned this pull request Oct 18, 2023
Merged
@CxsLucyfer CxsLucyfer mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

@benjamind benjamind Awaiting requested review from benjamind benjamind is a code owner

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@augustjk @AndrewJakubowicz