Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/gen-wrapper-react] Don't include pre version of @lit/react #4301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
augustjk merged 1 commit into from
Oct 17, 2023
Merged

[labs/gen-wrapper-react] Don't include pre version of @lit/react #4301

augustjk merged 1 commit into from
Oct 17, 2023

Conversation

@augustjk
Copy link
Member

@augustjk augustjk commented Oct 17, 2023

Pre version was added before stable release to make self install tests pass. There's no reason to include this in generated output.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d824844

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/gen-wrapper-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +8% (-0.85ms - +1.47ms)
    this-change vs tip-of-tree

render

  • this-change: 103.53ms - 107.39ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +7% (-1.72ms - +2.78ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +2% (-2.88ms - +1.00ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +3% (-1.72ms - +2.15ms)
    this-change vs tip-of-tree

update

  • this-change: 1113.43ms - 1136.17ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +3% (-5.32ms - +2.29ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: slower ❌ 0% - 7% (0.54ms - 9.10ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-12.38ms - +20.59ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 1082.07ms - 1103.91ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +2% (-3.49ms - +27.63ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
103.53ms - 107.39ms-

update

VersionAvg timevs
1113.43ms - 1136.17ms-

update-reflect

VersionAvg timevs
1082.07ms - 1103.91ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
39.22ms - 42.37ms-unsure 🔍
-4% - +7%
-1.72ms - +2.78ms		unsure 🔍
-3% - +7%
-1.14ms - +2.93ms
tip-of-tree
tip-of-tree		38.66ms - 41.87msunsure 🔍
-7% - +4%
-2.78ms - +1.72ms		-unsure 🔍
-4% - +6%
-1.70ms - +2.42ms
previous-release
previous-release		38.61ms - 41.19msunsure 🔍
-7% - +3%
-2.93ms - +1.14ms		unsure 🔍
-6% - +4%
-2.42ms - +1.70ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
78.04ms - 82.68ms-unsure 🔍
-6% - +3%
-5.32ms - +2.29ms		unsure 🔍
-6% - +5%
-4.81ms - +3.99ms
tip-of-tree
tip-of-tree		78.86ms - 84.89msunsure 🔍
-3% - +7%
-2.29ms - +5.32ms		-unsure 🔍
-5% - +7%
-3.69ms - +5.90ms
previous-release
previous-release		77.04ms - 84.50msunsure 🔍
-5% - +6%
-3.99ms - +4.81ms		unsure 🔍
-7% - +4%
-5.90ms - +3.69ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.80ms - 20.57ms-unsure 🔍
-4% - +8%
-0.85ms - +1.47ms		unsure 🔍
-10% - +7%
-1.95ms - +1.35ms
tip-of-tree
tip-of-tree		18.62ms - 20.12msunsure 🔍
-7% - +4%
-1.47ms - +0.85ms		-unsure 🔍
-11% - +5%
-2.19ms - +0.97ms
previous-release
previous-release		18.59ms - 21.38msunsure 🔍
-7% - +10%
-1.35ms - +1.95ms		unsure 🔍
-5% - +11%
-0.97ms - +2.19ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
62.77ms - 65.47ms-unsure 🔍
-4% - +2%
-2.88ms - +1.00ms		unsure 🔍
-3% - +2%
-1.92ms - +1.58ms
tip-of-tree
tip-of-tree		63.66ms - 66.46msunsure 🔍
-2% - +5%
-1.00ms - +2.88ms		-unsure 🔍
-2% - +4%
-1.02ms - +2.56ms
previous-release
previous-release		63.17ms - 65.41msunsure 🔍
-2% - +3%
-1.58ms - +1.92ms		unsure 🔍
-4% - +2%
-2.56ms - +1.02ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
141.96ms - 149.15ms-slower ❌
0% - 7%
0.54ms - 9.10ms		unsure 🔍
-1% - +6%
-0.73ms - +8.28ms
tip-of-tree
tip-of-tree		138.41ms - 143.05msfaster ✔
0% - 6%
0.54ms - 9.10ms		-unsure 🔍
-3% - +2%
-4.62ms - +2.52ms
previous-release
previous-release		139.07ms - 144.49msunsure 🔍
-6% - +0%
-8.28ms - +0.73ms		unsure 🔍
-2% - +3%
-2.52ms - +4.62ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
66.60ms - 69.25ms-unsure 🔍
-3% - +3%
-1.72ms - +2.15ms		unsure 🔍
-3% - +3%
-1.93ms - +2.03ms
tip-of-tree
tip-of-tree		66.30ms - 69.12msunsure 🔍
-3% - +3%
-2.15ms - +1.72ms		-unsure 🔍
-3% - +3%
-2.20ms - +1.87ms
previous-release
previous-release		66.40ms - 69.35msunsure 🔍
-3% - +3%
-2.03ms - +1.93ms		unsure 🔍
-3% - +3%
-1.87ms - +2.20ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1127.47ms - 1151.61ms-unsure 🔍
-1% - +2%
-12.38ms - +20.59ms		unsure 🔍
-1% - +1%
-15.15ms - +16.60ms
tip-of-tree
tip-of-tree		1124.20ms - 1146.67msunsure 🔍
-2% - +1%
-20.59ms - +12.38ms		-unsure 🔍
-2% - +1%
-18.63ms - +11.87ms
previous-release
previous-release		1128.50ms - 1149.13msunsure 🔍
-1% - +1%
-16.60ms - +15.15ms		unsure 🔍
-1% - +2%
-11.87ms - +18.63ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1131.28ms - 1152.67ms-unsure 🔍
-0% - +2%
-3.49ms - +27.63ms		unsure 🔍
-1% - +2%
-12.14ms - +19.98ms
tip-of-tree
tip-of-tree		1118.60ms - 1141.21msunsure 🔍
-2% - +0%
-27.63ms - +3.49ms		-unsure 🔍
-2% - +1%
-24.62ms - +8.32ms
previous-release
previous-release		1126.08ms - 1150.03msunsure 🔍
-2% - +1%
-19.98ms - +12.14ms		unsure 🔍
-1% - +2%
-8.32ms - +24.62ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

The size of lit-html.js and lit-core.min.js are as expected.

@augustjk augustjk force-pushed the gen-wrapper-react-no-pre branch from 613b81a to d824844 Compare October 17, 2023 23:08
@augustjk augustjk enabled auto-merge (squash) October 17, 2023 23:10
@augustjk augustjk merged commit 0d6ca98 into main Oct 17, 2023
@augustjk augustjk deleted the gen-wrapper-react-no-pre branch October 17, 2023 23:35
This was referenced Oct 27, 2023
Closed
Merged
@CxsLucyfer CxsLucyfer mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

@rictic rictic Awaiting requested review from rictic

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@augustjk @AndrewJakubowicz