Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[context] Only depend on @lit/reactive-element #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
augustjk merged 2 commits into from
Oct 26, 2023
Merged

[context] Only depend on @lit/reactive-element #4329

augustjk merged 2 commits into from
Oct 26, 2023

Conversation

@augustjk
Copy link
Member

@augustjk augustjk commented Oct 26, 2023

We had both lit and @lit/reactive-element listed as dependency but really all we need for the implementation is @lit/reactive-element for the types. This would be a good candidate to consider making it a peer dependency as well.

lit is moved to dev dependency as it is used for testing.

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 669be27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@lit/context Patch
@lit-labs/context Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +7% (-0.63ms - +1.14ms)
    this-change vs tip-of-tree

render

  • this-change: 65.77ms - 67.47ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +5% (-1.07ms - +1.47ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.50ms - +1.47ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +2% (-2.27ms - +0.87ms)
    this-change vs tip-of-tree

update

  • this-change: 730.00ms - 737.60ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +2% (-2.75ms - +1.39ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-2.16ms - +1.08ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +1% (-2.24ms - +11.18ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 719.45ms - 726.86ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-4.67ms - +7.27ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
65.77ms - 67.47ms-

update

VersionAvg timevs
730.00ms - 737.60ms-

update-reflect

VersionAvg timevs
719.45ms - 726.86ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
26.84ms - 28.58ms-unsure 🔍
-4% - +5%
-1.07ms - +1.47ms		unsure 🔍
-2% - +8%
-0.51ms - +2.12ms
tip-of-tree
tip-of-tree		26.59ms - 28.44msunsure 🔍
-5% - +4%
-1.47ms - +1.07ms		-unsure 🔍
-3% - +7%
-0.74ms - +1.95ms
previous-release
previous-release		25.92ms - 27.89msunsure 🔍
-8% - +2%
-2.12ms - +0.51ms		unsure 🔍
-7% - +3%
-1.95ms - +0.74ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
55.99ms - 59.40ms-unsure 🔍
-5% - +2%
-2.75ms - +1.39ms		unsure 🔍
-4% - +3%
-2.55ms - +1.70ms
tip-of-tree
tip-of-tree		57.19ms - 59.56msunsure 🔍
-2% - +5%
-1.39ms - +2.75ms		-unsure 🔍
-3% - +3%
-1.48ms - +1.99ms
previous-release
previous-release		56.85ms - 59.39msunsure 🔍
-3% - +4%
-1.70ms - +2.55ms		unsure 🔍
-3% - +3%
-1.99ms - +1.48ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
15.75ms - 17.29ms-unsure 🔍
-4% - +7%
-0.63ms - +1.14ms		unsure 🔍
-5% - +7%
-0.84ms - +1.11ms
tip-of-tree
tip-of-tree		15.83ms - 16.70msunsure 🔍
-7% - +4%
-1.14ms - +0.63ms		-unsure 🔍
-5% - +4%
-0.86ms - +0.62ms
previous-release
previous-release		15.78ms - 16.99msunsure 🔍
-7% - +5%
-1.11ms - +0.84ms		unsure 🔍
-4% - +5%
-0.62ms - +0.86ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
48.52ms - 50.01ms-unsure 🔍
-1% - +3%
-0.50ms - +1.47ms		unsure 🔍
-1% - +3%
-0.70ms - +1.37ms
tip-of-tree
tip-of-tree		48.14ms - 49.43msunsure 🔍
-3% - +1%
-1.47ms - +0.50ms		-unsure 🔍
-2% - +2%
-1.11ms - +0.82ms
previous-release
previous-release		48.21ms - 49.65msunsure 🔍
-3% - +1%
-1.37ms - +0.70ms		unsure 🔍
-2% - +2%
-0.82ms - +1.11ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
102.84ms - 105.36ms-unsure 🔍
-2% - +1%
-2.16ms - +1.08ms		unsure 🔍
-2% - +1%
-1.60ms - +1.42ms
tip-of-tree
tip-of-tree		103.63ms - 105.66msunsure 🔍
-1% - +2%
-1.08ms - +2.16ms		-unsure 🔍
-1% - +2%
-0.86ms - +1.76ms
previous-release
previous-release		103.36ms - 105.03msunsure 🔍
-1% - +2%
-1.42ms - +1.60ms		unsure 🔍
-2% - +1%
-1.76ms - +0.86ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
45.01ms - 46.58ms-unsure 🔍
-5% - +2%
-2.27ms - +0.87ms		unsure 🔍
-5% - +1%
-2.18ms - +0.70ms
tip-of-tree
tip-of-tree		45.14ms - 47.85msunsure 🔍
-2% - +5%
-0.87ms - +2.27ms		-unsure 🔍
-4% - +4%
-1.85ms - +1.78ms
previous-release
previous-release		45.33ms - 47.74msunsure 🔍
-2% - +5%
-0.70ms - +2.18ms		unsure 🔍
-4% - +4%
-1.78ms - +1.85ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
757.29ms - 767.44ms-unsure 🔍
-0% - +1%
-2.24ms - +11.18ms		unsure 🔍
-0% - +2%
-0.07ms - +11.92ms
tip-of-tree
tip-of-tree		753.50ms - 762.28msunsure 🔍
-1% - +0%
-11.18ms - +2.24ms		-unsure 🔍
-1% - +1%
-3.97ms - +6.88ms
previous-release
previous-release		753.25ms - 759.63msunsure 🔍
-2% - +0%
-11.92ms - +0.07ms		unsure 🔍
-1% - +1%
-6.88ms - +3.97ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
750.12ms - 758.69ms-unsure 🔍
-1% - +1%
-4.67ms - +7.27ms		unsure 🔍
-1% - +1%
-5.61ms - +6.70ms
tip-of-tree
tip-of-tree		748.94ms - 757.26msunsure 🔍
-1% - +1%
-7.27ms - +4.67ms		-unsure 🔍
-1% - +1%
-6.82ms - +5.31ms
previous-release
previous-release		749.44ms - 758.27msunsure 🔍
-1% - +1%
-6.70ms - +5.61ms		unsure 🔍
-1% - +1%
-5.31ms - +6.82ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

The size of lit-html.js and lit-core.min.js are as expected.

AndrewJakubowicz
AndrewJakubowicz approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@augustjk augustjk enabled auto-merge (squash) October 26, 2023 23:28
@augustjk augustjk merged commit df1980f into main Oct 26, 2023
@augustjk augustjk deleted the context-dep branch October 26, 2023 23:31
This was referenced Oct 27, 2023
Closed
Merged
@CxsLucyfer CxsLucyfer mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

@rictic rictic Awaiting requested review from rictic

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@augustjk @justinfagnani @AndrewJakubowicz