Get the Analyzer fully running in browsers #4322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 44270f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultsthis-change
render
update
update-reflect
this-change, tip-of-tree, previous-release
render
update
nop-update
this-change, tip-of-tree, previous-release
render
update
this-change, tip-of-tree, previous-release
render
update
update-reflect
|
Contributor
|
The size of lit-html.js and lit-core.min.js are as expected. |
rictic
reviewed
Oct 24, 2023
Collaborator
rictic
left a comment
There was a problem hiding this comment.
Do we want to remove NodeJS typings from the analyzer package? Or only make them available in specific files?
That wouldn't help with typescript.sys but hopefully we won't run into that again
justinfagnani
commented
Oct 24, 2023
| "noImplicitOverride": true, | ||
| "skipLibCheck": true, | ||
| "types": ["node"] | ||
| "types": ["node", "mocha"] |
Collaborator
Author
There was a problem hiding this comment.
I think ultimately the safest thing here would be to have separate tsconfigs:
- The main library code, no node typings
- The node test code and package-analyzer function, with node typings
- Maybe a third with browser typings if they were needed in browser tests.
Not having Node typings would have caught the place where we imported path.
augustjk
reviewed
Oct 26, 2023
augustjk
reviewed
Oct 27, 2023
Co-authored-by: Augustine Kim <[email protected]>
augustjk
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few cases where the analyzer was relying on Node-specific behavior, so that the analyzer can now run cleanly in browsers.
To test this the PR creates separate test:server and test:browser scripts where the browser test uses a Rollup-built JS module for typescript and a copy of the server tests' InMemoryAnalyzer itself with some fixes for running outside node.
The InMemoryAnalyzer code is a bit messy, but it's test code. I think we should probably offer a supported InMemoryAnalyzer at some point, derived from out test versions.
The test changes are in the first two commits, the fixes in the third.