Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[context, react] Update dependency on graduated package to ^1.0.0 #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
augustjk merged 3 commits into from
Oct 27, 2023
Merged

[context, react] Update dependency on graduated package to ^1.0.0 #4340

augustjk merged 3 commits into from
Oct 27, 2023

Conversation

@augustjk
Copy link
Member

@augustjk augustjk commented Oct 27, 2023

Our original intention was to have the labs packages automatically track the first major version of the graduated package so it'll automatically receive updates. This got erroneously pinned to the exact version for initial release as we were moving/exiting pre-release mode.

I also took this opportunity to add ^ dependencies in examples/ projects so they don't get a version bump every release.

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

🦋 Changeset detected

Latest commit: 96f7f27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@lit-labs/context Patch
@lit-labs/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -10% - +18% (-1.81ms - +3.38ms)
    this-change vs tip-of-tree

render

  • this-change: 68.73ms - 72.55ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -7% - +2% (-2.09ms - +0.54ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +1% (-1.61ms - +0.78ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +2% (-1.54ms - +1.08ms)
    this-change vs tip-of-tree

update

  • this-change: 803.97ms - 816.23ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -11% - +7% (-7.93ms - +5.07ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-2.80ms - +2.02ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-11.55ms - +4.71ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 782.57ms - 793.28ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-9.11ms - +6.18ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
68.73ms - 72.55ms-

update

VersionAvg timevs
803.97ms - 816.23ms-

update-reflect

VersionAvg timevs
782.57ms - 793.28ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
26.94ms - 28.73ms-unsure 🔍
-7% - +2%
-2.09ms - +0.54ms		unsure 🔍
-7% - +2%
-1.95ms - +0.54ms
tip-of-tree
tip-of-tree		27.64ms - 29.58msunsure 🔍
-2% - +8%
-0.54ms - +2.09ms		-unsure 🔍
-4% - +5%
-1.23ms - +1.37ms
previous-release
previous-release		27.68ms - 29.41msunsure 🔍
-2% - +7%
-0.54ms - +1.95ms		unsure 🔍
-5% - +4%
-1.37ms - +1.23ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
65.86ms - 75.04ms-unsure 🔍
-11% - +7%
-7.93ms - +5.07ms		unsure 🔍
-9% - +9%
-6.57ms - +6.34ms
tip-of-tree
tip-of-tree		67.28ms - 76.49msunsure 🔍
-7% - +11%
-5.07ms - +7.93ms		-unsure 🔍
-7% - +11%
-5.15ms - +7.78ms
previous-release
previous-release		66.03ms - 75.10msunsure 🔍
-9% - +9%
-6.34ms - +6.57ms		unsure 🔍
-11% - +7%
-7.78ms - +5.15ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
17.47ms - 21.69ms-unsure 🔍
-10% - +18%
-1.81ms - +3.38ms		unsure 🔍
-13% - +15%
-2.54ms - +2.92ms
tip-of-tree
tip-of-tree		17.28ms - 20.30msunsure 🔍
-17% - +9%
-3.38ms - +1.81ms		-unsure 🔍
-15% - +9%
-2.90ms - +1.70ms
previous-release
previous-release		17.67ms - 21.12msunsure 🔍
-15% - +13%
-2.92ms - +2.54ms		unsure 🔍
-9% - +16%
-1.70ms - +2.90ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
51.22ms - 52.63ms-unsure 🔍
-3% - +1%
-1.61ms - +0.78ms		unsure 🔍
-2% - +2%
-0.98ms - +1.02ms
tip-of-tree
tip-of-tree		51.38ms - 53.30msunsure 🔍
-2% - +3%
-0.78ms - +1.61ms		-unsure 🔍
-1% - +3%
-0.76ms - +1.63ms
previous-release
previous-release		51.19ms - 52.62msunsure 🔍
-2% - +2%
-1.02ms - +0.98ms		unsure 🔍
-3% - +1%
-1.63ms - +0.76ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
122.48ms - 125.56ms-unsure 🔍
-2% - +2%
-2.80ms - +2.02ms		unsure 🔍
-1% - +2%
-1.79ms - +2.12ms
tip-of-tree
tip-of-tree		122.56ms - 126.26msunsure 🔍
-2% - +2%
-2.02ms - +2.80ms		-unsure 🔍
-1% - +2%
-1.65ms - +2.77ms
previous-release
previous-release		122.65ms - 125.06msunsure 🔍
-2% - +1%
-2.12ms - +1.79ms		unsure 🔍
-2% - +1%
-2.77ms - +1.65ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
48.23ms - 50.04ms-unsure 🔍
-3% - +2%
-1.54ms - +1.08ms		unsure 🔍
-3% - +2%
-1.33ms - +0.93ms
tip-of-tree
tip-of-tree		48.42ms - 50.31msunsure 🔍
-2% - +3%
-1.08ms - +1.54ms		-unsure 🔍
-2% - +2%
-1.14ms - +1.19ms
previous-release
previous-release		48.65ms - 50.02msunsure 🔍
-2% - +3%
-0.93ms - +1.33ms		unsure 🔍
-2% - +2%
-1.19ms - +1.14ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
845.39ms - 855.99ms-unsure 🔍
-1% - +1%
-11.55ms - +4.71ms		unsure 🔍
-1% - +1%
-5.22ms - +8.76ms
tip-of-tree
tip-of-tree		847.94ms - 860.27msunsure 🔍
-1% - +1%
-4.71ms - +11.55ms		-unsure 🔍
-0% - +2%
-2.48ms - +12.85ms
previous-release
previous-release		844.36ms - 853.48msunsure 🔍
-1% - +1%
-8.76ms - +5.22ms		unsure 🔍
-2% - +0%
-12.85ms - +2.48ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
826.42ms - 836.88ms-unsure 🔍
-1% - +1%
-9.11ms - +6.18ms		unsure 🔍
-1% - +1%
-10.38ms - +6.04ms
tip-of-tree
tip-of-tree		827.54ms - 838.70msunsure 🔍
-1% - +1%
-6.18ms - +9.11ms		-unsure 🔍
-1% - +1%
-9.14ms - +7.73ms
previous-release
previous-release		827.49ms - 840.15msunsure 🔍
-1% - +1%
-6.04ms - +10.38ms		unsure 🔍
-1% - +1%
-7.73ms - +9.14ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

The size of lit-html.js and lit-core.min.js are as expected.

AndrewJakubowicz
AndrewJakubowicz approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome dependency gardening and improving!

@augustjk augustjk merged commit 18305b4 into main Oct 27, 2023
@augustjk augustjk deleted the fix-dep-pins branch October 27, 2023 23:44
@lit-robot lit-robot mentioned this pull request Oct 27, 2023
Merged
@CxsLucyfer CxsLucyfer mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

@rictic rictic Awaiting requested review from rictic

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

@benjamind benjamind Awaiting requested review from benjamind benjamind is a code owner

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@augustjk @AndrewJakubowicz