[infra] Add browser export conditions to package.json #4485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 07e1f9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultsthis-change
render
update
update-reflect
this-change, tip-of-tree, previous-release
render
update
nop-update
this-change, tip-of-tree, previous-release
render
update
this-change, tip-of-tree, previous-release
render
update
update-reflect
|
Contributor
|
The size of lit-html.js and lit-core.min.js are as expected. |
rictic
requested changes
Jan 10, 2024
rictic
approved these changes
Jan 10, 2024
Collaborator
|
This is great work! |
augustjk
reviewed
Jan 10, 2024
augustjk
reviewed
Jan 10, 2024
Co-authored-by: Peter Burns <[email protected]>
Co-authored-by: Augustine Kim <[email protected]>
augustjk
approved these changes
Jan 10, 2024
augustjk
approved these changes
Jan 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4446
Context
This is a compromise so that testing in Vitest works. As part of this work I explored simplifying the package.json exports using subpath patterns. Unfortunately the ecosystem doesn't support those very well, so it's been punted.
Marked this a patch change, as it's a minor "bug fix" workaround for testing in Jest and Vitest.
This script has two modes:
test: won't write any files, but instead checks that no files need to be fixed. Is run as part of our CI.fix: writes to package.json files.Test plan
The prior browser/node entrypoints are tested via our CI.
The script itself is lightly tested via node assertions. The script won't run if an assertion fails.
Risk
This changes the entrypoints in some of our package.json configurations, so it is a slightly risky change. We've manually verified that adding the browser export above node works correctly. Similarly if our test suite passes, then this should not be a regression as we use the exports in our tests.