[labs/motion] chore: improve adjustments of ancestor condition check #4496

zh-lx · 2024-01-16T02:51:59Z

ancestorProps is an array there, so it's always not equal undefiend. There should validate its length

changeset-bot · 2024-01-16T02:52:02Z

🦋 Changeset detected

Latest commit: d24693e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/motion	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-01-16T02:52:15Z

📊 Tachometer Benchmark Results

Summary

nop-update

this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +9% (-0.28ms - +1.06ms)
^{this-change vs tip-of-tree}

render

this-change: 48.46ms - 50.45ms
this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +7% (-0.05ms - +1.32ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +1% (-1.25ms - +0.41ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.76ms - +0.57ms)
^{this-change vs tip-of-tree}

update

this-change: 508.67ms - 518.38ms
this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +10% (-1.39ms - +4.45ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +3% (-3.00ms - +1.89ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-10.33ms - +9.78ms)
^{this-change vs tip-of-tree}

update-reflect

this-change: 513.68ms - 522.69ms
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-10.93ms - +9.18ms)
^{this-change vs tip-of-tree}

Results

this-change

Browser: chrome-headless 120.0.6099.224
Sample size: 50
Built by: Benchmarks #6062
Commit: d24693e

render

Version	Avg time	vs
	48.46ms - 50.45ms	-

update

Version	Avg time	vs
	508.67ms - 518.38ms	-

update-reflect

Version	Avg time	vs
	513.68ms - 522.69ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 120.0.6099.224
Sample size: 30
Built by: Benchmarks #6062
Commit: d24693e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	19.15ms - 20.22ms	-	unsure 🔍 -0% - +7% -0.05ms - +1.32ms	unsure 🔍 -0% - +7% -0.01ms - +1.25ms
tip-of-tree tip-of-tree	18.63ms - 19.48ms	unsure 🔍 -7% - +0% -1.32ms - +0.05ms	-	unsure 🔍 -3% - +3% -0.56ms - +0.53ms
previous-release previous-release	18.73ms - 19.40ms	unsure 🔍 -6% - -0% -1.25ms - +0.01ms	unsure 🔍 -3% - +3% -0.53ms - +0.56ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	42.86ms - 47.00ms	-	unsure 🔍 -3% - +10% -1.39ms - +4.45ms	unsure 🔍 -4% - +9% -1.64ms - +3.90ms
tip-of-tree tip-of-tree	41.34ms - 45.46ms	unsure 🔍 -10% - +3% -4.45ms - +1.39ms	-	unsure 🔍 -7% - +5% -3.16ms - +2.36ms
previous-release previous-release	41.97ms - 45.64ms	unsure 🔍 -9% - +4% -3.90ms - +1.64ms	unsure 🔍 -5% - +7% -2.36ms - +3.16ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.67ms - 12.64ms	-	unsure 🔍 -2% - +9% -0.28ms - +1.06ms	unsure 🔍 -5% - +6% -0.62ms - +0.75ms
tip-of-tree tip-of-tree	11.30ms - 12.24ms	unsure 🔍 -9% - +2% -1.06ms - +0.28ms	-	unsure 🔍 -8% - +3% -1.00ms - +0.35ms
previous-release previous-release	11.60ms - 12.58ms	unsure 🔍 -6% - +5% -0.75ms - +0.62ms	unsure 🔍 -3% - +9% -0.35ms - +1.00ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 120.0.6099.224
Sample size: 50
Built by: Benchmarks #6062
Commit: d24693e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	33.67ms - 34.83ms	-	unsure 🔍 -4% - +1% -1.25ms - +0.41ms	unsure 🔍 -1% - +3% -0.44ms - +1.07ms
tip-of-tree tip-of-tree	34.07ms - 35.27ms	unsure 🔍 -1% - +4% -0.41ms - +1.25ms	-	unsure 🔍 -0% - +4% -0.04ms - +1.51ms
previous-release previous-release	33.45ms - 34.42ms	unsure 🔍 -3% - +1% -1.07ms - +0.44ms	unsure 🔍 -4% - +0% -1.51ms - +0.04ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	71.60ms - 74.74ms	-	unsure 🔍 -4% - +3% -3.00ms - +1.89ms	unsure 🔍 -3% - +3% -2.12ms - +2.26ms
tip-of-tree tip-of-tree	71.85ms - 75.61ms	unsure 🔍 -3% - +4% -1.89ms - +3.00ms	-	unsure 🔍 -2% - +4% -1.79ms - +3.05ms
previous-release previous-release	71.57ms - 74.63ms	unsure 🔍 -3% - +3% -2.26ms - +2.12ms	unsure 🔍 -4% - +2% -3.05ms - +1.79ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 120.0.6099.224
Sample size: 50
Built by: Benchmarks #6062
Commit: d24693e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	33.50ms - 34.38ms	-	unsure 🔍 -2% - +2% -0.76ms - +0.57ms	unsure 🔍 -3% - +1% -0.94ms - +0.49ms
tip-of-tree tip-of-tree	33.54ms - 34.53ms	unsure 🔍 -2% - +2% -0.57ms - +0.76ms	-	unsure 🔍 -3% - +2% -0.89ms - +0.62ms
previous-release previous-release	33.60ms - 34.74ms	unsure 🔍 -1% - +3% -0.49ms - +0.94ms	unsure 🔍 -2% - +3% -0.62ms - +0.89ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	519.71ms - 533.58ms	-	unsure 🔍 -2% - +2% -10.33ms - +9.78ms	unsure 🔍 -2% - +2% -10.76ms - +9.98ms
tip-of-tree tip-of-tree	519.64ms - 534.20ms	unsure 🔍 -2% - +2% -9.78ms - +10.33ms	-	unsure 🔍 -2% - +2% -10.72ms - +10.49ms
previous-release previous-release	519.33ms - 534.75ms	unsure 🔍 -2% - +2% -9.98ms - +10.76ms	unsure 🔍 -2% - +2% -10.49ms - +10.72ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	527.39ms - 540.44ms	-	unsure 🔍 -2% - +2% -10.93ms - +9.18ms	unsure 🔍 -2% - +2% -10.09ms - +9.35ms
tip-of-tree tip-of-tree	527.13ms - 542.45ms	unsure 🔍 -2% - +2% -9.18ms - +10.93ms	-	unsure 🔍 -2% - +2% -10.01ms - +11.02ms
previous-release previous-release	527.08ms - 541.49ms	unsure 🔍 -2% - +2% -9.35ms - +10.09ms	unsure 🔍 -2% - +2% -11.02ms - +10.01ms	-

_{tachometer-reporter-action v2 for Benchmarks}

justinfagnani · 2024-01-16T02:57:00Z

Please see https://github.com/lit/lit/blob/main/CONTRIBUTING.md#pull-requests

We really need more of a description of what this change is for. What package? Is there an associated issue? We also need a test.

zh-lx · 2024-01-16T03:24:02Z

Please see https://github.com/lit/lit/blob/main/CONTRIBUTING.md#pull-requests

We really need more of a description of what this change is for. What package? Is there an associated issue? We also need a test.

This is just a code optimization, it has not caused any actual issues, and there is no need to add additional test cases. You only need to look at the code changes in these few lines to understand the meaning of this modification: diff

augustjk

Thanks for the PR. As Justin mentioned above, we do prefer there be a related issue or more description but this is indeed a small change.

It looks like there's no change in behavior since everything inside the condition wouldn't really have any effect even with an empty array, but the original code would never have skipped over that block as it seems to have intended so this change makes sense to me. I've left a suggestion with regards to our code style for condition checks.

packages/labs/motion/src/animate.ts

github-actions · 2024-01-23T00:03:38Z

The size of lit-html.js and lit-core.min.js are as expected.

augustjk

Thank you! I added a changeset describing the change.

AndrewJakubowicz

Awesome!

chore: imporve adjustments of ancestor

f036c00

zh-lx requested a review from kevinpschaaf as a code owner January 16, 2024 02:52

augustjk reviewed Jan 17, 2024

View reviewed changes

packages/labs/motion/src/animate.ts Outdated Show resolved Hide resolved

augustjk changed the title ~~chore: imporve adjustments of ancestor~~ [labs/motion] chore: improve adjustments of ancestor condition check Jan 17, 2024

chore: optimize ancestorProps judge

b7be178

Add changeset

d24693e

augustjk approved these changes Jan 26, 2024

View reviewed changes

AndrewJakubowicz approved these changes Jan 26, 2024

View reviewed changes

augustjk merged commit 78d2321 into lit:main Jan 26, 2024

lit-robot mentioned this pull request Jan 31, 2024

Version Packages #4532

Merged

[labs/motion] chore: improve adjustments of ancestor condition check #4496

[labs/motion] chore: improve adjustments of ancestor condition check #4496

Uh oh!

Conversation

zh-lx commented Jan 16, 2024

Uh oh!

changeset-bot bot commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

Uh oh!

justinfagnani commented Jan 16, 2024

Uh oh!

zh-lx commented Jan 16, 2024

Uh oh!

augustjk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 23, 2024

Uh oh!

augustjk left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewJakubowicz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot bot commented Jan 16, 2024 •

edited

Loading

github-actions bot commented Jan 16, 2024 •

edited

Loading