Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[infra] revert changeset config.json #4536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndrewJakubowicz merged 1 commit into from
Feb 1, 2024
Merged

[infra] revert changeset config.json #4536

AndrewJakubowicz merged 1 commit into from
Feb 1, 2024

Conversation

@AndrewJakubowicz
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz commented Feb 1, 2024

Context

Reverts the changeset config change introduced for the SSR bug fix in #4515

Further work would be to see if we can add a constraint such as:

  • For the 4 core packages, they should all be tied together.

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2024

⚠️ No Changeset found

Latest commit: 8968496

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +7% (-0.36ms - +0.74ms)
    this-change vs tip-of-tree

render

  • this-change: 46.45ms - 48.94ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +2% (-0.68ms - +0.47ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.39ms - +1.10ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.51ms - +0.74ms)
    this-change vs tip-of-tree

update

  • this-change: 529.56ms - 539.00ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -9% - +3% (-3.64ms - +1.14ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +3% (-1.89ms - +2.10ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +0% (-9.13ms - +1.12ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 528.01ms - 537.76ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +0% (-4.32ms - +1.88ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
46.45ms - 48.94ms-

update

VersionAvg timevs
529.56ms - 539.00ms-

update-reflect

VersionAvg timevs
528.01ms - 537.76ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.23ms - 19.01ms-unsure 🔍
-4% - +2%
-0.68ms - +0.47ms		unsure 🔍
-3% - +3%
-0.59ms - +0.60ms
tip-of-tree
tip-of-tree		18.30ms - 19.15msunsure 🔍
-3% - +4%
-0.47ms - +0.68ms		-unsure 🔍
-3% - +4%
-0.52ms - +0.74ms
previous-release
previous-release		18.16ms - 19.07msunsure 🔍
-3% - +3%
-0.60ms - +0.59ms		unsure 🔍
-4% - +3%
-0.74ms - +0.52ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
39.38ms - 42.44ms-unsure 🔍
-9% - +3%
-3.64ms - +1.14ms		unsure 🔍
-3% - +8%
-1.33ms - +3.06ms
tip-of-tree
tip-of-tree		40.33ms - 44.00msunsure 🔍
-3% - +9%
-1.14ms - +3.64ms		-unsure 🔍
-1% - +11%
-0.30ms - +4.54ms
previous-release
previous-release		38.47ms - 41.62msunsure 🔍
-7% - +3%
-3.06ms - +1.33ms		unsure 🔍
-11% - +1%
-4.54ms - +0.30ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
10.88ms - 11.69ms-unsure 🔍
-3% - +7%
-0.36ms - +0.74ms		slower ❌
0% - 11%
0.07ms - 1.13ms
tip-of-tree
tip-of-tree		10.72ms - 11.47msunsure 🔍
-7% - +3%
-0.74ms - +0.36ms		-unsure 🔍
-1% - +9%
-0.11ms - +0.92ms
previous-release
previous-release		10.34ms - 11.04msfaster ✔
1% - 10%
0.07ms - 1.13ms		unsure 🔍
-8% - +1%
-0.92ms - +0.11ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
34.06ms - 35.07ms-unsure 🔍
-1% - +3%
-0.39ms - +1.10ms		unsure 🔍
-2% - +3%
-0.67ms - +1.03ms
tip-of-tree
tip-of-tree		33.67ms - 34.76msunsure 🔍
-3% - +1%
-1.10ms - +0.39ms		-unsure 🔍
-3% - +2%
-1.05ms - +0.70ms
previous-release
previous-release		33.70ms - 35.07msunsure 🔍
-3% - +2%
-1.03ms - +0.67ms		unsure 🔍
-2% - +3%
-0.70ms - +1.05ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
75.91ms - 78.74ms-unsure 🔍
-2% - +3%
-1.89ms - +2.10ms		unsure 🔍
-1% - +3%
-1.06ms - +2.62ms
tip-of-tree
tip-of-tree		75.81ms - 78.63msunsure 🔍
-3% - +2%
-2.10ms - +1.89ms		-unsure 🔍
-2% - +3%
-1.16ms - +2.51ms
previous-release
previous-release		75.37ms - 77.72msunsure 🔍
-3% - +1%
-2.62ms - +1.06ms		unsure 🔍
-3% - +1%
-2.51ms - +1.16ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
32.42ms - 33.37ms-unsure 🔍
-2% - +2%
-0.51ms - +0.74ms		unsure 🔍
-1% - +3%
-0.19ms - +1.05ms
tip-of-tree
tip-of-tree		32.37ms - 33.18msunsure 🔍
-2% - +2%
-0.74ms - +0.51ms		-unsure 🔍
-1% - +3%
-0.26ms - +0.88ms
previous-release
previous-release		32.07ms - 32.87msunsure 🔍
-3% - +1%
-1.05ms - +0.19ms		unsure 🔍
-3% - +1%
-0.88ms - +0.26ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
543.19ms - 548.03ms-unsure 🔍
-2% - +0%
-9.13ms - +1.12ms		unsure 🔍
-1% - +1%
-3.23ms - +3.65ms
tip-of-tree
tip-of-tree		545.09ms - 554.13msunsure 🔍
-0% - +2%
-1.12ms - +9.13ms		-unsure 🔍
-0% - +2%
-0.93ms - +9.35ms
previous-release
previous-release		542.95ms - 547.85msunsure 🔍
-1% - +1%
-3.65ms - +3.23ms		unsure 🔍
-2% - +0%
-9.35ms - +0.93ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
548.04ms - 552.00ms-unsure 🔍
-1% - +0%
-4.32ms - +1.88ms		unsure 🔍
-0% - +1%
-1.88ms - +3.57ms
tip-of-tree
tip-of-tree		548.86ms - 553.62msunsure 🔍
-0% - +1%
-1.88ms - +4.32ms		-unsure 🔍
-0% - +1%
-0.96ms - +5.10ms
previous-release
previous-release		547.30ms - 551.05msunsure 🔍
-1% - +0%
-3.57ms - +1.88ms		unsure 🔍
-1% - +0%
-5.10ms - +0.96ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

The size of lit-html.js and lit-core.min.js are as expected.

augustjk
augustjk approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

.changeset/config.json
"$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
"changelog": "./changelog-lit.cjs",
"commit": false,
"linked": [],
Copy link
Member

@augustjk augustjk Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this linked option might be what we want for the core packages. i'll look into it more.

@AndrewJakubowicz AndrewJakubowicz merged commit 2330eec into main Feb 1, 2024
@AndrewJakubowicz AndrewJakubowicz deleted the revert-changeset branch February 1, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augustjk augustjk augustjk approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewJakubowicz @augustjk