[chore] Update typescript to 5.3.3 #4531

augustjk · 2024-01-31T00:22:27Z

Seeing if we can update typescript with a smaller blast radius than #4520

changeset-bot · 2024-01-31T00:22:31Z

🦋 Changeset detected

Latest commit: e758f33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@lit/ts-transformers	Patch
@lit/localize-tools	Patch
@lit-labs/analyzer	Patch
@lit-labs/compiler	Patch
@lit-labs/cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-01-31T00:22:43Z

📊 Tachometer Benchmark Results

Summary

nop-update

this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +5% (-0.67ms - +0.55ms)
^{this-change vs tip-of-tree}

render

this-change: 49.80ms - 52.37ms
this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +8% (-0.58ms - +1.56ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +2% (-1.14ms - +0.83ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-0.84ms - +0.52ms)
^{this-change vs tip-of-tree}

update

this-change: 539.34ms - 551.23ms
this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +7% (-3.32ms - +3.02ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +4% (-1.86ms - +3.18ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-4.77ms - +7.52ms)
^{this-change vs tip-of-tree}

update-reflect

this-change: 542.87ms - 556.39ms
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-5.06ms - +6.65ms)
^{this-change vs tip-of-tree}

Results

this-change

Browser: chrome-headless 120.0.6099.224
Sample size: 50
Built by: Benchmarks #6074
Commit: e758f33

render

Version	Avg time	vs
	49.80ms - 52.37ms	-

update

Version	Avg time	vs
	539.34ms - 551.23ms	-

update-reflect

Version	Avg time	vs
	542.87ms - 556.39ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 120.0.6099.224
Sample size: 30
Built by: Benchmarks #6074
Commit: e758f33

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	18.41ms - 20.36ms	-	unsure 🔍 -3% - +8% -0.58ms - +1.56ms	unsure 🔍 -7% - +4% -1.36ms - +0.84ms
tip-of-tree tip-of-tree	18.45ms - 19.33ms	unsure 🔍 -8% - +3% -1.56ms - +0.58ms	-	faster ✔ 0% - 7% 0.08ms - 1.43ms
previous-release previous-release	19.13ms - 20.16ms	unsure 🔍 -4% - +7% -0.84ms - +1.36ms	slower ❌ 0% - 8% 0.08ms - 1.43ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	40.34ms - 44.80ms	-	unsure 🔍 -8% - +7% -3.32ms - +3.02ms	unsure 🔍 -8% - +5% -3.60ms - +2.25ms
tip-of-tree tip-of-tree	40.47ms - 44.97ms	unsure 🔍 -7% - +8% -3.02ms - +3.32ms	-	unsure 🔍 -8% - +6% -3.46ms - +2.42ms
previous-release previous-release	41.35ms - 45.14ms	unsure 🔍 -5% - +9% -2.25ms - +3.60ms	unsure 🔍 -6% - +8% -2.42ms - +3.46ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.15ms - 12.19ms	-	unsure 🔍 -6% - +5% -0.67ms - +0.55ms	unsure 🔍 -5% - +6% -0.58ms - +0.68ms
tip-of-tree tip-of-tree	11.40ms - 12.05ms	unsure 🔍 -5% - +6% -0.55ms - +0.67ms	-	unsure 🔍 -3% - +5% -0.38ms - +0.60ms
previous-release previous-release	11.25ms - 11.98ms	unsure 🔍 -6% - +5% -0.68ms - +0.58ms	unsure 🔍 -5% - +3% -0.60ms - +0.38ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 120.0.6099.224
Sample size: 50
Built by: Benchmarks #6074
Commit: e758f33

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	34.43ms - 35.62ms	-	unsure 🔍 -3% - +2% -1.14ms - +0.83ms	unsure 🔍 -3% - +2% -1.05ms - +0.77ms
tip-of-tree tip-of-tree	34.40ms - 35.96ms	unsure 🔍 -2% - +3% -0.83ms - +1.14ms	-	unsure 🔍 -3% - +3% -1.03ms - +1.06ms
previous-release previous-release	34.47ms - 35.86ms	unsure 🔍 -2% - +3% -0.77ms - +1.05ms	unsure 🔍 -3% - +3% -1.06ms - +1.03ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	72.96ms - 76.74ms	-	unsure 🔍 -3% - +4% -1.86ms - +3.18ms	unsure 🔍 -5% - +2% -3.63ms - +1.70ms
tip-of-tree tip-of-tree	72.53ms - 75.86ms	unsure 🔍 -4% - +2% -3.18ms - +1.86ms	-	unsure 🔍 -5% - +1% -4.13ms - +0.90ms
previous-release previous-release	73.93ms - 77.69ms	unsure 🔍 -2% - +5% -1.70ms - +3.63ms	unsure 🔍 -1% - +6% -0.90ms - +4.13ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 120.0.6099.224
Sample size: 50
Built by: Benchmarks #6074
Commit: e758f33

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	34.55ms - 35.43ms	-	unsure 🔍 -2% - +1% -0.84ms - +0.52ms	unsure 🔍 -2% - +3% -0.76ms - +0.91ms
tip-of-tree tip-of-tree	34.63ms - 35.67ms	unsure 🔍 -1% - +2% -0.52ms - +0.84ms	-	unsure 🔍 -2% - +3% -0.64ms - +1.12ms
previous-release previous-release	34.20ms - 35.62ms	unsure 🔍 -3% - +2% -0.91ms - +0.76ms	unsure 🔍 -3% - +2% -1.12ms - +0.64ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	556.53ms - 566.12ms	-	unsure 🔍 -1% - +1% -4.77ms - +7.52ms	unsure 🔍 -0% - +2% -1.04ms - +11.45ms
tip-of-tree tip-of-tree	556.11ms - 563.80ms	unsure 🔍 -1% - +1% -7.52ms - +4.77ms	-	unsure 🔍 -0% - +2% -1.72ms - +9.38ms
previous-release previous-release	552.12ms - 560.12ms	unsure 🔍 -2% - +0% -11.45ms - +1.04ms	unsure 🔍 -2% - +0% -9.38ms - +1.72ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	561.40ms - 569.83ms	-	unsure 🔍 -1% - +1% -5.06ms - +6.65ms	unsure 🔍 -1% - +2% -3.40ms - +8.73ms
tip-of-tree tip-of-tree	560.76ms - 568.89ms	unsure 🔍 -1% - +1% -6.65ms - +5.06ms	-	unsure 🔍 -1% - +1% -4.09ms - +7.84ms
previous-release previous-release	558.59ms - 567.31ms	unsure 🔍 -2% - +1% -8.73ms - +3.40ms	unsure 🔍 -1% - +1% -7.84ms - +4.09ms	-

_{tachometer-reporter-action v2 for Benchmarks}

github-actions · 2024-01-31T00:24:24Z

The size of lit-html.js and lit-core.min.js are as expected.

augustjk · 2024-01-31T00:49:50Z

Closing in favor of #4520

augustjk added 3 commits January 30, 2024 15:50

Update typescript to ~5.3.3

4c8fe8f

Update element starter ts version

9b19339

Add changeset

e758f33

augustjk requested a review from justinfagnani January 31, 2024 00:22

augustjk requested a review from kevinpschaaf as a code owner January 31, 2024 00:22

augustjk closed this Jan 31, 2024

[chore] Update typescript to 5.3.3 #4531

[chore] Update typescript to 5.3.3 #4531

Uh oh!

Conversation

augustjk commented Jan 31, 2024

Uh oh!

changeset-bot bot commented Jan 31, 2024

🦋 Changeset detected

Uh oh!

github-actions bot commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

Uh oh!

github-actions bot commented Jan 31, 2024

Uh oh!

augustjk commented Jan 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions bot commented Jan 31, 2024 •

edited

Loading