[lit/react] Fix event binding erroneously being set on custom element instance #4572

augustjk · 2024-03-07T22:26:20Z

We now correctly early return when an event prop binding contains the same value across re-renders, instead of moving on to setting it on the underlying element instance.

changeset-bot · 2024-03-07T22:26:23Z

🦋 Changeset detected

Latest commit: eee2730

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@lit/react	Patch
@lit-internal/test-elements-react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-03-07T22:26:33Z

📊 Tachometer Benchmark Results

Summary

nop-update

this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +7% (-0.26ms - +0.76ms)
^{this-change vs tip-of-tree}

render

this-change: 47.37ms - 49.50ms
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +6% (-0.30ms - +1.19ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.50ms - +1.08ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: faster ✔ 0% - 3% (0.14ms - 1.15ms)
^{this-change vs tip-of-tree}

update

this-change: 527.59ms - 540.73ms
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +13% (-0.21ms - +5.38ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-1.46ms - +0.96ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-4.99ms - +7.48ms)
^{this-change vs tip-of-tree}

update-reflect

this-change: 533.86ms - 549.76ms
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-4.44ms - +5.66ms)
^{this-change vs tip-of-tree}

Results

this-change

Browser: chrome-headless 122.0.6261.94
Sample size: 50
Built by: Benchmarks #6138
Commit: eee2730

render

Version	Avg time	vs
	47.37ms - 49.50ms	-

update

Version	Avg time	vs
	527.59ms - 540.73ms	-

update-reflect

Version	Avg time	vs
	533.86ms - 549.76ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 122.0.6261.94
Sample size: 30
Built by: Benchmarks #6138
Commit: eee2730

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	18.65ms - 19.59ms	-	unsure 🔍 -2% - +6% -0.30ms - +1.19ms	unsure 🔍 -5% - +2% -0.90ms - +0.45ms
tip-of-tree tip-of-tree	18.10ms - 19.25ms	unsure 🔍 -6% - +2% -1.19ms - +0.30ms	-	unsure 🔍 -7% - +0% -1.42ms - +0.08ms
previous-release previous-release	18.86ms - 19.83ms	unsure 🔍 -2% - +5% -0.45ms - +0.90ms	unsure 🔍 -1% - +8% -0.08ms - +1.42ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	41.58ms - 46.04ms	-	unsure 🔍 -1% - +13% -0.21ms - +5.38ms	unsure 🔍 -4% - +10% -1.68ms - +4.33ms
tip-of-tree tip-of-tree	39.53ms - 42.91ms	unsure 🔍 -12% - +0% -5.38ms - +0.21ms	-	unsure 🔍 -9% - +3% -3.89ms - +1.37ms
previous-release previous-release	40.47ms - 44.50ms	unsure 🔍 -10% - +4% -4.33ms - +1.68ms	unsure 🔍 -3% - +10% -1.37ms - +3.89ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.09ms - 11.85ms	-	unsure 🔍 -2% - +7% -0.26ms - +0.76ms	unsure 🔍 -4% - +6% -0.49ms - +0.65ms
tip-of-tree tip-of-tree	10.88ms - 11.56ms	unsure 🔍 -7% - +2% -0.76ms - +0.26ms	-	unsure 🔍 -6% - +3% -0.71ms - +0.37ms
previous-release previous-release	10.97ms - 11.81ms	unsure 🔍 -6% - +4% -0.65ms - +0.49ms	unsure 🔍 -3% - +6% -0.37ms - +0.71ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 122.0.6261.94
Sample size: 50
Built by: Benchmarks #6138
Commit: eee2730

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	34.16ms - 35.39ms	-	unsure 🔍 -1% - +3% -0.50ms - +1.08ms	unsure 🔍 -2% - +2% -0.71ms - +0.86ms
tip-of-tree tip-of-tree	33.99ms - 34.98ms	unsure 🔍 -3% - +1% -1.08ms - +0.50ms	-	unsure 🔍 -3% - +1% -0.91ms - +0.47ms
previous-release previous-release	34.22ms - 35.19ms	unsure 🔍 -2% - +2% -0.86ms - +0.71ms	unsure 🔍 -1% - +3% -0.47ms - +0.91ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	78.01ms - 79.75ms	-	unsure 🔍 -2% - +1% -1.46ms - +0.96ms	unsure 🔍 -2% - +1% -1.97ms - +0.77ms
tip-of-tree tip-of-tree	78.28ms - 79.97ms	unsure 🔍 -1% - +2% -0.96ms - +1.46ms	-	unsure 🔍 -2% - +1% -1.70ms - +1.00ms
previous-release previous-release	78.42ms - 80.53ms	unsure 🔍 -1% - +2% -0.77ms - +1.97ms	unsure 🔍 -1% - +2% -1.00ms - +1.70ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 122.0.6261.94
Sample size: 50
Built by: Benchmarks #6138
Commit: eee2730

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	31.88ms - 32.49ms	-	faster ✔ 0% - 3% 0.14ms - 1.15ms	unsure 🔍 -2% - +1% -0.59ms - +0.32ms
tip-of-tree tip-of-tree	32.42ms - 33.23ms	slower ❌ 0% - 4% 0.14ms - 1.15ms	-	unsure 🔍 -0% - +3% -0.02ms - +1.03ms
previous-release previous-release	31.98ms - 32.66ms	unsure 🔍 -1% - +2% -0.32ms - +0.59ms	unsure 🔍 -3% - +0% -1.03ms - +0.02ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	551.22ms - 560.56ms	-	unsure 🔍 -1% - +1% -4.99ms - +7.48ms	unsure 🔍 -1% - +1% -5.85ms - +7.13ms
tip-of-tree tip-of-tree	550.51ms - 558.79ms	unsure 🔍 -1% - +1% -7.48ms - +4.99ms	-	unsure 🔍 -1% - +1% -6.72ms - +5.51ms
previous-release previous-release	550.75ms - 559.76ms	unsure 🔍 -1% - +1% -7.13ms - +5.85ms	unsure 🔍 -1% - +1% -5.51ms - +6.72ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	556.67ms - 564.29ms	-	unsure 🔍 -1% - +1% -4.44ms - +5.66ms	unsure 🔍 -0% - +1% -2.27ms - +7.46ms
tip-of-tree tip-of-tree	556.56ms - 563.19ms	unsure 🔍 -1% - +1% -5.66ms - +4.44ms	-	unsure 🔍 -0% - +1% -2.51ms - +6.47ms
previous-release previous-release	554.86ms - 560.92ms	unsure 🔍 -1% - +0% -7.46ms - +2.27ms	unsure 🔍 -1% - +0% -6.47ms - +2.51ms	-

_{tachometer-reporter-action v2 for Benchmarks}

github-actions · 2024-03-07T22:28:26Z

The size of lit-html.js and lit-core.min.js are as expected.

justinfagnani

nice! 🎉

augustjk · 2024-03-07T22:59:27Z

Benchmarks workflow failure should be fixed by #4573

stefanpearson

Amazing! I didn't expect a fix so quickly, you outpaced my workaround PR. I'm also glad I'm, in fact, not insane. 🙌

stefanpearson · 2024-03-11T16:53:37Z

Hey @augustjk 👋 , what is the release schedule for pushing out a new version?

augustjk · 2024-03-14T21:03:03Z

@stefanpearson Sorry for the delay. It has just now been published!

stefanpearson · 2024-03-15T16:10:30Z

@stefanpearson Sorry for the delay. It has just now been published!

Thanks!

augustjk added 3 commits March 7, 2024 14:18

Add regression test

0aa335b

Early return on unchanged event prop binding

5b215ac

Add changeset

f5e2fec

augustjk requested review from AndrewJakubowicz and justinfagnani March 7, 2024 22:26

augustjk requested a review from kevinpschaaf as a code owner March 7, 2024 22:26

justinfagnani approved these changes Mar 7, 2024

View reviewed changes

stefanpearson approved these changes Mar 8, 2024

View reviewed changes

Merge branch 'main' into react-event-binds

eee2730

augustjk merged commit 5ed30d4 into main Mar 8, 2024

augustjk deleted the react-event-binds branch March 8, 2024 18:15

lit-robot mentioned this pull request Mar 11, 2024

Version Packages #4579

Merged

vmizg mentioned this pull request Sep 26, 2024

@lit/react binds event callback prop as instance property, overriding the element's class method #4569

Closed

[lit/react] Fix event binding erroneously being set on custom element instance #4572

[lit/react] Fix event binding erroneously being set on custom element instance #4572

Uh oh!

Conversation

augustjk commented Mar 7, 2024

Uh oh!

changeset-bot bot commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

Uh oh!

github-actions bot commented Mar 7, 2024

Uh oh!

justinfagnani left a comment

Choose a reason for hiding this comment

Uh oh!

augustjk commented Mar 7, 2024

Uh oh!

stefanpearson left a comment

Choose a reason for hiding this comment

Uh oh!

stefanpearson commented Mar 11, 2024

Uh oh!

augustjk commented Mar 14, 2024

Uh oh!

stefanpearson commented Mar 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Mar 7, 2024 •

edited

Loading

github-actions bot commented Mar 7, 2024 •

edited

Loading