[labs/tsserver-plugin] Get initial rule and test working #4805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultsthis-change
render
update
update-reflect
this-change, tip-of-tree, previous-release
render
update
nop-update
this-change, tip-of-tree, previous-release
render
update
this-change, tip-of-tree, previous-release
render
update
update-reflect
|
Contributor
|
The size of lit-html.js and lit-core.min.js are as expected. |
411a2aa to
827075b
Compare
43081j
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a bunch of infrastructure work and the initial rule for the LanguageService.
The rule setup is extremely minimal. There's no rule interface, no configuration support - just one ad-hoc rule instance to show where things would go when their fleshed out, and how the template parser can initially be used.
Rules should eventually live in another package that's also accessible by the linter. It's just easiest to build them in the tsserver plugin for now.
I do some tricks to write our language service as a class that extends the typescript language service. It's a little overkill, but I like being about to write it as a class. I also load JS modules, which makes loading async. This works in VS Code, and only requires a small trick to get it working in tests. The TypeScript teams says that already have async plugin loading workin on the web and they just need to get to it for Node, so the hack will be able to away. It can also go away with
require(esm)support that is rolling out in Node.Based on #4267, so that should go in first.