Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kyubisation
Copy link
Contributor

With a recent TypeScript update, new properties were introduced to the ARIAMixin interface. This PR adds ariaColIndexText and ariaRowIndexText to the shim or ElementInternals.

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: c080baf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/ssr-dom-shim Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kyubisation kyubisation changed the title [@lit-labs/ssr-dom-shim] Add missing aria properties to ElementInternals shim [labs/ssr-dom-shim] Add missing aria properties to ElementInternals shim Jan 30, 2025
@kyubisation kyubisation changed the title [labs/ssr-dom-shim] Add missing aria properties to ElementInternals shim [labs/ssr-dom-shim] Add ariaColIndexText and ariaRowIndexText to ElementInternals shim Mar 11, 2025
@justinfagnani
Copy link
Collaborator

@kyubisation there's a build error here. Do we need to update the ARIAAttributeMap interface too?

Copy link
Collaborator

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the build error...

@kyubisation kyubisation changed the title [labs/ssr-dom-shim] Add ariaColIndexText and ariaRowIndexText to ElementInternals shim [labs/ssr-dom-shim] Add ariaColIndexText, ariaRowIndexText and ariaRelevant to ElementInternals shim Mar 13, 2025
@kyubisation
Copy link
Contributor Author

There was already a new property aria-relevant since I added the new properties.
Should be fixed now.

@kyubisation kyubisation changed the title [labs/ssr-dom-shim] Add ariaColIndexText, ariaRowIndexText and ariaRelevant to ElementInternals shim [labs/ssr-dom-shim] Add ariaColIndexText, ariaRelevant and ariaRowIndexText to ElementInternals shim Mar 13, 2025
@kyubisation
Copy link
Contributor Author

Sorry, this is a bit confusing. VS Code references a different lib.dom.d.ts than the project does.
Therefore this PR is only relevant if we update our typescript dependency.
Should I close it for now?

@justinfagnani
Copy link
Collaborator

@kyubisation help me understand this:

Therefore this PR is only relevant if we update our typescript dependency

Is the only problem here that we have an old TypeScript, or is it that the problem pops up if we have a newer TypeScript?

It looks like we do need to add these properties, so for the type error, I think we can just add to the the ARIAMixin interface (with a TODO to remove them later).

@kyubisation
Copy link
Contributor Author

Sorry, I wrote that in a confusing matter.
We are currently on version 5.5 of TypeScript.
TypeScript 5.7 added ariaColIndexText and ariaRowIndexText.
TypeScript 5.8 added ariaRelevant.
As long as we stick to version 5.5, we don't need to add these properties.

@kyubisation
Copy link
Contributor Author

Replaced by #4984

@kyubisation kyubisation closed this May 3, 2025
@kyubisation kyubisation deleted the fix-dom-shim-aria-mixin branch August 2, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants