-
Notifications
You must be signed in to change notification settings - Fork 1k
[labs/ssr-dom-shim] Add ariaColIndexText, ariaRelevant and ariaRowIndexText to ElementInternals shim #4878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: c080baf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@kyubisation there's a build error here. Do we need to update the |
justinfagnani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the build error...
|
There was already a new property |
|
Sorry, this is a bit confusing. VS Code references a different lib.dom.d.ts than the project does. |
|
@kyubisation help me understand this:
Is the only problem here that we have an old TypeScript, or is it that the problem pops up if we have a newer TypeScript? It looks like we do need to add these properties, so for the type error, I think we can just add to the the ARIAMixin interface (with a TODO to remove them later). |
|
Sorry, I wrote that in a confusing matter. |
|
Replaced by #4984 |
With a recent TypeScript update, new properties were introduced to the ARIAMixin interface. This PR adds
ariaColIndexTextandariaRowIndexTextto the shim or ElementInternals.