Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[all] Update package lock #5031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 1 commit into from
Aug 4, 2025
Merged

[all] Update package lock #5031

justinfagnani merged 1 commit into from
Aug 4, 2025

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Aug 3, 2025 •
edited
Loading

Also a small change to @lit-labs/signals to remove a workaround for a bug that was fixed in the polyfill.

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: bd0cb2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/signals Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -9% - +11% (-1.15ms - +1.35ms)
    this-change vs tip-of-tree

render

  • this-change: 44.02ms - 56.05ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +6% (-0.54ms - +1.22ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: slower ❌ 0% - 4% (0.09ms - 1.43ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: faster ✔ 9% - 44% (3.48ms - 29.56ms)
    this-change vs tip-of-tree

update

  • this-change: 447.74ms - 455.44ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +5% (-1.72ms - +1.90ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-1.57ms - +1.33ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +2% (-0.68ms - +7.94ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 433.13ms - 436.56ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-2.68ms - +2.86ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
44.02ms - 56.05ms-

update

VersionAvg timevs
447.74ms - 455.44ms-

update-reflect

VersionAvg timevs
433.13ms - 436.56ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.91ms - 20.17ms-unsure 🔍
-3% - +6%
-0.54ms - +1.22ms		unsure 🔍
-7% - +2%
-1.39ms - +0.32ms
tip-of-tree
tip-of-tree		18.59ms - 19.81msunsure 🔍
-6% - +3%
-1.22ms - +0.54ms		-faster ✔
0% - 8%
0.03ms - 1.71ms
previous-release
previous-release		19.50ms - 20.65msunsure 🔍
-2% - +7%
-0.32ms - +1.39ms		slower ❌
0% - 9%
0.03ms - 1.71ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
35.29ms - 37.97ms-unsure 🔍
-5% - +5%
-1.72ms - +1.90ms		unsure 🔍
-7% - +2%
-2.57ms - +0.74ms
tip-of-tree
tip-of-tree		35.32ms - 37.76msunsure 🔍
-5% - +5%
-1.90ms - +1.72ms		-unsure 🔍
-7% - +1%
-2.57ms - +0.55ms
previous-release
previous-release		36.57ms - 38.52msunsure 🔍
-2% - +7%
-0.74ms - +2.57ms		unsure 🔍
-2% - +7%
-0.55ms - +2.57ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
12.01ms - 13.83ms-unsure 🔍
-9% - +11%
-1.15ms - +1.35ms		unsure 🔍
-2% - +18%
-0.17ms - +2.11ms
tip-of-tree
tip-of-tree		11.96ms - 13.67msunsure 🔍
-10% - +9%
-1.35ms - +1.15ms		-unsure 🔍
-2% - +17%
-0.22ms - +1.96ms
previous-release
previous-release		11.27ms - 12.63msunsure 🔍
-16% - +1%
-2.11ms - +0.17ms		unsure 🔍
-15% - +1%
-1.96ms - +0.22ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
34.87ms - 35.80ms-slower ❌
0% - 4%
0.09ms - 1.43ms		unsure 🔍
-1% - +3%
-0.24ms - +1.07ms
tip-of-tree
tip-of-tree		34.09ms - 35.06msfaster ✔
0% - 4%
0.09ms - 1.43ms		-unsure 🔍
-3% - +1%
-1.01ms - +0.32ms
previous-release
previous-release		34.46ms - 35.38msunsure 🔍
-3% - +1%
-1.07ms - +0.24ms		unsure 🔍
-1% - +3%
-0.32ms - +1.01ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
68.79ms - 70.74ms-unsure 🔍
-2% - +2%
-1.57ms - +1.33ms		unsure 🔍
-1% - +2%
-0.99ms - +1.49ms
tip-of-tree
tip-of-tree		68.81ms - 70.96msunsure 🔍
-2% - +2%
-1.33ms - +1.57ms		-unsure 🔍
-1% - +2%
-0.94ms - +1.70ms
previous-release
previous-release		68.74ms - 70.28msunsure 🔍
-2% - +1%
-1.49ms - +0.99ms		unsure 🔍
-2% - +1%
-1.70ms - +0.94ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
37.87ms - 54.61ms-faster ✔
9% - 44%
3.48ms - 29.56ms		unsure 🔍
-25% - +26%
-11.67ms - +11.86ms
tip-of-tree
tip-of-tree		52.75ms - 72.76msslower ❌
3% - 68%
3.48ms - 29.56ms		-slower ❌
3% - 69%
3.64ms - 29.60ms
previous-release
previous-release		37.87ms - 54.41msunsure 🔍
-26% - +25%
-11.86ms - +11.67ms		faster ✔
9% - 44%
3.64ms - 29.60ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
444.81ms - 450.67ms-unsure 🔍
-0% - +2%
-0.68ms - +7.94ms		unsure 🔍
-1% - +1%
-4.64ms - +3.09ms
tip-of-tree
tip-of-tree		440.96ms - 447.27msunsure 🔍
-2% - +0%
-7.94ms - +0.68ms		-faster ✔
0% - 2%
0.36ms - 8.45ms
previous-release
previous-release		446.00ms - 451.04msunsure 🔍
-1% - +1%
-3.09ms - +4.64ms		slower ❌
0% - 2%
0.36ms - 8.45ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
449.51ms - 453.38ms-unsure 🔍
-1% - +1%
-2.68ms - +2.86ms		unsure 🔍
-0% - +1%
-1.85ms - +2.90ms
tip-of-tree
tip-of-tree		449.37ms - 453.34msunsure 🔍
-1% - +1%
-2.86ms - +2.68ms		-unsure 🔍
-0% - +1%
-1.98ms - +2.84ms
previous-release
previous-release		449.55ms - 452.30msunsure 🔍
-1% - +0%
-2.90ms - +1.85ms		unsure 🔍
-1% - +0%
-2.84ms - +1.98ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2025

The size of lit-html.js and lit-core.min.js are as expected.

@justinfagnani
[all] Update package lock
bd0cb2e 
Also removes a workaround for a fixed bug in the
signal-polyfill package.
kyubisation
kyubisation approved these changes Aug 3, 2025
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@justinfagnani justinfagnani requested a review from augustjk August 4, 2025 18:51
@justinfagnani justinfagnani merged commit 1889e0e into main Aug 4, 2025
12 of 13 checks passed
@justinfagnani justinfagnani deleted the update-package-lock branch August 4, 2025 19:00
@lit-robot lit-robot mentioned this pull request Dec 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augustjk augustjk augustjk approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

+1 more reviewer

@kyubisation kyubisation kyubisation approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinfagnani @kyubisation @augustjk