Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/vscode-extension] Initial extension implementation #5045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 1 commit into from
Aug 23, 2025
Merged

[labs/vscode-extension] Initial extension implementation #5045

justinfagnani merged 1 commit into from
Aug 23, 2025

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Aug 21, 2025

The "Hello World" of VS Code extensions...

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 4771bd5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/vscode-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +9% (-0.23ms - +0.98ms)
    this-change vs tip-of-tree

render

  • this-change: 44.23ms - 56.98ms
  • this-change, tip-of-tree, previous-release: faster ✔ 2% - 10% (0.41ms - 2.04ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +3% (-0.57ms - +0.90ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: faster ✔ 11% - 46% (5.36ms - 32.61ms)
    this-change vs tip-of-tree

update

  • this-change: 483.18ms - 492.38ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +5% (-1.90ms - +1.98ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +1% (-3.28ms - +0.93ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: slower ❌ 0% - 3% (0.77ms - 15.36ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 472.96ms - 478.19ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-7.55ms - +4.90ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
44.23ms - 56.98ms-

update

VersionAvg timevs
483.18ms - 492.38ms-

update-reflect

VersionAvg timevs
472.96ms - 478.19ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.51ms - 19.67ms-faster ✔
2% - 10%
0.41ms - 2.04ms		unsure 🔍
-7% - +1%
-1.37ms - +0.15ms
tip-of-tree
tip-of-tree		19.74ms - 20.89msslower ❌
2% - 11%
0.41ms - 2.04ms		-unsure 🔍
-1% - +7%
-0.13ms - +1.36ms
previous-release
previous-release		19.22ms - 20.18msunsure 🔍
-1% - +7%
-0.15ms - +1.37ms		unsure 🔍
-7% - +1%
-1.36ms - +0.13ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
36.31ms - 39.38ms-unsure 🔍
-5% - +5%
-1.90ms - +1.98ms		unsure 🔍
-5% - +6%
-1.82ms - +2.17ms
tip-of-tree
tip-of-tree		36.62ms - 38.99msunsure 🔍
-5% - +5%
-1.98ms - +1.90ms		-unsure 🔍
-4% - +5%
-1.61ms - +1.88ms
previous-release
previous-release		36.39ms - 38.95msunsure 🔍
-6% - +5%
-2.17ms - +1.82ms		unsure 🔍
-5% - +4%
-1.88ms - +1.61ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
11.33ms - 12.25ms-unsure 🔍
-2% - +9%
-0.23ms - +0.98ms		unsure 🔍
-5% - +6%
-0.63ms - +0.71ms
tip-of-tree
tip-of-tree		11.03ms - 11.80msunsure 🔍
-8% - +2%
-0.98ms - +0.23ms		-unsure 🔍
-8% - +2%
-0.95ms - +0.28ms
previous-release
previous-release		11.27ms - 12.23msunsure 🔍
-6% - +5%
-0.71ms - +0.63ms		unsure 🔍
-3% - +8%
-0.28ms - +0.95ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
35.39ms - 36.51ms-unsure 🔍
-2% - +3%
-0.57ms - +0.90ms		unsure 🔍
-2% - +2%
-0.89ms - +0.70ms
tip-of-tree
tip-of-tree		35.30ms - 36.26msunsure 🔍
-3% - +2%
-0.90ms - +0.57ms		-unsure 🔍
-3% - +1%
-1.00ms - +0.48ms
previous-release
previous-release		35.48ms - 36.61msunsure 🔍
-2% - +2%
-0.70ms - +0.89ms		unsure 🔍
-1% - +3%
-0.48ms - +1.00ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
76.31ms - 78.90ms-unsure 🔍
-4% - +1%
-3.28ms - +0.93ms		unsure 🔍
-4% - +1%
-3.22ms - +1.12ms
tip-of-tree
tip-of-tree		77.12ms - 80.44msunsure 🔍
-1% - +4%
-0.93ms - +3.28ms		-unsure 🔍
-3% - +3%
-2.28ms - +2.53ms
previous-release
previous-release		76.91ms - 80.40msunsure 🔍
-1% - +4%
-1.12ms - +3.22ms		unsure 🔍
-3% - +3%
-2.53ms - +2.28ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
38.22ms - 55.56ms-faster ✔
11% - 46%
5.36ms - 32.61ms		unsure 🔍
-31% - +19%
-15.57ms - +9.82ms
tip-of-tree
tip-of-tree		55.36ms - 76.39msslower ❌
6% - 75%
5.36ms - 32.61ms		-unsure 🔍
-0% - +65%
+2.09ms - +30.13ms
previous-release
previous-release		40.50ms - 59.03msunsure 🔍
-22% - +34%
-9.82ms - +15.57ms		faster ✔
6% - 43%
2.09ms - 30.13ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
467.30ms - 479.04ms-slower ❌
0% - 3%
0.77ms - 15.36ms		unsure 🔍
-1% - +2%
-3.66ms - +11.57ms
tip-of-tree
tip-of-tree		460.78ms - 469.43msfaster ✔
0% - 3%
0.77ms - 15.36ms		-unsure 🔍
-2% - +1%
-10.61ms - +2.39ms
previous-release
previous-release		464.37ms - 474.06msunsure 🔍
-2% - +1%
-11.57ms - +3.66ms		unsure 🔍
-1% - +2%
-2.39ms - +10.61ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
465.78ms - 473.90ms-unsure 🔍
-2% - +1%
-7.55ms - +4.90ms		unsure 🔍
-1% - +1%
-6.92ms - +5.65ms
tip-of-tree
tip-of-tree		466.45ms - 475.89msunsure 🔍
-1% - +2%
-4.90ms - +7.55ms		-unsure 🔍
-1% - +2%
-6.04ms - +7.43ms
previous-release
previous-release		465.67ms - 475.27msunsure 🔍
-1% - +1%
-5.65ms - +6.92ms		unsure 🔍
-2% - +1%
-7.43ms - +6.04ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025

The size of lit-html.js and lit-core.min.js are as expected.

@justinfagnani justinfagnani force-pushed the tsserver-go-to-definition branch from 8519905 to b08ac79 Compare August 22, 2025 18:34
Base automatically changed from tsserver-go-to-definition to main August 22, 2025 19:29
rictic
rictic approved these changes Aug 23, 2025
View reviewed changes
.eslintignore
*.tgz
*.tsbuildinfo
.DS_Store
.vscode/
Copy link
Collaborator

@rictic rictic Aug 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Collaborator Author

@justinfagnani justinfagnani Aug 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I needed to check in launch.json and tasks.json for the extension. We had previously ignored it so we could have personal launches and tasks, but there must be some way to have both...

@justinfagnani justinfagnani merged commit e14cca4 into main Aug 23, 2025
10 checks passed
@justinfagnani justinfagnani deleted the lit-extension branch August 23, 2025 23:20
@lit-robot lit-robot mentioned this pull request Dec 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rictic rictic rictic approved these changes

@e111077 e111077 Awaiting requested review from e111077

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinfagnani @rictic