[labs/tsserver-plugin] Type check Lit property bindings #5056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultsthis-change
render
update
update-reflect
this-change, tip-of-tree, previous-release
render
update
nop-update
this-change, tip-of-tree, previous-release
render
update
this-change, tip-of-tree, previous-release
render
update
update-reflect
|
Contributor
|
The size of lit-html.js and lit-core.min.js are as expected. |
🦋 Changeset detectedLatest commit: 8e9cf61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
justinfagnani
approved these changes
Aug 22, 2025
| * Central definition of diagnostic codes. | ||
| */ | ||
| export const LitDiagnosticCode = { | ||
| BindingLikeAttributeName: 6301, |
Collaborator
There was a problem hiding this comment.
Can we comment on why we chose these numbers?
packages/labs/tsserver-plugin/src/lib/rules/no-unassignable-property-bindings.ts
Show resolved
Hide resolved
| } else { | ||
| if (part.expressions.length !== 1) { | ||
| throw new Error( | ||
| 'InternalError: Expected exactly one expression' |
Collaborator
There was a problem hiding this comment.
This should be impossible, but want to leave any breadcrumbs for after-the-fact debugging? Like outputting the attribute test from the template?
| element.tagName | ||
| ); | ||
| if (elementType === undefined) { | ||
| // Unknown element. Other rules will warn in this case. |
Collaborator
There was a problem hiding this comment.
Does the HTMLElementTagNameMap include built-in elements? Should we fall back to HTMLElement for unknown elements? ie, a .id=${} binding is fine actually, but if we don't know the element .foo=${} is bad.
Collaborator
Author
There was a problem hiding this comment.
It does include built-ins, but yeah, good point, we should fall back to HTMLUnknownElement here.
| const location = element.sourceCodeLocation?.attrs?.[attr.name]; | ||
| const templateStart = | ||
| (typescript.isNoSubstitutionTemplateLiteral(tsNode.template) | ||
| ? tsNode.template.getStart() |
Collaborator
There was a problem hiding this comment.
I'm still not entirely sure the difference, but I've been trying to use getFullStart() after getting inconsistence results from other methods and properties.
packages/labs/tsserver-plugin/src/lib/rules/no-unassignable-property-bindings.ts
Show resolved
Hide resolved
Collaborator
|
I think we should merge this into main when it's prereqs are in, instead of into |
…ndings. Not implemented yet, just a commit hooking things up.
b1fe56e to
dd920c2
Compare
justinfagnani
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.