Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[lit-html] Include SVGElement in render root union type #5064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinfagnani merged 2 commits into from
Aug 31, 2025
Merged

[lit-html] Include SVGElement in render root union type #5064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fdb4d7
[lit-html] Include SVGElement in render root union type
brysonbw Aug 29, 2025
dac5670
Update .changeset/sour-heads-study.md
justinfagnani Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sour-heads-study.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'lit-html': patch
---

Add `SVGElement` to the `render()` container type, allowing SVG elements to be used as render roots without type errors.
11 changes: 8 additions & 3 deletions packages/lit-html/src/lit-html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@ export namespace LitUnstable {
kind: 'begin render';
id: number;
value: unknown;
container: HTMLElement | DocumentFragment;
container: RenderRootNode;
options: RenderOptions | undefined;
part: ChildPart | undefined;
}
export interface EndRender {
kind: 'end render';
id: number;
value: unknown;
container: HTMLElement | DocumentFragment;
container: RenderRootNode;
options: RenderOptions | undefined;
part: ChildPart;
}
Expand Down Expand Up @@ -722,6 +722,11 @@ export interface RenderOptions {
isConnected?: boolean;
}

/**
* The root DOM node for rendering.
*/
export type RenderRootNode = HTMLElement | SVGElement | DocumentFragment;

const walker = d.createTreeWalker(
d,
129 /* NodeFilter.SHOW_{ELEMENT|COMMENT} */
Expand Down Expand Up @@ -2240,7 +2245,7 @@ if (DEV_MODE && global.litHtmlVersions.length > 1) {
*/
export const render = (
value: unknown,
container: HTMLElement | DocumentFragment,
container: RenderRootNode,
options?: RenderOptions
): RootPart => {
if (DEV_MODE && container == null) {
Expand Down
Loading