Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/ssr] Convert a few generators to plain functions #5087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
justinfagnani wants to merge 1 commit into from
Closed

[labs/ssr] Convert a few generators to plain functions #5087

justinfagnani wants to merge 1 commit into from

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Sep 6, 2025

This may be a small performance improvement...

cc @jimsimon

@justinfagnani justinfagnani requested a review from rictic September 6, 2025 07:08
@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2025

⚠️ No Changeset found

Latest commit: d921807

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +9% (-0.34ms - +1.00ms)
    this-change vs tip-of-tree

render

  • this-change: 44.02ms - 55.67ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +6% (-0.27ms - +1.18ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.46ms - +1.00ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -21% - +34% (-10.08ms - +16.52ms)
    this-change vs tip-of-tree

update

  • this-change: 490.10ms - 498.48ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +7% (-1.94ms - +2.69ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +4% (-0.86ms - +3.12ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-6.55ms - +7.16ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 478.06ms - 485.09ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-5.22ms - +7.90ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
44.02ms - 55.67ms-

update

VersionAvg timevs
490.10ms - 498.48ms-

update-reflect

VersionAvg timevs
478.06ms - 485.09ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.25ms - 20.43ms-unsure 🔍
-1% - +6%
-0.27ms - +1.18ms		unsure 🔍
-7% - +2%
-1.42ms - +0.33ms
tip-of-tree
tip-of-tree		18.96ms - 19.80msunsure 🔍
-6% - +1%
-1.18ms - +0.27ms		-faster ✔
1% - 9%
0.23ms - 1.77ms
previous-release
previous-release		19.74ms - 21.03msunsure 🔍
-2% - +7%
-0.33ms - +1.42ms		slower ❌
1% - 9%
0.23ms - 1.77ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
38.82ms - 42.21ms-unsure 🔍
-5% - +7%
-1.94ms - +2.69ms		unsure 🔍
-5% - +7%
-2.00ms - +2.65ms
tip-of-tree
tip-of-tree		38.56ms - 41.72msunsure 🔍
-7% - +5%
-2.69ms - +1.94ms		-unsure 🔍
-6% - +5%
-2.30ms - +2.19ms
previous-release
previous-release		38.60ms - 41.79msunsure 🔍
-7% - +5%
-2.65ms - +2.00ms		unsure 🔍
-5% - +6%
-2.19ms - +2.30ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
11.49ms - 12.41ms-unsure 🔍
-3% - +9%
-0.34ms - +1.00ms		unsure 🔍
-6% - +5%
-0.69ms - +0.61ms
tip-of-tree
tip-of-tree		11.12ms - 12.10msunsure 🔍
-8% - +3%
-1.00ms - +0.34ms		-unsure 🔍
-9% - +2%
-1.04ms - +0.30ms
previous-release
previous-release		11.52ms - 12.44msunsure 🔍
-5% - +6%
-0.61ms - +0.69ms		unsure 🔍
-3% - +9%
-0.30ms - +1.04ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
36.00ms - 37.04ms-unsure 🔍
-1% - +3%
-0.46ms - +1.00ms		unsure 🔍
-1% - +3%
-0.45ms - +1.02ms
tip-of-tree
tip-of-tree		35.74ms - 36.76msunsure 🔍
-3% - +1%
-1.00ms - +0.46ms		-unsure 🔍
-2% - +2%
-0.71ms - +0.75ms
previous-release
previous-release		35.71ms - 36.75msunsure 🔍
-3% - +1%
-1.02ms - +0.45ms		unsure 🔍
-2% - +2%
-0.75ms - +0.71ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
80.19ms - 82.88ms-unsure 🔍
-1% - +4%
-0.86ms - +3.12ms		unsure 🔍
-1% - +3%
-0.88ms - +2.75ms
tip-of-tree
tip-of-tree		78.94ms - 81.87msunsure 🔍
-4% - +1%
-3.12ms - +0.86ms		-unsure 🔍
-3% - +2%
-2.09ms - +1.71ms
previous-release
previous-release		79.38ms - 81.81msunsure 🔍
-3% - +1%
-2.75ms - +0.88ms		unsure 🔍
-2% - +3%
-1.71ms - +2.09ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
42.93ms - 62.33ms-unsure 🔍
-21% - +34%
-10.08ms - +16.52ms		unsure 🔍
-36% - +7%
-23.02ms - +5.48ms
tip-of-tree
tip-of-tree		40.31ms - 58.51msunsure 🔍
-31% - +18%
-16.52ms - +10.08ms		-unsure 🔍
-40% - +1%
-25.84ms - +1.86ms
previous-release
previous-release		50.96ms - 71.85msunsure 🔍
-13% - +46%
-5.48ms - +23.02ms		unsure 🔍
-7% - +55%
-1.86ms - +25.84ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
494.34ms - 503.48ms-unsure 🔍
-1% - +1%
-6.55ms - +7.16ms		unsure 🔍
-2% - +2%
-7.57ms - +9.24ms
tip-of-tree
tip-of-tree		493.50ms - 503.72msunsure 🔍
-1% - +1%
-7.16ms - +6.55ms		-unsure 🔍
-2% - +2%
-8.18ms - +9.24ms
previous-release
previous-release		491.02ms - 505.13msunsure 🔍
-2% - +2%
-9.24ms - +7.57ms		unsure 🔍
-2% - +2%
-9.24ms - +8.18ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
500.04ms - 509.18ms-unsure 🔍
-1% - +2%
-5.22ms - +7.90ms		unsure 🔍
-2% - +1%
-7.85ms - +6.74ms
tip-of-tree
tip-of-tree		498.57ms - 507.98msunsure 🔍
-2% - +1%
-7.90ms - +5.22ms		-unsure 🔍
-2% - +1%
-9.28ms - +5.49ms
previous-release
previous-release		499.48ms - 510.85msunsure 🔍
-1% - +2%
-6.74ms - +7.85ms		unsure 🔍
-1% - +2%
-5.49ms - +9.28ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2025

The size of lit-html.js and lit-core.min.js are as expected.

rictic
rictic approved these changes Sep 16, 2025
View reviewed changes
Copy link
Collaborator

@rictic rictic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changeset.

Do we consider this a breaking change?

@justinfagnani
Copy link
Collaborator Author

justinfagnani commented Sep 28, 2025

Closing in favor of #5106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rictic rictic rictic approved these changes

@jimsimon jimsimon jimsimon approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinfagnani @rictic @jimsimon