Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/ssr] Fix import.meta.url in VM modules #5088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 1 commit into from
Sep 8, 2025
Merged

[labs/ssr] Fix import.meta.url in VM modules #5088

justinfagnani merged 1 commit into from
Sep 8, 2025

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Sep 7, 2025

import.meta.url in the ModuleLoader had a :n appended to it with the context ID (or something similar).

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2025

🦋 Changeset detected

Latest commit: b0cbcd5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/ssr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +11% (-0.04ms - +1.21ms)
    this-change vs tip-of-tree

render

  • this-change: 41.90ms - 53.17ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +7% (-0.56ms - +1.38ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: slower ❌ 0% - 4% (0.01ms - 1.41ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -24% - +25% (-13.85ms - +14.25ms)
    this-change vs tip-of-tree

update

  • this-change: 451.15ms - 456.22ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +11% (-0.30ms - +3.70ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-1.55ms - +0.51ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-3.94ms - +4.93ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 439.33ms - 442.09ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-3.53ms - +2.44ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
41.90ms - 53.17ms-

update

VersionAvg timevs
451.15ms - 456.22ms-

update-reflect

VersionAvg timevs
439.33ms - 442.09ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.94ms - 20.30ms-unsure 🔍
-3% - +7%
-0.56ms - +1.38ms		unsure 🔍
-0% - +8%
-0.05ms - +1.49ms
tip-of-tree
tip-of-tree		18.52ms - 19.90msunsure 🔍
-7% - +3%
-1.38ms - +0.56ms		-unsure 🔍
-3% - +6%
-0.47ms - +1.10ms
previous-release
previous-release		18.53ms - 19.26msunsure 🔍
-7% - +0%
-1.49ms - +0.05ms		unsure 🔍
-6% - +2%
-1.10ms - +0.47ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
35.33ms - 38.21ms-unsure 🔍
-1% - +11%
-0.30ms - +3.70ms		unsure 🔍
-4% - +7%
-1.38ms - +2.51ms
tip-of-tree
tip-of-tree		33.68ms - 36.46msunsure 🔍
-10% - +1%
-3.70ms - +0.30ms		-unsure 🔍
-8% - +2%
-3.04ms - +0.78ms
previous-release
previous-release		34.90ms - 37.52msunsure 🔍
-7% - +4%
-2.51ms - +1.38ms		unsure 🔍
-2% - +9%
-0.78ms - +3.04ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
11.19ms - 12.14ms-unsure 🔍
-0% - +11%
-0.04ms - +1.21ms		unsure 🔍
-6% - +5%
-0.67ms - +0.63ms
tip-of-tree
tip-of-tree		10.68ms - 11.48msunsure 🔍
-10% - +0%
-1.21ms - +0.04ms		-faster ✔
0% - 10%
0.01ms - 1.21ms
previous-release
previous-release		11.24ms - 12.13msunsure 🔍
-5% - +6%
-0.63ms - +0.67ms		unsure 🔍
-0% - +11%
+0.01ms - +1.21ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
35.22ms - 36.29ms-slower ❌
0% - 4%
0.01ms - 1.41ms		slower ❌
1% - 4%
0.18ms - 1.53ms
tip-of-tree
tip-of-tree		34.59ms - 35.50msfaster ✔
0% - 4%
0.01ms - 1.41ms		-unsure 🔍
-1% - +2%
-0.47ms - +0.76ms
previous-release
previous-release		34.48ms - 35.31msfaster ✔
1% - 4%
0.18ms - 1.53ms		unsure 🔍
-2% - +1%
-0.76ms - +0.47ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
68.59ms - 69.89ms-unsure 🔍
-2% - +1%
-1.55ms - +0.51ms		unsure 🔍
-3% - +1%
-1.86ms - +0.83ms
tip-of-tree
tip-of-tree		68.97ms - 70.56msunsure 🔍
-1% - +2%
-0.51ms - +1.55ms		-unsure 🔍
-2% - +2%
-1.42ms - +1.43ms
previous-release
previous-release		68.58ms - 70.94msunsure 🔍
-1% - +3%
-0.83ms - +1.86ms		unsure 🔍
-2% - +2%
-1.43ms - +1.42ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
47.52ms - 67.43ms-unsure 🔍
-24% - +25%
-13.85ms - +14.25ms		unsure 🔍
-24% - +25%
-13.96ms - +14.22ms
tip-of-tree
tip-of-tree		47.37ms - 67.18msunsure 🔍
-25% - +24%
-14.25ms - +13.85ms		-unsure 🔍
-25% - +24%
-14.12ms - +13.98ms
previous-release
previous-release		47.38ms - 67.31msunsure 🔍
-25% - +24%
-14.22ms - +13.96ms		unsure 🔍
-24% - +25%
-13.98ms - +14.12ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
454.31ms - 460.65ms-unsure 🔍
-1% - +1%
-3.94ms - +4.93ms		unsure 🔍
-1% - +1%
-5.18ms - +4.16ms
tip-of-tree
tip-of-tree		453.89ms - 460.09msunsure 🔍
-1% - +1%
-4.93ms - +3.94ms		-unsure 🔍
-1% - +1%
-5.62ms - +3.62ms
previous-release
previous-release		454.56ms - 461.41msunsure 🔍
-1% - +1%
-4.16ms - +5.18ms		unsure 🔍
-1% - +1%
-3.62ms - +5.62ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
458.57ms - 462.86ms-unsure 🔍
-1% - +1%
-3.53ms - +2.44ms		unsure 🔍
-1% - +1%
-3.50ms - +2.65ms
tip-of-tree
tip-of-tree		459.19ms - 463.34msunsure 🔍
-1% - +1%
-2.44ms - +3.53ms		-unsure 🔍
-1% - +1%
-2.90ms - +3.15ms
previous-release
previous-release		458.94ms - 463.34msunsure 🔍
-1% - +1%
-2.65ms - +3.50ms		unsure 🔍
-1% - +1%
-3.15ms - +2.90ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2025

The size of lit-html.js and lit-core.min.js are as expected.

jimsimon
jimsimon approved these changes Sep 8, 2025
View reviewed changes
Copy link
Collaborator

@jimsimon jimsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinfagnani justinfagnani merged commit 956d957 into main Sep 8, 2025
10 checks passed
@justinfagnani justinfagnani deleted the ssr-import-meta branch September 8, 2025 18:58
@lit-robot lit-robot mentioned this pull request Dec 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimsimon jimsimon jimsimon approved these changes

@augustjk augustjk augustjk approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinfagnani @jimsimon @augustjk