Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/ssr-client] fix loop mutation in hydrate support #5115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 8 commits into from
Dec 10, 2025
Merged

[labs/ssr-client] fix loop mutation in hydrate support #5115

justinfagnani merged 8 commits into from
Dec 10, 2025
+142 −9

Conversation

@zeroedin
Copy link
Contributor

@zeroedin zeroedin commented Oct 9, 2025

Fixes Array mutation problem in hydration-support

Addresses #5114

@zeroedin zeroedin requested a review from kevinpschaaf as a code owner October 9, 2025 18:27
@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 7023fcc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/ssr-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla
Copy link

google-cla bot commented Oct 9, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@zeroedin zeroedin mentioned this pull request Oct 9, 2025
Closed
@Lookwe69
Copy link

Lookwe69 commented Oct 9, 2025

Are you sure this.attributes is an Iterable ? I thought it was a ArrayLike.
Is it performance related to not using for...of ?

justinfagnani
justinfagnani requested changes Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

We really need a test to show that this is a valid fix and make sure we don't regress.

@justinfagnani
Copy link
Collaborator

justinfagnani commented Oct 9, 2025

Are you sure this.attributes is an Iterable ? I thought it was a ArrayLike. Is it performance related to not using for...of ?

NamedNodeMap is iterable, but it's also live (unlike an array iterator) so we can't use it directly here.

@zeroedin zeroedin mentioned this pull request Oct 14, 2025
Merged
@zeroedin zeroedin changed the title fix: loop mutation in hydrate support [labs/ssr-client] fix loop mutation in hydrate support Oct 14, 2025
@justinfagnani justinfagnani merged commit ed877c8 into lit:main Dec 10, 2025
7 checks passed
@justinfagnani
Copy link
Collaborator

justinfagnani commented Dec 10, 2025

Thanks @zeroedin!! Sorry for the long review time!

@lit-robot lit-robot mentioned this pull request Dec 18, 2025
Merged
bennypowers added a commit to RedHat-UX/red-hat-design-system that referenced this pull request Dec 26, 2025
@bennypowers
chore: remove ssr-client patch
e3782bd 
addressed in lit/lit#5115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@bennypowers bennypowers bennypowers approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zeroedin @Lookwe69 @justinfagnani @bennypowers