Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/ssr,lit-html,lit] Add direct-html directive and rendering support #5156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
jimsimon wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[labs/ssr,lit-html,lit] Add direct-html directive and rendering support #5156

jimsimon wants to merge 2 commits into from

Conversation

@jimsimon
Copy link
Collaborator

@jimsimon jimsimon commented Nov 4, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e904b63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +15% (-0.02ms - +1.86ms)
    this-change vs tip-of-tree

render

  • this-change: 47.28ms - 60.04ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +5% (-0.63ms - +1.04ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +1% (-0.91ms - +0.41ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +9% (+0.11ms - +9.62ms)
    this-change vs tip-of-tree

update

  • this-change: 486.33ms - 495.88ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +6% (-1.45ms - +2.34ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: faster ✔ 1% - 6% (0.53ms - 4.44ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-7.21ms - +8.21ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 470.50ms - 477.97ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-8.59ms - +5.12ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
47.28ms - 60.04ms-

update

VersionAvg timevs
486.33ms - 495.88ms-

update-reflect

VersionAvg timevs
470.50ms - 477.97ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.06ms - 20.18ms-unsure 🔍
-3% - +5%
-0.63ms - +1.04ms		unsure 🔍
-5% - +4%
-0.98ms - +0.76ms
tip-of-tree
tip-of-tree		18.80ms - 20.04msunsure 🔍
-5% - +3%
-1.04ms - +0.63ms		-unsure 🔍
-6% - +3%
-1.22ms - +0.59ms
previous-release
previous-release		19.07ms - 20.40msunsure 🔍
-4% - +5%
-0.76ms - +0.98ms		unsure 🔍
-3% - +6%
-0.59ms - +1.22ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
37.16ms - 39.24ms-unsure 🔍
-4% - +6%
-1.45ms - +2.34ms		unsure 🔍
-7% - +1%
-2.68ms - +0.60ms
tip-of-tree
tip-of-tree		36.17ms - 39.34msunsure 🔍
-6% - +4%
-2.34ms - +1.45ms		-unsure 🔍
-9% - +1%
-3.51ms - +0.54ms
previous-release
previous-release		37.98ms - 40.50msunsure 🔍
-2% - +7%
-0.60ms - +2.68ms		unsure 🔍
-2% - +9%
-0.54ms - +3.51ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
12.74ms - 14.11ms-unsure 🔍
-0% - +15%
-0.02ms - +1.86ms		unsure 🔍
-2% - +13%
-0.27ms - +1.66ms
tip-of-tree
tip-of-tree		11.87ms - 13.15msunsure 🔍
-14% - -0%
-1.86ms - +0.02ms		-unsure 🔍
-9% - +6%
-1.15ms - +0.71ms
previous-release
previous-release		12.05ms - 13.41msunsure 🔍
-12% - +2%
-1.66ms - +0.27ms		unsure 🔍
-6% - +9%
-0.71ms - +1.15ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
35.25ms - 36.10ms-unsure 🔍
-3% - +1%
-0.91ms - +0.41ms		unsure 🔍
-2% - +2%
-0.61ms - +0.68ms
tip-of-tree
tip-of-tree		35.42ms - 36.44msunsure 🔍
-1% - +3%
-0.41ms - +0.91ms		-unsure 🔍
-1% - +3%
-0.42ms - +0.99ms
previous-release
previous-release		35.15ms - 36.13msunsure 🔍
-2% - +2%
-0.68ms - +0.61ms		unsure 🔍
-3% - +1%
-0.99ms - +0.42ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
72.41ms - 74.91ms-faster ✔
1% - 6%
0.53ms - 4.44ms		unsure 🔍
-5% - +0%
-3.76ms - +0.07ms
tip-of-tree
tip-of-tree		74.63ms - 77.64msslower ❌
1% - 6%
0.53ms - 4.44ms		-unsure 🔍
-2% - +4%
-1.45ms - +2.72ms
previous-release
previous-release		74.05ms - 76.95msunsure 🔍
-0% - +5%
-0.07ms - +3.76ms		unsure 🔍
-4% - +2%
-2.72ms - +1.45ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
106.34ms - 110.43ms-unsure 🔍
-0% - +9%
+0.11ms - +9.62ms		unsure 🔍
-1% - +4%
-0.58ms - +3.89ms
tip-of-tree
tip-of-tree		99.23ms - 107.81msfaster ✔
0% - 9%
0.11ms - 9.62ms		-unsure 🔍
-7% - +1%
-7.60ms - +1.17ms
previous-release
previous-release		105.83ms - 107.63msunsure 🔍
-4% - +1%
-3.89ms - +0.58ms		unsure 🔍
-1% - +7%
-1.17ms - +7.60ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
478.76ms - 487.78ms-unsure 🔍
-1% - +2%
-7.21ms - +8.21ms		unsure 🔍
-1% - +2%
-3.93ms - +9.76ms
tip-of-tree
tip-of-tree		476.51ms - 489.03msunsure 🔍
-2% - +1%
-8.21ms - +7.21ms		-unsure 🔍
-1% - +2%
-5.69ms - +10.52ms
previous-release
previous-release		475.20ms - 485.51msunsure 🔍
-2% - +1%
-9.76ms - +3.93ms		unsure 🔍
-2% - +1%
-10.52ms - +5.69ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
487.55ms - 496.25ms-unsure 🔍
-2% - +1%
-8.59ms - +5.12ms		unsure 🔍
-2% - +1%
-8.51ms - +4.19ms
tip-of-tree
tip-of-tree		488.34ms - 498.93msunsure 🔍
-1% - +2%
-5.12ms - +8.59ms		-unsure 🔍
-2% - +1%
-7.46ms - +6.61ms
previous-release
previous-release		489.43ms - 498.69msunsure 🔍
-1% - +2%
-4.19ms - +8.51ms		unsure 🔍
-1% - +2%
-6.61ms - +7.46ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025 •
edited
Loading

This is a size regression. It adds 4 bytes to lit-html.js which is 7,309B at head. We're very sensitive to size increases. If this is intended, please update expectedLitHtmlSize to 7313 in scripts/check-size.js and push a new commit to your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf will be requested when the pull request is marked ready for review kevinpschaaf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jimsimon