Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/forms] Reset version to 0.0.0 before first release #5185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 4 commits into from
Dec 23, 2025
Merged

[labs/forms] Reset version to 0.0.0 before first release #5185

justinfagnani merged 4 commits into from
Dec 23, 2025
+7 −2

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Dec 18, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: f5d5f7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/forms Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +13% (-0.78ms - +1.85ms)
    this-change vs tip-of-tree

render

  • this-change: 47.63ms - 48.66ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -7% - +3% (-1.41ms - +0.71ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +4% (-0.51ms - +1.41ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-0.82ms - +1.66ms)
    this-change vs tip-of-tree

update

  • this-change: 513.90ms - 520.40ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +10% (-1.64ms - +4.29ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +3% (-4.10ms - +2.60ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-7.96ms - +12.33ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 499.66ms - 505.01ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-8.57ms - +10.76ms)
    this-change vs tip-of-tree

Results

⏳ Benchmarks are currently running. Results below are out of date.
this-change

render

VersionAvg timevs
47.63ms - 48.66ms-

update

VersionAvg timevs
513.90ms - 520.40ms-

update-reflect

VersionAvg timevs
499.66ms - 505.01ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.50ms - 20.63ms-unsure 🔍
-7% - +3%
-1.41ms - +0.71ms		unsure 🔍
-7% - +2%
-1.48ms - +0.40ms
tip-of-tree
tip-of-tree		19.52ms - 21.31msunsure 🔍
-4% - +7%
-0.71ms - +1.41ms		-unsure 🔍
-7% - +5%
-1.36ms - +0.97ms
previous-release
previous-release		19.86ms - 21.36msunsure 🔍
-2% - +7%
-0.40ms - +1.48ms		unsure 🔍
-5% - +7%
-0.97ms - +1.36ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
42.22ms - 46.64ms-unsure 🔍
-4% - +10%
-1.64ms - +4.29ms		unsure 🔍
-4% - +10%
-1.64ms - +4.38ms
tip-of-tree
tip-of-tree		41.12ms - 45.09msunsure 🔍
-10% - +4%
-4.29ms - +1.64ms		-unsure 🔍
-7% - +7%
-2.80ms - +2.90ms
previous-release
previous-release		41.01ms - 45.11msunsure 🔍
-10% - +4%
-4.38ms - +1.64ms		unsure 🔍
-7% - +7%
-2.90ms - +2.80ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
13.69ms - 15.64ms-unsure 🔍
-6% - +13%
-0.78ms - +1.85ms		unsure 🔍
-7% - +13%
-1.04ms - +1.78ms
tip-of-tree
tip-of-tree		13.24ms - 15.01msunsure 🔍
-12% - +5%
-1.85ms - +0.78ms		-unsure 🔍
-11% - +8%
-1.51ms - +1.18ms
previous-release
previous-release		13.28ms - 15.31msunsure 🔍
-12% - +7%
-1.78ms - +1.04ms		unsure 🔍
-8% - +11%
-1.18ms - +1.51ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
37.19ms - 38.65ms-unsure 🔍
-1% - +4%
-0.51ms - +1.41ms		unsure 🔍
-3% - +3%
-1.03ms - +1.02ms
tip-of-tree
tip-of-tree		36.85ms - 38.09msunsure 🔍
-4% - +1%
-1.41ms - +0.51ms		-unsure 🔍
-4% - +1%
-1.40ms - +0.49ms
previous-release
previous-release		37.21ms - 38.64msunsure 🔍
-3% - +3%
-1.02ms - +1.03ms		unsure 🔍
-1% - +4%
-0.49ms - +1.40ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
81.51ms - 86.23ms-unsure 🔍
-5% - +3%
-4.10ms - +2.60ms		unsure 🔍
-4% - +4%
-3.53ms - +3.21ms
tip-of-tree
tip-of-tree		82.24ms - 86.99msunsure 🔍
-3% - +5%
-2.60ms - +4.10ms		-unsure 🔍
-3% - +5%
-2.80ms - +3.97ms
previous-release
previous-release		81.62ms - 86.44msunsure 🔍
-4% - +4%
-3.21ms - +3.53ms		unsure 🔍
-5% - +3%
-3.97ms - +2.80ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
107.16ms - 108.91ms-unsure 🔍
-1% - +2%
-0.82ms - +1.66ms		unsure 🔍
-1% - +1%
-1.09ms - +1.46ms
tip-of-tree
tip-of-tree		106.73ms - 108.50msunsure 🔍
-2% - +1%
-1.66ms - +0.82ms		-unsure 🔍
-1% - +1%
-1.52ms - +1.05ms
previous-release
previous-release		106.92ms - 108.78msunsure 🔍
-1% - +1%
-1.46ms - +1.09ms		unsure 🔍
-1% - +1%
-1.05ms - +1.52ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
505.67ms - 518.38ms-unsure 🔍
-2% - +2%
-7.96ms - +12.33ms		unsure 🔍
-1% - +3%
-4.74ms - +13.52ms
tip-of-tree
tip-of-tree		501.94ms - 517.75msunsure 🔍
-2% - +2%
-12.33ms - +7.96ms		-unsure 🔍
-2% - +2%
-8.06ms - +12.48ms
previous-release
previous-release		501.08ms - 514.19msunsure 🔍
-3% - +1%
-13.52ms - +4.74ms		unsure 🔍
-2% - +2%
-12.48ms - +8.06ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
514.80ms - 527.43ms-unsure 🔍
-2% - +2%
-8.57ms - +10.76ms		unsure 🔍
-2% - +2%
-8.68ms - +9.75ms
tip-of-tree
tip-of-tree		512.71ms - 527.34msunsure 🔍
-2% - +2%
-10.76ms - +8.57ms		-unsure 🔍
-2% - +2%
-10.49ms - +9.37ms
previous-release
previous-release		513.87ms - 527.29msunsure 🔍
-2% - +2%
-9.75ms - +8.68ms		unsure 🔍
-2% - +2%
-9.37ms - +10.49ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

The size of lit-html.js and lit-core.min.js are as expected.

augustjk
augustjk approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would’ve thought package-lock might also need updating but ci seems to work so seems we’re good.

augustjk
augustjk reviewed Dec 19, 2025
View reviewed changes
@justinfagnani justinfagnani merged commit 81e113b into main Dec 23, 2025
9 checks passed
@justinfagnani justinfagnani deleted the forms-version branch December 23, 2025 18:27
@lit-robot lit-robot mentioned this pull request Dec 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augustjk augustjk augustjk approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinfagnani @augustjk