Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(labs/cli-mcp-server): delete the MCP package #5186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
e111077 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(labs/cli-mcp-server): delete the MCP package #5186

e111077 wants to merge 1 commit into from
+232 −1,146

Conversation

@e111077
Copy link
Contributor

@e111077 e111077 commented Dec 18, 2025 •
edited
Loading

deleting this package. It was never deployed but mostly because not quite sure MCP is the right approach. Anthropic has had some doubts about how MCP is exposed in the first place. see: https://www.anthropic.com/engineering/code-execution-with-mcp

LMK what you think. Personally I'd like to sit on MCP some more before making a publish, esp since we don't really offer much in our MCP server as of now

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: ad201c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla
Copy link

google-cla bot commented Dec 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +11% (-0.56ms - +1.31ms)
    this-change vs tip-of-tree

render

  • this-change: 45.53ms - 46.41ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +6% (-0.68ms - +1.19ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +1% (-1.17ms - +0.27ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +4% (-1.94ms - +4.02ms)
    this-change vs tip-of-tree

update

  • this-change: 463.10ms - 469.01ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -7% - +2% (-2.75ms - +0.72ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-1.18ms - +1.84ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-5.71ms - +2.74ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 451.87ms - 456.99ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-4.63ms - +4.37ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
45.53ms - 46.41ms-

update

VersionAvg timevs
463.10ms - 469.01ms-

update-reflect

VersionAvg timevs
451.87ms - 456.99ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.84ms - 20.30ms-unsure 🔍
-4% - +6%
-0.68ms - +1.19ms		unsure 🔍
-4% - +6%
-0.68ms - +1.21ms
tip-of-tree
tip-of-tree		18.72ms - 19.91msunsure 🔍
-6% - +3%
-1.19ms - +0.68ms		-unsure 🔍
-4% - +4%
-0.84ms - +0.86ms
previous-release
previous-release		18.70ms - 19.90msunsure 🔍
-6% - +3%
-1.21ms - +0.68ms		unsure 🔍
-4% - +4%
-0.86ms - +0.84ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
36.05ms - 38.50ms-unsure 🔍
-7% - +2%
-2.75ms - +0.72ms		unsure 🔍
-7% - +1%
-2.59ms - +0.55ms
tip-of-tree
tip-of-tree		37.06ms - 39.52msunsure 🔍
-2% - +7%
-0.72ms - +2.75ms		-unsure 🔍
-4% - +4%
-1.58ms - +1.56ms
previous-release
previous-release		37.32ms - 39.28msunsure 🔍
-2% - +7%
-0.55ms - +2.59ms		unsure 🔍
-4% - +4%
-1.56ms - +1.58ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
12.19ms - 13.46ms-unsure 🔍
-5% - +11%
-0.56ms - +1.31ms		unsure 🔍
-6% - +8%
-0.78ms - +1.07ms
tip-of-tree
tip-of-tree		11.77ms - 13.13msunsure 🔍
-10% - +4%
-1.31ms - +0.56ms		-unsure 🔍
-9% - +6%
-1.18ms - +0.72ms
previous-release
previous-release		12.01ms - 13.35msunsure 🔍
-8% - +6%
-1.07ms - +0.78ms		unsure 🔍
-6% - +10%
-0.72ms - +1.18ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
35.17ms - 36.21ms-unsure 🔍
-3% - +1%
-1.17ms - +0.27ms		unsure 🔍
-4% - +1%
-1.33ms - +0.24ms
tip-of-tree
tip-of-tree		35.64ms - 36.63msunsure 🔍
-1% - +3%
-0.27ms - +1.17ms		-unsure 🔍
-2% - +2%
-0.87ms - +0.67ms
previous-release
previous-release		35.65ms - 36.82msunsure 🔍
-1% - +4%
-0.24ms - +1.33ms		unsure 🔍
-2% - +2%
-0.67ms - +0.87ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
73.21ms - 75.37ms-unsure 🔍
-2% - +2%
-1.18ms - +1.84ms		unsure 🔍
-3% - +1%
-2.53ms - +0.75ms
tip-of-tree
tip-of-tree		72.91ms - 75.02msunsure 🔍
-2% - +2%
-1.84ms - +1.18ms		-unsure 🔍
-4% - +1%
-2.84ms - +0.41ms
previous-release
previous-release		73.94ms - 76.42msunsure 🔍
-1% - +3%
-0.75ms - +2.53ms		unsure 🔍
-1% - +4%
-0.41ms - +2.84ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
102.04ms - 103.16ms-unsure 🔍
-2% - +4%
-1.94ms - +4.02ms		unsure 🔍
-2% - +0%
-1.59ms - +0.02ms
tip-of-tree
tip-of-tree		98.64ms - 104.50msunsure 🔍
-4% - +2%
-4.02ms - +1.94ms		-unsure 🔍
-5% - +1%
-4.81ms - +1.17ms
previous-release
previous-release		102.81ms - 103.97msunsure 🔍
-0% - +2%
-0.02ms - +1.59ms		unsure 🔍
-1% - +5%
-1.17ms - +4.81ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
457.12ms - 463.53ms-unsure 🔍
-1% - +1%
-5.71ms - +2.74ms		unsure 🔍
-1% - +1%
-6.40ms - +2.66ms
tip-of-tree
tip-of-tree		459.06ms - 464.56msunsure 🔍
-1% - +1%
-2.74ms - +5.71ms		-unsure 🔍
-1% - +1%
-4.61ms - +3.84ms
previous-release
previous-release		458.99ms - 465.40msunsure 🔍
-1% - +1%
-2.66ms - +6.40ms		unsure 🔍
-1% - +1%
-3.84ms - +4.61ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
471.48ms - 477.95ms-unsure 🔍
-1% - +1%
-4.63ms - +4.37ms		unsure 🔍
-1% - +1%
-5.59ms - +5.25ms
tip-of-tree
tip-of-tree		471.71ms - 477.97msunsure 🔍
-1% - +1%
-4.37ms - +4.63ms		-unsure 🔍
-1% - +1%
-5.40ms - +5.31ms
previous-release
previous-release		470.54ms - 479.24msunsure 🔍
-1% - +1%
-5.25ms - +5.59ms		unsure 🔍
-1% - +1%
-5.31ms - +5.40ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

The size of lit-html.js and lit-core.min.js are as expected.

@e111077
Copy link
Contributor Author

e111077 commented Dec 18, 2025

waiting for CI

@e111077
Copy link
Contributor Author

e111077 commented Dec 18, 2025

i signed it

@e111077 e111077 marked this pull request as ready for review December 18, 2025 23:25
@e111077
chore(labs/cli-mcp-server): delete the MCP package
ad201c4 
deleting this package. It was dever deployed but mostly because not quite sure MCP is the right approach. Antrhopic has had some doubts about their creation as well. see: https://www.anthropic.com/engineering/code-execution-with-mcp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@e111077