Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[lit-html] [wip] Reduce cache overhead of static templates. #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
bmeurer wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[lit-html] [wip] Reduce cache overhead of static templates. #1858

bmeurer wants to merge 2 commits into from

Conversation

@bmeurer
Copy link

@bmeurer bmeurer commented May 7, 2021

Following up on comments in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2876969 here's a proof-of-concept to reduce the performance overhead of using static.ts

The major issue that seems to stand out still is the tests for _$litStatic$ which are going to pollute the engine's ICs. I'd suggest to maybe go with a WeakMap / WeakSet approach here instead.

cc @paullewis

@bmeurer bmeurer requested a review from justinfagnani as a code owner May 7, 2021 14:01
@google-cla google-cla bot added the cla: yes label May 7, 2021
@justinfagnani justinfagnani changed the title [wip] Reduce cache overhead of static templates. [lit-html] [wip] Reduce cache overhead of static templates. May 7, 2021
@augustjk augustjk mentioned this pull request Jan 10, 2024
Open
1 task
@bmeurer bmeurer requested a review from kevinpschaaf as a code owner January 10, 2024 02:20
@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2024

⚠️ No Changeset found

Latest commit: 121620b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +2% (-0.72ms - +0.25ms)
    this-change vs tip-of-tree

render

  • this-change: 47.45ms - 49.34ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +4% (-0.55ms - +0.69ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +2% (-0.86ms - +0.56ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.38ms - +0.88ms)
    this-change vs tip-of-tree

update

  • this-change: 499.18ms - 509.22ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +8% (-2.03ms - +3.03ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +2% (-1.89ms - +1.57ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-6.23ms - +6.97ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 502.52ms - 510.82ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-7.58ms - +5.29ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
47.45ms - 49.34ms-

update

VersionAvg timevs
499.18ms - 509.22ms-

update-reflect

VersionAvg timevs
502.52ms - 510.82ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.20ms - 19.09ms-unsure 🔍
-3% - +4%
-0.55ms - +0.69ms		unsure 🔍
-4% - +3%
-0.82ms - +0.49ms
tip-of-tree
tip-of-tree		18.14ms - 19.01msunsure 🔍
-4% - +3%
-0.69ms - +0.55ms		-unsure 🔍
-5% - +2%
-0.88ms - +0.42ms
previous-release
previous-release		18.32ms - 19.29msunsure 🔍
-3% - +4%
-0.49ms - +0.82ms		unsure 🔍
-2% - +5%
-0.42ms - +0.88ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
38.51ms - 42.01ms-unsure 🔍
-5% - +8%
-2.03ms - +3.03ms		unsure 🔍
-1% - +11%
-0.41ms - +4.12ms
tip-of-tree
tip-of-tree		37.94ms - 41.58msunsure 🔍
-7% - +5%
-3.03ms - +2.03ms		-unsure 🔍
-3% - +10%
-0.96ms - +3.67ms
previous-release
previous-release		36.98ms - 39.84msunsure 🔍
-10% - +1%
-4.12ms - +0.41ms		unsure 🔍
-9% - +2%
-3.67ms - +0.96ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
10.86ms - 11.62ms-unsure 🔍
-6% - +2%
-0.72ms - +0.25ms		unsure 🔍
-3% - +6%
-0.31ms - +0.68ms
tip-of-tree
tip-of-tree		11.18ms - 11.78msunsure 🔍
-2% - +6%
-0.25ms - +0.72ms		-unsure 🔍
-0% - +8%
-0.01ms - +0.86ms
previous-release
previous-release		10.74ms - 11.37msunsure 🔍
-6% - +3%
-0.68ms - +0.31ms		unsure 🔍
-7% - +0%
-0.86ms - +0.01ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
32.86ms - 33.85ms-unsure 🔍
-3% - +2%
-0.86ms - +0.56ms		unsure 🔍
-2% - +2%
-0.79ms - +0.54ms
tip-of-tree
tip-of-tree		33.00ms - 34.01msunsure 🔍
-2% - +3%
-0.56ms - +0.86ms		-unsure 🔍
-2% - +2%
-0.65ms - +0.69ms
previous-release
previous-release		33.04ms - 33.92msunsure 🔍
-2% - +2%
-0.54ms - +0.79ms		unsure 🔍
-2% - +2%
-0.69ms - +0.65ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
69.00ms - 71.56ms-unsure 🔍
-3% - +2%
-1.89ms - +1.57ms		unsure 🔍
-4% - +1%
-2.83ms - +0.91ms
tip-of-tree
tip-of-tree		69.27ms - 71.60msunsure 🔍
-2% - +3%
-1.57ms - +1.89ms		-unsure 🔍
-4% - +1%
-2.60ms - +0.99ms
previous-release
previous-release		69.87ms - 72.61msunsure 🔍
-1% - +4%
-0.91ms - +2.83ms		unsure 🔍
-1% - +4%
-0.99ms - +2.60ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
32.86ms - 33.76ms-unsure 🔍
-1% - +3%
-0.38ms - +0.88ms		unsure 🔍
-1% - +3%
-0.17ms - +1.03ms
tip-of-tree
tip-of-tree		32.62ms - 33.50msunsure 🔍
-3% - +1%
-0.88ms - +0.38ms		-unsure 🔍
-1% - +2%
-0.41ms - +0.77ms
previous-release
previous-release		32.49ms - 33.27msunsure 🔍
-3% - +0%
-1.03ms - +0.17ms		unsure 🔍
-2% - +1%
-0.77ms - +0.41ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
505.84ms - 515.42ms-unsure 🔍
-1% - +1%
-6.23ms - +6.97ms		unsure 🔍
-1% - +2%
-3.68ms - +8.68ms
tip-of-tree
tip-of-tree		505.72ms - 514.81msunsure 🔍
-1% - +1%
-6.97ms - +6.23ms		-unsure 🔍
-1% - +2%
-3.86ms - +8.12ms
previous-release
previous-release		504.23ms - 512.04msunsure 🔍
-2% - +1%
-8.68ms - +3.68ms		unsure 🔍
-2% - +1%
-8.12ms - +3.86ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
508.47ms - 517.85ms-unsure 🔍
-1% - +1%
-7.58ms - +5.29ms		unsure 🔍
-2% - +1%
-8.75ms - +5.43ms
tip-of-tree
tip-of-tree		509.90ms - 518.72msunsure 🔍
-1% - +1%
-5.29ms - +7.58ms		-unsure 🔍
-1% - +1%
-7.43ms - +6.40ms
previous-release
previous-release		509.50ms - 520.15msunsure 🔍
-1% - +2%
-5.43ms - +8.75ms		unsure 🔍
-1% - +1%
-6.40ms - +7.43ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024

The size of lit-html.js and lit-core.min.js are as expected.

@augustjk
Copy link
Member

augustjk commented Jan 10, 2024 •
edited
Loading

Merged in current main, resolving conflicts. Seems like this implementation is failing stability checks when using same tag name, e.g.

lit/packages/lit-html/src/test/static_test.ts

Lines 95 to 96 in 5c8b142

// Static values are stable between renders like static template strings
assert.strictEqual(div2, div);

We also need a static focused benchmark to gauge performance..

@justinfagnani justinfagnani marked this pull request as draft February 12, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bmeurer @augustjk