Remove reference to LitElement in lit-labs/motion #2239

alfonsogarciacaro · 2021-10-11T22:09:40Z

The animate controller should be compatible with any component implementing ReactiveControllerHost not only LitElement, see #2197

changeset-bot · 2021-10-11T22:09:42Z

🦋 Changeset detected

Latest commit: d21bc4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/motion	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

leolorenzoluis · 2022-08-17T03:30:52Z

@justinfagnani Thoughts?

aomarks · 2022-08-18T00:58:31Z

cc @sorvell

justinfagnani · 2022-08-18T16:00:04Z

I'm mostly ok with this. My one concern is that we don't find a need for having a LitElement host in the future.

(edit: oops, this requires a ReactiveControllerHost)

OnurGumus · 2023-01-14T04:59:03Z

Any updates for this?

github-actions · 2024-01-12T02:25:43Z

📊 Tachometer Benchmark Results

Summary

nop-update

this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +5% (-0.49ms - +0.57ms)
^{this-change vs tip-of-tree}

render

this-change: 47.54ms - 50.02ms
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +7% (-0.32ms - +1.37ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +4% (-0.23ms - +1.32ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.62ms - +0.73ms)
^{this-change vs tip-of-tree}

update

this-change: 505.23ms - 517.54ms
this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +8% (-2.00ms - +3.03ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-0.95ms - +1.43ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-7.45ms - +4.83ms)
^{this-change vs tip-of-tree}

update-reflect

this-change: 506.47ms - 522.52ms
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +0% (-8.77ms - +2.54ms)
^{this-change vs tip-of-tree}

Results

this-change

Browser: chrome-headless 120.0.6099.199
Sample size: 50
Built by: Benchmarks #6000
Commit: d21bc4b

render

Version	Avg time	vs
	47.54ms - 50.02ms	-

update

Version	Avg time	vs
	505.23ms - 517.54ms	-

update-reflect

Version	Avg time	vs
	506.47ms - 522.52ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 120.0.6099.199
Sample size: 30
Built by: Benchmarks #6000
Commit: d21bc4b

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	18.55ms - 19.99ms	-	unsure 🔍 -2% - +7% -0.32ms - +1.37ms	unsure 🔍 -3% - +6% -0.62ms - +1.19ms
tip-of-tree tip-of-tree	18.30ms - 19.19ms	unsure 🔍 -7% - +2% -1.37ms - +0.32ms	-	unsure 🔍 -5% - +2% -0.95ms - +0.47ms
previous-release previous-release	18.43ms - 19.54ms	unsure 🔍 -6% - +3% -1.19ms - +0.62ms	unsure 🔍 -3% - +5% -0.47ms - +0.95ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	38.78ms - 42.48ms	-	unsure 🔍 -5% - +8% -2.00ms - +3.03ms	unsure 🔍 -5% - +7% -2.17ms - +2.95ms
tip-of-tree tip-of-tree	38.41ms - 41.82ms	unsure 🔍 -7% - +5% -3.03ms - +2.00ms	-	unsure 🔍 -6% - +6% -2.58ms - +2.33ms
previous-release previous-release	38.47ms - 42.01ms	unsure 🔍 -7% - +5% -2.95ms - +2.17ms	unsure 🔍 -6% - +6% -2.33ms - +2.58ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.99ms - 11.81ms	-	unsure 🔍 -4% - +5% -0.49ms - +0.57ms	unsure 🔍 -5% - +4% -0.63ms - +0.41ms
tip-of-tree tip-of-tree	11.03ms - 11.69ms	unsure 🔍 -5% - +4% -0.57ms - +0.49ms	-	unsure 🔍 -5% - +3% -0.61ms - +0.32ms
previous-release previous-release	11.18ms - 11.83ms	unsure 🔍 -4% - +6% -0.41ms - +0.63ms	unsure 🔍 -3% - +5% -0.32ms - +0.61ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 120.0.6099.199
Sample size: 50
Built by: Benchmarks #6000
Commit: d21bc4b

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	33.15ms - 34.47ms	-	unsure 🔍 -1% - +4% -0.23ms - +1.32ms	unsure 🔍 -2% - +3% -0.73ms - +0.88ms
tip-of-tree tip-of-tree	32.86ms - 33.67ms	unsure 🔍 -4% - +1% -1.32ms - +0.23ms	-	unsure 🔍 -3% - +0% -1.08ms - +0.14ms
previous-release previous-release	33.28ms - 34.19ms	unsure 🔍 -3% - +2% -0.88ms - +0.73ms	unsure 🔍 -0% - +3% -0.14ms - +1.08ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	68.04ms - 70.01ms	-	unsure 🔍 -1% - +2% -0.95ms - +1.43ms	unsure 🔍 -3% - +1% -1.81ms - +0.91ms
tip-of-tree tip-of-tree	68.13ms - 69.45ms	unsure 🔍 -2% - +1% -1.43ms - +0.95ms	-	unsure 🔍 -3% - +1% -1.84ms - +0.46ms
previous-release previous-release	68.54ms - 70.41ms	unsure 🔍 -1% - +3% -0.91ms - +1.81ms	unsure 🔍 -1% - +3% -0.46ms - +1.84ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 120.0.6099.199
Sample size: 50
Built by: Benchmarks #6000
Commit: d21bc4b

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	33.17ms - 34.17ms	-	unsure 🔍 -2% - +2% -0.62ms - +0.73ms	unsure 🔍 -2% - +2% -0.65ms - +0.67ms
tip-of-tree tip-of-tree	33.17ms - 34.07ms	unsure 🔍 -2% - +2% -0.73ms - +0.62ms	-	unsure 🔍 -2% - +2% -0.67ms - +0.59ms
previous-release previous-release	33.23ms - 34.10ms	unsure 🔍 -2% - +2% -0.67ms - +0.65ms	unsure 🔍 -2% - +2% -0.59ms - +0.67ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	527.50ms - 535.81ms	-	unsure 🔍 -1% - +1% -7.45ms - +4.83ms	unsure 🔍 -1% - +1% -6.69ms - +5.16ms
tip-of-tree tip-of-tree	528.45ms - 537.48ms	unsure 🔍 -1% - +1% -4.83ms - +7.45ms	-	unsure 🔍 -1% - +1% -5.63ms - +6.72ms
previous-release previous-release	528.20ms - 536.64ms	unsure 🔍 -1% - +1% -5.16ms - +6.69ms	unsure 🔍 -1% - +1% -6.72ms - +5.63ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	535.64ms - 543.18ms	-	unsure 🔍 -2% - +0% -8.77ms - +2.54ms	unsure 🔍 -1% - +1% -5.37ms - +5.68ms
tip-of-tree tip-of-tree	538.31ms - 546.74ms	unsure 🔍 -0% - +2% -2.54ms - +8.77ms	-	unsure 🔍 -0% - +2% -2.57ms - +9.12ms
previous-release previous-release	535.21ms - 543.30ms	unsure 🔍 -1% - +1% -5.68ms - +5.37ms	unsure 🔍 -2% - +0% -9.12ms - +2.57ms	-

_{tachometer-reporter-action v2 for Benchmarks}

augustjk

Sorry for taking so long to get to this. The changes here make sense.
I rebased to current main, resolving conflict, and added a changeset.
Thank you very much for the contribution!

github-actions · 2024-01-12T02:27:25Z

The size of lit-html.js and lit-core.min.js are as expected.

alfonsogarciacaro requested a review from justinfagnani as a code owner October 11, 2021 22:09

google-cla bot added the cla: yes label Oct 11, 2021

alfonsogarciacaro mentioned this pull request Oct 11, 2021

[labs/motion] Add meaningful error when not used on LitElement #2197

Closed

alfonsogarciacaro mentioned this pull request Jul 11, 2022

LitLabs.motion.animate() throws an error fable-compiler/Fable.Lit#53

Open

aomarks requested a review from sorvell August 18, 2022 00:58

This comment was marked as off-topic.

Sign in to view

alfonsogarciacaro and others added 2 commits January 11, 2024 18:07

Remove reference to LitElement in lit-labs/motion

0d49e89

Add changeset

d21bc4b

augustjk force-pushed the patch-3 branch from 1a4da95 to d21bc4b Compare January 12, 2024 02:25

alfonsogarciacaro requested a review from kevinpschaaf as a code owner January 12, 2024 02:25

augustjk approved these changes Jan 12, 2024

View reviewed changes

augustjk merged commit 851334c into lit:main Jan 12, 2024

lit-robot mentioned this pull request Jan 31, 2024

Version Packages #4532

Merged

Remove reference to LitElement in lit-labs/motion #2239

Remove reference to LitElement in lit-labs/motion #2239

Uh oh!

Conversation

alfonsogarciacaro commented Oct 11, 2021

Uh oh!

changeset-bot bot commented Oct 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

leolorenzoluis commented Aug 17, 2022

Uh oh!

aomarks commented Aug 18, 2022

Uh oh!

This comment was marked as off-topic.

justinfagnani commented Aug 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OnurGumus commented Jan 14, 2023

Uh oh!

github-actions bot commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

Uh oh!

augustjk left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

changeset-bot bot commented Oct 11, 2021 •

edited

Loading

justinfagnani commented Aug 18, 2022 •

edited

Loading

github-actions bot commented Jan 12, 2024 •

edited

Loading