-
Notifications
You must be signed in to change notification settings - Fork 1k
[labs/motion] Add Spring and Spring2D controllers #2261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 4b07938 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Results⏱ lit-element-list
render
update
update-reflect
⏱ lit-html-kitchen-sink
render
update
nop-update
⏱ lit-html-repeat
render
update
⏱ lit-html-template-heavy
render
update
⏱ reactive-element-list
render
update
update-reflect
this-change
render
update
update-reflect
this-change, tip-of-tree, previous-release
render
update
nop-update
this-change, tip-of-tree, previous-release
render
update
this-change, tip-of-tree, previous-release
render
update
update-reflect
|
d6ddb28 to
a7205c8
Compare
AndrewJakubowicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing domain knowledge so did a syntax and manual test code review.
The demo is so amazing. Otherwise very minor nits and clarifications mostly for my own understanding. This is great!
From an API standpoint my only question is around integration with animate() directive. I ask this as an alternative to needing to supply a styleMap directive for the spring. Non blocking.
Great stuff!
|
@AndrewJakubowicz thanks for the review from so long ago! I addressed you comments and then rebased onto the 3.0 branch. I have one important change I want to make to the 2D controller before I think this is mergable. |
|
Very cool controller and demo! Code looks great. Documentation is thorough enough that I could confidently use the controller. |
AndrewJakubowicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Proposed some simplifications to the demo styles.
Also I think I'd prefer we use the scalar name speed instead of velocity when in 2d since I think that's what is currently being calculated.
|
The size of lit-html.js and lit-core.min.js are as expected. |
Adds
SpringControllerandSpringController2Dthat you can use to simulate springs that drive host updates, like so: