Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[starter-kits] Fix starter kits so npm run serve isn't npm run docs:serve #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewJakubowicz merged 3 commits into from
Nov 13, 2021
Merged

[starter-kits] Fix starter kits so npm run serve isn't npm run docs:serve #2300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a084f5
Fix starter kits so you can access your component with serve command
AndrewJakubowicz Nov 12, 2021
569dbef
Add something on root url, so that folks dont get a 404.
AndrewJakubowicz Nov 13, 2021
b4df07c
Add patch changeset
AndrewJakubowicz Nov 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/metal-news-sin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@lit/lit-starter-js': patch
'@lit/lit-starter-ts': patch
---

Fix starter kits so `npm run serve` serves the root directory, and add a link to the `/dev/index.html` component example from `/`.
11 changes: 11 additions & 0 deletions packages/lit-starter-js/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>

<html>
<head>
<meta charset="utf-8" />
<title>Lit Starter Kit</title>
</head>
<body>
<a href="/dev/index.html">Component Demo</a>
</body>
</html>
1 change: 0 additions & 1 deletion packages/lit-starter-js/web-dev-server.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ if (!['dev', 'prod'].includes(mode)) {
export default {
nodeResolve: {exportConditions: mode === 'dev' ? ['development'] : []},
preserveSymlinks: true,
rootDir: 'docs',
plugins: [
legacyPlugin({
polyfills: {
Expand Down
11 changes: 11 additions & 0 deletions packages/lit-starter-ts/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>

<html>
<head>
<meta charset="utf-8" />
<title>Lit Starter Kit</title>
</head>
<body>
<a href="/dev/index.html">Component Demo</a>
</body>
</html>
1 change: 0 additions & 1 deletion packages/lit-starter-ts/web-dev-server.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ if (!['dev', 'prod'].includes(mode)) {
export default {
nodeResolve: {exportConditions: mode === 'dev' ? ['development'] : []},
preserveSymlinks: true,
rootDir: 'docs',
plugins: [
legacyPlugin({
polyfills: {
Expand Down