Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test(ssr): add element reflecting prop tests #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
e111077 merged 2 commits into from
Dec 3, 2021
Merged

test(ssr): add element reflecting prop tests #2334

e111077 merged 2 commits into from
Dec 3, 2021

Conversation

@e111077
Copy link
Contributor

@e111077 e111077 commented Dec 3, 2021 •
edited
Loading

added tests to lit-ssr that check that reflected properties are actually rendering correctly

related #2305

@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 8e73753

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Dec 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -4% - +2% (-1.37ms - +0.63ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -1% - +4% (-0.83ms - +3.28ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -1% - +7% (-0.55ms - +2.58ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -6% - +3% (-0.73ms - +0.37ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -5% - +1% (-2.95ms - +0.67ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -4% - +2% (-2.34ms - +1.13ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -2% - +2% (-19.47ms - +15.86ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -4% - +3% (-3.77ms - +3.54ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -5% - +2% (-16.11ms - +5.25ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -4% - +2% (-5.39ms - +2.93ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +2% (-19.99ms - +13.14ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -2% - +1% (-23.60ms - +12.16ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +3% (-14.08ms - +24.15ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
88.16ms - 91.62ms-unsure 🔍
-1% - +4%
-0.83ms - +3.28ms		faster ✔
21% - 25%
24.78ms - 30.20ms
tip-of-tree
tip-of-tree		87.56ms - 89.77msunsure 🔍
-4% - +1%
-3.28ms - +0.83ms		-faster ✔
23% - 26%
26.36ms - 31.07ms
previous-release
previous-release		115.30ms - 119.47msslower ❌
27% - 34%
24.78ms - 30.20ms		slower ❌
30% - 35%
26.36ms - 31.07ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
846.85ms - 872.87ms-unsure 🔍
-2% - +2%
-19.47ms - +15.86ms		faster ✔
7% - 11%
61.21ms - 99.78ms
tip-of-tree
tip-of-tree		849.72ms - 873.62msunsure 🔍
-2% - +2%
-15.86ms - +19.47ms		-faster ✔
6% - 10%
60.11ms - 97.28ms
previous-release
previous-release		926.13ms - 954.59msslower ❌
7% - 12%
61.21ms - 99.78ms		slower ❌
7% - 11%
60.11ms - 97.28ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
927.88ms - 952.93ms-unsure 🔍
-2% - +1%
-23.60ms - +12.16ms		faster ✔
3% - 6%
27.63ms - 62.60ms
tip-of-tree
tip-of-tree		933.36ms - 958.88msunsure 🔍
-1% - +3%
-12.16ms - +23.60ms		-faster ✔
2% - 6%
21.74ms - 57.04ms
previous-release
previous-release		973.31ms - 997.71msslower ❌
3% - 7%
27.63ms - 62.60ms		slower ❌
2% - 6%
21.74ms - 57.04ms		-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
38.42ms - 40.83ms-unsure 🔍
-1% - +7%
-0.55ms - +2.58ms		faster ✔
8% - 15%
3.49ms - 6.80ms
tip-of-tree
tip-of-tree		37.61ms - 39.61msunsure 🔍
-6% - +1%
-2.58ms - +0.55ms		-faster ✔
11% - 17%
4.65ms - 7.67ms
previous-release
previous-release		43.64ms - 45.91msslower ❌
9% - 17%
3.49ms - 6.80ms		slower ❌
12% - 20%
4.65ms - 7.67ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
101.34ms - 105.89ms-unsure 🔍
-4% - +3%
-3.77ms - +3.54ms		faster ✔
1% - 8%
0.68ms - 8.61ms
tip-of-tree
tip-of-tree		100.87ms - 106.59msunsure 🔍
-3% - +4%
-3.54ms - +3.77ms		-faster ✔
0% - 8%
0.21ms - 8.85ms
previous-release
previous-release		105.02ms - 111.50msslower ❌
1% - 8%
0.68ms - 8.61ms		slower ❌
0% - 9%
0.21ms - 8.85ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
29.18ms - 30.63ms-unsure 🔍
-4% - +2%
-1.37ms - +0.63ms		faster ✔
8% - 15%
2.64ms - 5.08ms
tip-of-tree
tip-of-tree		29.58ms - 30.96msunsure 🔍
-2% - +5%
-0.63ms - +1.37ms		-faster ✔
7% - 14%
2.30ms - 4.69ms
previous-release
previous-release		32.79ms - 34.74msslower ❌
9% - 17%
2.64ms - 5.08ms		slower ❌
7% - 16%
2.30ms - 4.69ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
12.34ms - 13.12ms-unsure 🔍
-6% - +3%
-0.73ms - +0.37ms		faster ✔
3% - 11%
0.43ms - 1.57ms
tip-of-tree
tip-of-tree		12.52ms - 13.29msunsure 🔍
-3% - +6%
-0.37ms - +0.73ms		-faster ✔
2% - 10%
0.26ms - 1.39ms
previous-release
previous-release		13.31ms - 14.14msslower ❌
3% - 13%
0.43ms - 1.57ms		slower ❌
2% - 11%
0.26ms - 1.39ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
309.14ms - 320.88ms-unsure 🔍
-5% - +2%
-16.11ms - +5.25ms		faster ✔
33% - 37%
156.05ms - 178.92ms
tip-of-tree
tip-of-tree		311.52ms - 329.37msunsure 🔍
-2% - +5%
-5.25ms - +16.11ms		-faster ✔
31% - 36%
148.79ms - 175.31ms
previous-release
previous-release		472.68ms - 492.30msslower ❌
49% - 57%
156.05ms - 178.92ms		slower ❌
45% - 56%
148.79ms - 175.31ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
58.67ms - 60.92ms-unsure 🔍
-5% - +1%
-2.95ms - +0.67ms		faster ✔
16% - 21%
11.78ms - 15.62ms
tip-of-tree
tip-of-tree		59.52ms - 62.35msunsure 🔍
-1% - +5%
-0.67ms - +2.95ms		-faster ✔
14% - 20%
10.46ms - 14.66ms
previous-release
previous-release		71.94ms - 75.04msslower ❌
19% - 26%
11.78ms - 15.62ms		slower ❌
17% - 24%
10.46ms - 14.66ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
128.25ms - 134.11ms-unsure 🔍
-4% - +2%
-5.39ms - +2.93ms		faster ✔
12% - 18%
17.73ms - 28.02ms
tip-of-tree
tip-of-tree		129.46ms - 135.36msunsure 🔍
-2% - +4%
-2.93ms - +5.39ms		-faster ✔
11% - 17%
16.49ms - 26.80ms
previous-release
previous-release		149.83ms - 158.28msslower ❌
13% - 22%
17.73ms - 28.02ms		slower ❌
12% - 20%
16.49ms - 26.80ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
64.29ms - 66.85ms-unsure 🔍
-4% - +2%
-2.34ms - +1.13ms		unsure 🔍
-2% - +4%
-1.15ms - +2.39ms
tip-of-tree
tip-of-tree		65.01ms - 67.35msunsure 🔍
-2% - +4%
-1.13ms - +2.34ms		-unsure 🔍
-1% - +5%
-0.47ms - +2.92ms
previous-release
previous-release		63.73ms - 66.18msunsure 🔍
-4% - +2%
-2.39ms - +1.15ms		unsure 🔍
-4% - +1%
-2.92ms - +0.47ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
835.84ms - 857.86ms-unsure 🔍
-2% - +2%
-19.99ms - +13.14ms		unsure 🔍
-2% - +1%
-17.80ms - +11.63ms
tip-of-tree
tip-of-tree		837.90ms - 862.66msunsure 🔍
-2% - +2%
-13.14ms - +19.99ms		-unsure 🔍
-2% - +2%
-15.43ms - +16.11ms
previous-release
previous-release		840.17ms - 859.70msunsure 🔍
-1% - +2%
-11.63ms - +17.80ms		unsure 🔍
-2% - +2%
-16.11ms - +15.43ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
940.20ms - 968.44ms-unsure 🔍
-1% - +3%
-14.08ms - +24.15ms		unsure 🔍
-2% - +1%
-23.03ms - +11.47ms
tip-of-tree
tip-of-tree		936.40ms - 962.17msunsure 🔍
-3% - +1%
-24.15ms - +14.08ms		-unsure 🔍
-3% - +1%
-27.08ms - +5.44ms
previous-release
previous-release		950.19ms - 970.01msunsure 🔍
-1% - +2%
-11.47ms - +23.03ms		unsure 🔍
-1% - +3%
-5.44ms - +27.08ms		-

tachometer-reporter-action v2 for Benchmarks

@e111077 e111077 merged commit 93d8751 into main Dec 3, 2021
@e111077 e111077 deleted the test-reflected-ssr branch December 3, 2021 22:16
This was referenced Jan 5, 2022
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 16, 2022
Open
@tjenkinson tjenkinson mentioned this pull request Sep 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@e111077 @justinfagnani