Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/router] Add labs/router package scaffolding #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 3 commits into from
Dec 2, 2021
Merged

[labs/router] Add labs/router package scaffolding #2330

justinfagnani merged 3 commits into from
Dec 2, 2021

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Dec 1, 2021

This includes no design doc or implementation yet. Those will be added later.

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: b35705a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Dec 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -7% - +3% (-2.32ms - +1.10ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -3% - +5% (-3.33ms - +5.01ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -4% - +4% (-1.75ms - +1.80ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -8% - +3% (-1.02ms - +0.46ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +4% (-2.09ms - +2.65ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -6% - +2% (-4.29ms - +1.78ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -4% - +3% (-37.13ms - +32.87ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -6% - +4% (-6.69ms - +4.80ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -6% - +8% (-18.88ms - +25.21ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +5% (-3.24ms - +7.77ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -5% - +4% (-45.67ms - +37.35ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -3% - +5% (-30.86ms - +49.64ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +5% (-33.11ms - +51.21ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
96.17ms - 101.76ms-unsure 🔍
-3% - +5%
-3.33ms - +5.01ms		faster ✔
16% - 22%
19.57ms - 27.53ms
tip-of-tree
tip-of-tree		95.03ms - 101.22msunsure 🔍
-5% - +3%
-5.01ms - +3.33ms		-faster ✔
17% - 23%
20.20ms - 28.60ms
previous-release
previous-release		119.68ms - 125.36msslower ❌
19% - 28%
19.57ms - 27.53ms		slower ❌
20% - 30%
20.20ms - 28.60ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
912.68ms - 959.71ms-unsure 🔍
-4% - +3%
-37.13ms - +32.87ms		faster ✔
4% - 11%
41.77ms - 112.08ms
tip-of-tree
tip-of-tree		912.40ms - 964.24msunsure 🔍
-4% - +4%
-32.87ms - +37.13ms		-faster ✔
4% - 11%
37.99ms - 111.61ms
previous-release
previous-release		986.99ms - 1039.26msslower ❌
4% - 12%
41.77ms - 112.08ms		slower ❌
4% - 12%
37.99ms - 111.61ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1009.02ms - 1062.46ms-unsure 🔍
-3% - +5%
-30.86ms - +49.64ms		faster ✔
1% - 8%
12.02ms - 90.03ms
tip-of-tree
tip-of-tree		996.25ms - 1056.46msunsure 🔍
-5% - +3%
-49.64ms - +30.86ms		-faster ✔
2% - 9%
19.02ms - 101.81ms
previous-release
previous-release		1058.35ms - 1115.19msslower ❌
1% - 9%
12.02ms - 90.03ms		slower ❌
2% - 10%
19.02ms - 101.81ms		-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
41.02ms - 43.08ms-unsure 🔍
-4% - +4%
-1.75ms - +1.80ms		faster ✔
10% - 15%
4.51ms - 7.42ms
tip-of-tree
tip-of-tree		40.58ms - 43.47msunsure 🔍
-4% - +4%
-1.80ms - +1.75ms		-faster ✔
9% - 16%
4.22ms - 7.76ms
previous-release
previous-release		46.99ms - 49.04msslower ❌
10% - 18%
4.51ms - 7.42ms		slower ❌
10% - 19%
4.22ms - 7.76ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
109.59ms - 117.97ms-unsure 🔍
-6% - +4%
-6.69ms - +4.80ms		unsure 🔍
-7% - +2%
-8.70ms - +2.17ms
tip-of-tree
tip-of-tree		110.79ms - 118.65msunsure 🔍
-4% - +6%
-4.80ms - +6.69ms		-unsure 🔍
-6% - +2%
-7.55ms - +2.91ms
previous-release
previous-release		113.59ms - 120.50msunsure 🔍
-2% - +8%
-2.17ms - +8.70ms		unsure 🔍
-3% - +7%
-2.91ms - +7.55ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
32.97ms - 35.34ms-unsure 🔍
-7% - +3%
-2.32ms - +1.10ms		faster ✔
8% - 15%
2.86ms - 5.79ms
tip-of-tree
tip-of-tree		33.53ms - 36.00msunsure 🔍
-3% - +7%
-1.10ms - +2.32ms		-faster ✔
6% - 13%
2.20ms - 5.22ms
previous-release
previous-release		37.61ms - 39.35msslower ❌
8% - 17%
2.86ms - 5.79ms		slower ❌
6% - 15%
2.20ms - 5.22ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
12.30ms - 13.33ms-unsure 🔍
-8% - +3%
-1.02ms - +0.46ms		faster ✔
5% - 14%
0.64ms - 2.06ms
tip-of-tree
tip-of-tree		12.56ms - 13.63msunsure 🔍
-4% - +8%
-0.46ms - +1.02ms		-faster ✔
3% - 13%
0.34ms - 1.80ms
previous-release
previous-release		13.68ms - 14.66msslower ❌
5% - 16%
0.64ms - 2.06ms		slower ❌
2% - 14%
0.34ms - 1.80ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
318.48ms - 356.19ms-unsure 🔍
-6% - +8%
-18.88ms - +25.21ms		faster ✔
29% - 39%
143.26ms - 204.62ms
tip-of-tree
tip-of-tree		322.74ms - 345.59msunsure 🔍
-7% - +6%
-25.21ms - +18.88ms		-faster ✔
31% - 38%
150.35ms - 203.87ms
previous-release
previous-release		487.07ms - 535.47msslower ❌
40% - 63%
143.26ms - 204.62ms		slower ❌
44% - 62%
150.35ms - 203.87ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
65.15ms - 68.34ms-unsure 🔍
-3% - +4%
-2.09ms - +2.65ms		faster ✔
12% - 17%
9.30ms - 13.72ms
tip-of-tree
tip-of-tree		64.71ms - 68.22msunsure 🔍
-4% - +3%
-2.65ms - +2.09ms		-faster ✔
12% - 18%
9.46ms - 14.11ms
previous-release
previous-release		76.72ms - 79.78msslower ❌
14% - 21%
9.30ms - 13.72ms		slower ❌
14% - 22%
9.46ms - 14.11ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
146.47ms - 154.59ms-unsure 🔍
-2% - +5%
-3.24ms - +7.77ms		faster ✔
8% - 15%
13.99ms - 25.08ms
tip-of-tree
tip-of-tree		144.54ms - 151.99msunsure 🔍
-5% - +2%
-7.77ms - +3.24ms		-faster ✔
10% - 16%
16.49ms - 27.10ms
previous-release
previous-release		166.29ms - 173.84msslower ❌
9% - 17%
13.99ms - 25.08ms		slower ❌
11% - 19%
16.49ms - 27.10ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
67.04ms - 71.19ms-unsure 🔍
-6% - +2%
-4.29ms - +1.78ms		unsure 🔍
-5% - +4%
-3.17ms - +2.45ms
tip-of-tree
tip-of-tree		68.15ms - 72.59msunsure 🔍
-3% - +6%
-1.78ms - +4.29ms		-unsure 🔍
-3% - +6%
-2.02ms - +3.82ms
previous-release
previous-release		67.57ms - 71.37msunsure 🔍
-4% - +5%
-2.45ms - +3.17ms		unsure 🔍
-5% - +3%
-3.82ms - +2.02ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
951.34ms - 1011.02ms-unsure 🔍
-5% - +4%
-45.67ms - +37.35ms		unsure 🔍
-5% - +4%
-44.49ms - +40.86ms
tip-of-tree
tip-of-tree		956.49ms - 1014.19msunsure 🔍
-4% - +5%
-37.35ms - +45.67ms		-unsure 🔍
-4% - +5%
-39.64ms - +44.33ms
previous-release
previous-release		952.49ms - 1013.50msunsure 🔍
-4% - +5%
-40.86ms - +44.49ms		unsure 🔍
-4% - +4%
-44.33ms - +39.64ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1072.57ms - 1133.07ms-unsure 🔍
-3% - +5%
-33.11ms - +51.21ms		unsure 🔍
-4% - +5%
-38.38ms - +50.95ms
tip-of-tree
tip-of-tree		1064.41ms - 1123.14msunsure 🔍
-5% - +3%
-51.21ms - +33.11ms		-unsure 🔍
-4% - +4%
-46.84ms - +41.30ms
previous-release
previous-release		1063.68ms - 1129.40msunsure 🔍
-5% - +3%
-50.95ms - +38.38ms		unsure 🔍
-4% - +4%
-41.30ms - +46.84ms		-

tachometer-reporter-action v2 for Benchmarks

aomarks
aomarks approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@aomarks aomarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An excellent skeleton!

@justinfagnani justinfagnani merged commit 0cafad5 into main Dec 2, 2021
@justinfagnani justinfagnani deleted the router branch December 2, 2021 00:28
This was referenced Jan 5, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aomarks aomarks aomarks approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinfagnani @aomarks