[ssr] Demote some dependencies to devDependencies #2345

aomarks · 2021-12-08T20:40:54Z

Moves the following packages from dependencies to devDependencies: koa, koa-node-resolve, koa-static, @webcomponents/template-shadowroot, since they are only used in tests/demos.

The @webcomponents/template-shadowroot is something that users will probably actually want to install, but it seems like they should do that themselves rather than get it automatically when they install @lit-labs/ssr.

(Note some of the other churn in this PR is just sorting the deps)

Fixes #2339

changeset-bot · 2021-12-08T20:40:56Z

🦋 Changeset detected

Latest commit: 6bc5643

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2021-12-08T20:41:21Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: faster ✔ 1% - 7% (0.25ms - 2.23ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -2% - +3% (-1.63ms - +2.69ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -4% - +2% (-1.46ms - +0.69ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -2% - +4% (-0.32ms - +0.57ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +1% (-2.24ms - +0.37ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +2% (-0.99ms - +1.67ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -1% - +2% (-7.32ms - +15.98ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -3% - +3% (-3.31ms - +3.08ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +2% (-4.99ms - +7.46ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +1% (-4.66ms - +1.91ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +1% (-18.66ms - +7.27ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -1% - +2% (-5.88ms - +16.60ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +1% (-17.92ms - +8.46ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 96.0.4664.45
Sample size: 50
Built by: Benchmarks #2121
Commit: 3714735

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	92.49ms - 96.07ms	-	unsure 🔍 -2% - +3% -1.63ms - +2.69ms	faster ✔ 19% - 23% 22.77ms - 27.42ms
tip-of-tree tip-of-tree	92.54ms - 94.95ms	unsure 🔍 -3% - +2% -2.69ms - +1.63ms	-	faster ✔ 20% - 23% 23.71ms - 27.53ms
previous-release previous-release	117.89ms - 120.85ms	slower ❌ 24% - 29% 22.77ms - 27.42ms	slower ❌ 25% - 30% 23.71ms - 27.53ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	945.18ms - 961.62ms	-	unsure 🔍 -1% - +2% -7.32ms - +15.98ms	faster ✔ 7% - 9% 72.49ms - 95.23ms
tip-of-tree tip-of-tree	940.82ms - 957.32ms	unsure 🔍 -2% - +1% -15.98ms - +7.32ms	-	faster ✔ 7% - 10% 76.80ms - 99.59ms
previous-release previous-release	1029.40ms - 1045.12ms	slower ❌ 8% - 10% 72.49ms - 95.23ms	slower ❌ 8% - 11% 76.80ms - 99.59ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1044.05ms - 1060.24ms	-	unsure 🔍 -1% - +2% -5.88ms - +16.60ms	faster ✔ 4% - 6% 44.94ms - 68.22ms
tip-of-tree tip-of-tree	1038.99ms - 1054.58ms	unsure 🔍 -2% - +1% -16.60ms - +5.88ms	-	faster ✔ 5% - 7% 50.51ms - 73.37ms
previous-release previous-release	1100.36ms - 1117.08ms	slower ❌ 4% - 7% 44.94ms - 68.22ms	slower ❌ 5% - 7% 50.51ms - 73.37ms	-

lit-html-kitchen-sink

Browser: chrome-headless 96.0.4664.45
Sample size: 30
Built by: Benchmarks #2121
Commit: 3714735

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	36.97ms - 38.16ms	-	unsure 🔍 -4% - +2% -1.46ms - +0.69ms	faster ✔ 16% - 21% 7.31ms - 9.81ms
tip-of-tree tip-of-tree	37.05ms - 38.85ms	unsure 🔍 -2% - +4% -0.69ms - +1.46ms	-	faster ✔ 15% - 20% 6.75ms - 9.59ms
previous-release previous-release	45.02ms - 47.22ms	slower ❌ 19% - 26% 7.31ms - 9.81ms	slower ❌ 17% - 26% 6.75ms - 9.59ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	105.50ms - 109.76ms	-	unsure 🔍 -3% - +3% -3.31ms - +3.08ms	faster ✔ 1% - 7% 1.60ms - 8.15ms
tip-of-tree tip-of-tree	105.37ms - 110.12ms	unsure 🔍 -3% - +3% -3.08ms - +3.31ms	-	faster ✔ 1% - 7% 1.33ms - 8.20ms
previous-release previous-release	110.03ms - 114.99ms	slower ❌ 1% - 8% 1.60ms - 8.15ms	slower ❌ 1% - 8% 1.33ms - 8.20ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	32.01ms - 33.13ms	-	faster ✔ 1% - 7% 0.25ms - 2.23ms	faster ✔ 13% - 17% 4.90ms - 6.54ms
tip-of-tree tip-of-tree	32.99ms - 34.63ms	slower ❌ 1% - 7% 0.25ms - 2.23ms	-	faster ✔ 9% - 14% 3.47ms - 5.49ms
previous-release previous-release	37.70ms - 38.89ms	slower ❌ 15% - 20% 4.90ms - 6.54ms	slower ❌ 10% - 17% 3.47ms - 5.49ms	-

lit-html-repeat

Browser: chrome-headless 96.0.4664.45
Sample size: 30
Built by: Benchmarks #2121
Commit: 3714735

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	13.72ms - 14.32ms	-	unsure 🔍 -2% - +4% -0.32ms - +0.57ms	faster ✔ 5% - 11% 0.76ms - 1.65ms
tip-of-tree tip-of-tree	13.57ms - 14.22ms	unsure 🔍 -4% - +2% -0.57ms - +0.32ms	-	faster ✔ 6% - 12% 0.87ms - 1.80ms
previous-release previous-release	14.90ms - 15.56ms	slower ❌ 5% - 12% 0.76ms - 1.65ms	slower ❌ 6% - 13% 0.87ms - 1.80ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	386.04ms - 393.11ms	-	unsure 🔍 -1% - +2% -4.99ms - +7.46ms	faster ✔ 30% - 32% 167.70ms - 180.69ms
tip-of-tree tip-of-tree	383.21ms - 393.47ms	unsure 🔍 -2% - +1% -7.46ms - +4.99ms	-	faster ✔ 30% - 32% 167.94ms - 182.92ms
previous-release previous-release	558.32ms - 569.22ms	slower ❌ 43% - 47% 167.70ms - 180.69ms	slower ❌ 43% - 48% 167.94ms - 182.92ms	-

lit-html-template-heavy

Browser: chrome-headless 96.0.4664.45
Sample size: 50
Built by: Benchmarks #2121
Commit: 3714735

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	67.89ms - 69.51ms	-	unsure 🔍 -3% - +1% -2.24ms - +0.37ms	faster ✔ 17% - 20% 13.99ms - 17.33ms
tip-of-tree tip-of-tree	68.61ms - 70.66ms	unsure 🔍 -1% - +3% -0.37ms - +2.24ms	-	faster ✔ 16% - 19% 12.94ms - 16.52ms
previous-release previous-release	82.90ms - 85.83ms	slower ❌ 20% - 25% 13.99ms - 17.33ms	slower ❌ 18% - 24% 12.94ms - 16.52ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	155.04ms - 159.62ms	-	unsure 🔍 -3% - +1% -4.66ms - +1.91ms	faster ✔ 11% - 14% 19.33ms - 25.69ms
tip-of-tree tip-of-tree	156.35ms - 161.06ms	unsure 🔍 -1% - +3% -1.91ms - +4.66ms	-	faster ✔ 10% - 13% 17.92ms - 24.36ms
previous-release previous-release	177.64ms - 182.05ms	slower ❌ 12% - 16% 19.33ms - 25.69ms	slower ❌ 11% - 15% 17.92ms - 24.36ms	-

reactive-element-list

Browser: chrome-headless 96.0.4664.45
Sample size: 50
Built by: Benchmarks #2121
Commit: 3714735

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	66.37ms - 68.24ms	-	unsure 🔍 -1% - +2% -0.99ms - +1.67ms	unsure 🔍 -2% - +2% -1.27ms - +1.64ms
tip-of-tree tip-of-tree	66.02ms - 67.91ms	unsure 🔍 -2% - +1% -1.67ms - +0.99ms	-	unsure 🔍 -2% - +2% -1.62ms - +1.31ms
previous-release previous-release	66.00ms - 68.23ms	unsure 🔍 -2% - +2% -1.64ms - +1.27ms	unsure 🔍 -2% - +2% -1.31ms - +1.62ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	983.07ms - 1000.81ms	-	unsure 🔍 -2% - +1% -18.66ms - +7.27ms	unsure 🔍 -2% - +1% -18.20ms - +7.77ms
tip-of-tree tip-of-tree	988.18ms - 1007.09ms	unsure 🔍 -1% - +2% -7.27ms - +18.66ms	-	unsure 🔍 -1% - +1% -12.91ms - +13.88ms
previous-release previous-release	987.66ms - 1006.64ms	unsure 🔍 -1% - +2% -7.77ms - +18.20ms	unsure 🔍 -1% - +1% -13.88ms - +12.91ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1109.20ms - 1128.08ms	-	unsure 🔍 -2% - +1% -17.92ms - +8.46ms	unsure 🔍 -1% - +1% -13.32ms - +13.84ms
tip-of-tree tip-of-tree	1114.16ms - 1132.58ms	unsure 🔍 -1% - +2% -8.46ms - +17.92ms	-	unsure 🔍 -1% - +2% -8.43ms - +18.41ms
previous-release previous-release	1108.61ms - 1128.15ms	unsure 🔍 -1% - +1% -13.84ms - +13.32ms	unsure 🔍 -2% - +1% -18.41ms - +8.43ms	-

_{tachometer-reporter-action v2 for Benchmarks}

aomarks added 2 commits December 8, 2021 12:39

Demote some packages to devDependencies

cd03c8c

Add changeset

6bc5643

aomarks requested review from justinfagnani and kevinpschaaf December 8, 2021 20:40

justinfagnani approved these changes Dec 8, 2021

View reviewed changes

aomarks merged commit 4edf4f3 into main Dec 8, 2021

aomarks deleted the ssr-deps branch December 8, 2021 21:19

This was referenced Jan 5, 2022

Version Packages #2375

Closed

Version Packages #2377

Merged

snyk-bot mentioned this pull request Jan 16, 2022

[Snyk] Security upgrade marked from 0.3.12 to 4.0.10 tjenkinson/lit-html#17

Open

tjenkinson mentioned this pull request Sep 30, 2022

[Snyk] Fix for 11 vulnerabilities tjenkinson/lit-html#18

Open

[ssr] Demote some dependencies to devDependencies #2345

[ssr] Demote some dependencies to devDependencies #2345

Uh oh!

Conversation

aomarks commented Dec 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 8, 2021

🦋 Changeset detected

Uh oh!

github-actions bot commented Dec 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aomarks commented Dec 8, 2021 •

edited

Loading

github-actions bot commented Dec 8, 2021 •

edited

Loading