Set observers version to 0.0.0 so that changesets releases it as 1.0.0 #2376

aomarks · 2022-01-05T20:41:21Z

No description provided.

changeset-bot · 2022-01-05T20:41:23Z

⚠️ No Changeset found

Latest commit: b270fe6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2022-01-05T20:41:45Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -2% - +4% (-0.80ms - +1.52ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -0% - +3% (-0.31ms - +3.54ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -2% - +2% (-0.93ms - +0.76ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -3% - +5% (-0.48ms - +0.72ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +2% (-1.65ms - +1.24ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +2% (-1.12ms - +1.97ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -2% - +1% (-19.89ms - +13.48ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -2% - +4% (-2.57ms - +5.37ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -6% - +5% (-24.06ms - +21.34ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +1% (-3.80ms - +2.21ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +2% (-12.11ms - +23.52ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -2% - +1% (-24.71ms - +10.29ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +1% (-22.62ms - +14.45ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 96.0.4664.110
Sample size: 50
Built by: Benchmarks #2181
Commit: c48fece

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	108.40ms - 111.04ms	-	unsure 🔍 -0% - +3% -0.31ms - +3.54ms	faster ✔ 19% - 23% 26.72ms - 31.61ms
tip-of-tree tip-of-tree	106.71ms - 109.51ms	unsure 🔍 -3% - +0% -3.54ms - +0.31ms	-	faster ✔ 21% - 24% 28.29ms - 33.27ms
previous-release previous-release	136.83ms - 140.95ms	slower ❌ 24% - 29% 26.72ms - 31.61ms	slower ❌ 26% - 31% 28.29ms - 33.27ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1008.77ms - 1032.37ms	-	unsure 🔍 -2% - +1% -19.89ms - +13.48ms	faster ✔ 7% - 11% 82.24ms - 118.79ms
tip-of-tree tip-of-tree	1011.98ms - 1035.57ms	unsure 🔍 -1% - +2% -13.48ms - +19.89ms	-	faster ✔ 7% - 10% 79.04ms - 115.58ms
previous-release previous-release	1107.13ms - 1135.04ms	slower ❌ 8% - 12% 82.24ms - 118.79ms	slower ❌ 8% - 11% 79.04ms - 115.58ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1115.14ms - 1136.96ms	-	unsure 🔍 -2% - +1% -24.71ms - +10.29ms	faster ✔ 4% - 7% 50.38ms - 84.52ms
tip-of-tree tip-of-tree	1119.58ms - 1146.94ms	unsure 🔍 -1% - +2% -10.29ms - +24.71ms	-	faster ✔ 3% - 7% 41.29ms - 79.20ms
previous-release previous-release	1180.38ms - 1206.63ms	slower ❌ 4% - 8% 50.38ms - 84.52ms	slower ❌ 4% - 7% 41.29ms - 79.20ms	-

lit-html-kitchen-sink

Browser: chrome-headless 96.0.4664.110
Sample size: 30
Built by: Benchmarks #2181
Commit: c48fece

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	43.53ms - 44.74ms	-	unsure 🔍 -2% - +2% -0.93ms - +0.76ms	faster ✔ 12% - 16% 6.09ms - 8.04ms
tip-of-tree tip-of-tree	43.63ms - 44.82ms	unsure 🔍 -2% - +2% -0.76ms - +0.93ms	-	faster ✔ 12% - 15% 6.01ms - 7.95ms
previous-release previous-release	50.44ms - 51.97ms	slower ❌ 14% - 18% 6.09ms - 8.04ms	slower ❌ 13% - 18% 6.01ms - 7.95ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	119.32ms - 124.87ms	-	unsure 🔍 -2% - +4% -2.57ms - +5.37ms	unsure 🔍 -4% - +3% -5.16ms - +3.93ms
tip-of-tree tip-of-tree	117.85ms - 123.54ms	unsure 🔍 -4% - +2% -5.37ms - +2.57ms	-	unsure 🔍 -5% - +2% -6.59ms - +2.57ms
previous-release previous-release	119.11ms - 126.30ms	unsure 🔍 -3% - +4% -3.93ms - +5.16ms	unsure 🔍 -2% - +5% -2.57ms - +6.59ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	34.16ms - 35.72ms	-	unsure 🔍 -2% - +4% -0.80ms - +1.52ms	faster ✔ 7% - 13% 2.86ms - 5.03ms
tip-of-tree tip-of-tree	33.72ms - 35.44ms	unsure 🔍 -4% - +2% -1.52ms - +0.80ms	-	faster ✔ 8% - 14% 3.16ms - 5.45ms
previous-release previous-release	38.13ms - 39.64ms	slower ❌ 8% - 15% 2.86ms - 5.03ms	slower ❌ 9% - 16% 3.16ms - 5.45ms	-

lit-html-repeat

Browser: chrome-headless 96.0.4664.110
Sample size: 30
Built by: Benchmarks #2181
Commit: c48fece

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	14.87ms - 15.73ms	-	unsure 🔍 -3% - +5% -0.48ms - +0.72ms	faster ✔ 5% - 12% 0.78ms - 2.00ms
tip-of-tree tip-of-tree	14.76ms - 15.59ms	unsure 🔍 -5% - +3% -0.72ms - +0.48ms	-	faster ✔ 6% - 13% 0.91ms - 2.12ms
previous-release previous-release	16.25ms - 17.13ms	slower ❌ 5% - 13% 0.78ms - 2.00ms	slower ❌ 6% - 14% 0.91ms - 2.12ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	382.53ms - 411.77ms	-	unsure 🔍 -6% - +5% -24.06ms - +21.34ms	faster ✔ 29% - 35% 162.30ms - 210.74ms
tip-of-tree tip-of-tree	381.15ms - 415.87ms	unsure 🔍 -5% - +6% -21.34ms - +24.06ms	-	faster ✔ 28% - 35% 159.20ms - 211.12ms
previous-release previous-release	564.37ms - 602.98ms	slower ❌ 40% - 54% 162.30ms - 210.74ms	slower ❌ 38% - 54% 159.20ms - 211.12ms	-

lit-html-template-heavy

Browser: chrome-headless 96.0.4664.110
Sample size: 50
Built by: Benchmarks #2181
Commit: c48fece

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	69.74ms - 71.88ms	-	unsure 🔍 -2% - +2% -1.65ms - +1.24ms	faster ✔ 14% - 18% 12.04ms - 15.34ms
tip-of-tree tip-of-tree	70.05ms - 71.99ms	unsure 🔍 -2% - +2% -1.24ms - +1.65ms	-	faster ✔ 14% - 18% 11.89ms - 15.07ms
previous-release previous-release	83.24ms - 85.76ms	slower ❌ 17% - 22% 12.04ms - 15.34ms	slower ❌ 17% - 21% 11.89ms - 15.07ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	150.05ms - 154.19ms	-	unsure 🔍 -2% - +1% -3.80ms - +2.21ms	faster ✔ 12% - 15% 20.61ms - 27.20ms
tip-of-tree tip-of-tree	150.74ms - 155.09ms	unsure 🔍 -1% - +3% -2.21ms - +3.80ms	-	faster ✔ 11% - 15% 19.75ms - 26.47ms
previous-release previous-release	173.46ms - 178.59ms	slower ❌ 13% - 18% 20.61ms - 27.20ms	slower ❌ 13% - 17% 19.75ms - 26.47ms	-

reactive-element-list

Browser: chrome-headless 96.0.4664.110
Sample size: 50
Built by: Benchmarks #2181
Commit: c48fece

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	81.17ms - 83.18ms	-	unsure 🔍 -1% - +2% -1.12ms - +1.97ms	unsure 🔍 -1% - +2% -0.87ms - +1.83ms
tip-of-tree tip-of-tree	80.58ms - 82.93ms	unsure 🔍 -2% - +1% -1.97ms - +1.12ms	-	unsure 🔍 -2% - +2% -1.42ms - +1.54ms
previous-release previous-release	80.79ms - 82.60ms	unsure 🔍 -2% - +1% -1.83ms - +0.87ms	unsure 🔍 -2% - +2% -1.54ms - +1.42ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1066.29ms - 1090.34ms	-	unsure 🔍 -1% - +2% -12.11ms - +23.52ms	unsure 🔍 -1% - +2% -11.91ms - +23.75ms
tip-of-tree tip-of-tree	1059.47ms - 1085.75ms	unsure 🔍 -2% - +1% -23.52ms - +12.11ms	-	unsure 🔍 -2% - +2% -18.39ms - +18.82ms
previous-release previous-release	1059.23ms - 1085.56ms	unsure 🔍 -2% - +1% -23.75ms - +11.91ms	unsure 🔍 -2% - +2% -18.82ms - +18.39ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1175.19ms - 1201.07ms	-	unsure 🔍 -2% - +1% -22.62ms - +14.45ms	unsure 🔍 -2% - +1% -24.40ms - +11.21ms
tip-of-tree tip-of-tree	1178.94ms - 1205.49ms	unsure 🔍 -1% - +2% -14.45ms - +22.62ms	-	unsure 🔍 -2% - +1% -20.56ms - +15.53ms
previous-release previous-release	1182.50ms - 1206.96ms	unsure 🔍 -1% - +2% -11.21ms - +24.40ms	unsure 🔍 -1% - +2% -15.53ms - +20.56ms	-

_{tachometer-reporter-action v2 for Benchmarks}

bicknellr

This hasn't been pushed to npm before so LGTM.

Set observers version to 0.0.0 so that changesets releases it as 1.0.0

b270fe6

aomarks requested review from bicknellr and sorvell January 5, 2022 20:41

aomarks requested a review from justinfagnani as a code owner January 5, 2022 20:41

bicknellr approved these changes Jan 5, 2022

View reviewed changes

aomarks mentioned this pull request Jan 5, 2022

Version Packages #2375

Closed

aomarks merged commit 82efcfc into main Jan 5, 2022

aomarks deleted the observers-zero branch January 5, 2022 20:45

Set observers version to 0.0.0 so that changesets releases it as 1.0.0 #2376

Set observers version to 0.0.0 so that changesets releases it as 1.0.0 #2376

Uh oh!

Conversation

aomarks commented Jan 5, 2022

Uh oh!

changeset-bot bot commented Jan 5, 2022

⚠️ No Changeset found

Uh oh!

github-actions bot commented Jan 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

bicknellr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Jan 5, 2022 •

edited

Loading