Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lit-robot
Copy link
Member

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

[email protected]

Major Changes

  • #2646 365cd09a - Clarify that hacking around the template strings array brand error can create security vulnerabilities.

Patch Changes

[email protected]

Major Changes

  • #2646 365cd09a - Clarify that hacking around the template strings array brand error can create security vulnerabilities.

Patch Changes

  • #2657 a6069c40 - Remove readonly restriction from StyleInfo interface as addition, deletion, and updating of styles is valid. Expanded styleMap documentation with links to lit.dev.

  • #2642 badc532c - Add an additional security brand check to StaticValues; Similar to #2307

  • #2661 9a3a38cd - Give a clearer error message when rendering into null/undefined

@lit-labs/[email protected]

Minor Changes

@lit-labs/[email protected]

Minor Changes

  • #2662 1d51ed8b - Adds HTMLElement.shadowRoot property to dom-shim.

Patch Changes

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

  • #2648 7cb492a3 - Event callbacks can be typed by casting with EventHandler

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

[email protected]

Patch Changes

@lit/[email protected]

Patch Changes

@lit/[email protected]

Patch Changes

[email protected]

Patch Changes

@lit/[email protected]

Patch Changes

@lit/[email protected]

Patch Changes

[email protected]

Patch Changes

[email protected]

Patch Changes

[email protected]

Patch Changes

[email protected]

Patch Changes

@google-cla
Copy link

google-cla bot commented Mar 31, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -4% - +5% (-1.14ms - +1.51ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -2% - +1% (-1.52ms - +0.97ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -2% - +1% (-0.50ms - +0.46ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +4% (-0.12ms - +0.41ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +3% (-1.08ms - +1.82ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +2% (-1.50ms - +0.94ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -1% - +2% (-6.37ms - +14.56ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -5% - +2% (-4.50ms - +1.98ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +2% (-3.96ms - +6.28ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +2% (-2.84ms - +2.84ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +1% (-14.19ms - +8.62ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -1% - +2% (-6.59ms - +16.32ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-13.15ms - +12.38ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
79.63ms - 81.29ms-unsure 🔍
-2% - +1%
-1.52ms - +0.97ms
faster ✔
18% - 20%
17.81ms - 20.23ms
tip-of-tree
tip-of-tree
79.80ms - 81.67msunsure 🔍
-1% - +2%
-0.97ms - +1.52ms
-faster ✔
18% - 20%
17.46ms - 20.03ms
previous-release
previous-release
98.60ms - 100.37msslower ❌
22% - 25%
17.81ms - 20.23ms
slower ❌
21% - 25%
17.46ms - 20.03ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
862.82ms - 877.82ms-unsure 🔍
-1% - +2%
-6.37ms - +14.56ms
faster ✔
6% - 8%
56.45ms - 79.36ms
tip-of-tree
tip-of-tree
858.92ms - 873.52msunsure 🔍
-2% - +1%
-14.56ms - +6.37ms
-faster ✔
7% - 9%
60.68ms - 83.32ms
previous-release
previous-release
929.57ms - 946.88msslower ❌
6% - 9%
56.45ms - 79.36ms
slower ❌
7% - 10%
60.68ms - 83.32ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
956.80ms - 973.13ms-unsure 🔍
-1% - +2%
-6.59ms - +16.32ms
faster ✔
4% - 6%
38.26ms - 60.42ms
tip-of-tree
tip-of-tree
952.06ms - 968.14msunsure 🔍
-2% - +1%
-16.32ms - +6.59ms
-faster ✔
4% - 6%
43.23ms - 65.19ms
previous-release
previous-release
1006.82ms - 1021.79msslower ❌
4% - 6%
38.26ms - 60.42ms
slower ❌
4% - 7%
43.23ms - 65.19ms
-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
31.75ms - 32.42ms-unsure 🔍
-2% - +1%
-0.50ms - +0.46ms
faster ✔
14% - 17%
5.21ms - 6.69ms
tip-of-tree
tip-of-tree
31.76ms - 32.46msunsure 🔍
-1% - +2%
-0.46ms - +0.50ms
-faster ✔
14% - 17%
5.19ms - 6.68ms
previous-release
previous-release
37.38ms - 38.70msslower ❌
16% - 21%
5.21ms - 6.69ms
slower ❌
16% - 21%
5.19ms - 6.68ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
91.84ms - 96.94ms-unsure 🔍
-5% - +2%
-4.50ms - +1.98ms
unsure 🔍
-6% - +2%
-6.24ms - +1.57ms
tip-of-tree
tip-of-tree
93.64ms - 97.66msunsure 🔍
-2% - +5%
-1.98ms - +4.50ms
-unsure 🔍
-5% - +3%
-4.65ms - +2.50ms
previous-release
previous-release
93.77ms - 99.68msunsure 🔍
-2% - +7%
-1.57ms - +6.24ms
unsure 🔍
-3% - +5%
-2.50ms - +4.65ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
28.17ms - 30.00ms-unsure 🔍
-4% - +5%
-1.14ms - +1.51ms
faster ✔
12% - 20%
3.80ms - 7.16ms
tip-of-tree
tip-of-tree
27.94ms - 29.86msunsure 🔍
-5% - +4%
-1.51ms - +1.14ms
-faster ✔
12% - 21%
3.96ms - 7.37ms
previous-release
previous-release
33.15ms - 35.98msslower ❌
13% - 25%
3.80ms - 7.16ms
slower ❌
13% - 26%
3.96ms - 7.37ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
11.34ms - 11.78ms-unsure 🔍
-1% - +4%
-0.12ms - +0.41ms
faster ✔
9% - 13%
1.22ms - 1.74ms
tip-of-tree
tip-of-tree
11.27ms - 11.56msunsure 🔍
-3% - +1%
-0.41ms - +0.12ms
-faster ✔
11% - 14%
1.42ms - 1.82ms
previous-release
previous-release
12.90ms - 13.17msslower ❌
10% - 15%
1.22ms - 1.74ms
slower ❌
12% - 16%
1.42ms - 1.82ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
331.77ms - 339.40ms-unsure 🔍
-1% - +2%
-3.96ms - +6.28ms
faster ✔
29% - 32%
137.53ms - 154.84ms
tip-of-tree
tip-of-tree
331.01ms - 337.84msunsure 🔍
-2% - +1%
-6.28ms - +3.96ms
-faster ✔
29% - 32%
138.86ms - 155.83ms
previous-release
previous-release
474.00ms - 489.53msslower ❌
41% - 46%
137.53ms - 154.84ms
slower ❌
41% - 47%
138.86ms - 155.83ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
58.94ms - 60.58ms-unsure 🔍
-2% - +3%
-1.08ms - +1.82ms
faster ✔
15% - 18%
10.63ms - 13.42ms
tip-of-tree
tip-of-tree
58.20ms - 60.59msunsure 🔍
-3% - +2%
-1.82ms - +1.08ms
-faster ✔
15% - 19%
10.75ms - 14.03ms
previous-release
previous-release
70.66ms - 72.91msslower ❌
18% - 23%
10.63ms - 13.42ms
slower ❌
18% - 24%
10.75ms - 14.03ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
142.24ms - 145.54ms-unsure 🔍
-2% - +2%
-2.84ms - +2.84ms
faster ✔
11% - 14%
17.86ms - 23.33ms
tip-of-tree
tip-of-tree
141.58ms - 146.20msunsure 🔍
-2% - +2%
-2.84ms - +2.84ms
-faster ✔
11% - 14%
17.42ms - 23.77ms
previous-release
previous-release
162.30ms - 166.66msslower ❌
12% - 16%
17.86ms - 23.33ms
slower ❌
12% - 17%
17.42ms - 23.77ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
57.68ms - 59.48ms-unsure 🔍
-3% - +2%
-1.50ms - +0.94ms
unsure 🔍
-3% - +1%
-1.69ms - +0.66ms
tip-of-tree
tip-of-tree
58.04ms - 59.68msunsure 🔍
-2% - +3%
-0.94ms - +1.50ms
-unsure 🔍
-2% - +1%
-1.35ms - +0.88ms
previous-release
previous-release
58.34ms - 59.85msunsure 🔍
-1% - +3%
-0.66ms - +1.69ms
unsure 🔍
-1% - +2%
-0.88ms - +1.35ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
924.93ms - 941.20ms-unsure 🔍
-2% - +1%
-14.19ms - +8.62ms
unsure 🔍
-1% - +1%
-13.35ms - +11.34ms
tip-of-tree
tip-of-tree
927.85ms - 943.84msunsure 🔍
-1% - +2%
-8.62ms - +14.19ms
-unsure 🔍
-1% - +2%
-10.47ms - +14.04ms
previous-release
previous-release
924.78ms - 943.35msunsure 🔍
-1% - +1%
-11.34ms - +13.35ms
unsure 🔍
-1% - +1%
-14.04ms - +10.47ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1047.18ms - 1064.42ms-unsure 🔍
-1% - +1%
-13.15ms - +12.38ms
unsure 🔍
-1% - +1%
-11.42ms - +13.02ms
tip-of-tree
tip-of-tree
1046.77ms - 1065.60msunsure 🔍
-1% - +1%
-12.38ms - +13.15ms
-unsure 🔍
-1% - +1%
-11.61ms - +13.98ms
previous-release
previous-release
1046.34ms - 1063.66msunsure 🔍
-1% - +1%
-13.02ms - +11.42ms
unsure 🔍
-1% - +1%
-13.98ms - +11.61ms
-

tachometer-reporter-action v2 for Benchmarks

Comment on lines +3 to +7
## 3.0.0

### Major Changes

- [#2646](https://github.com/lit/lit/pull/2646) [`365cd09a`](https://github.com/lit/lit/commit/365cd09a88a1c390045452aac82510c143ffe257) - Clarify that hacking around the template strings array brand error can create security vulnerabilities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a major change - it's debug logging.

"license": "BSD-3-Clause",
"dependencies": {
"lit": "^2.1.0"
"lit": "^3.0.0"
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this PR - need to fix a changelog entry to not bump Lit's major version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants