[chore] Fix package/benchmarks by updating chromedriver and package-lock #2705

AndrewJakubowicz · 2022-04-06T00:42:20Z

This PR is a version bump similar to #2439

Updates chromedriver to 100 unblocking benchmarks.

See failing benchmarks due to outdated chromedriver here: #2700

Testing

Reproduced the error locally, and fixed by updating package.json and package-lock.json.
Expect this PR to fix the Benchmarks/benchmarks github action.

Risk

Internal dev dependency update for benchmarking. Risk should be low.

Changelog

This is an internal tooling update - This has no user facing changes.

changeset-bot · 2022-04-06T00:42:22Z

⚠️ No Changeset found

Latest commit: c06acde

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2022-04-06T00:42:59Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -7% - +3% (-2.24ms - +0.96ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -4% - +5% (-3.79ms - +4.91ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -3% - +7% (-1.02ms - +2.76ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -9% - +2% (-1.29ms - +0.29ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -4% - +5% (-2.53ms - +3.47ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -4% - +20% (-2.52ms - +14.89ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -4% - +3% (-40.45ms - +26.81ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -5% - +4% (-5.58ms - +4.81ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -8% - +9% (-34.13ms - +38.58ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -5% - +5% (-7.53ms - +7.44ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -12% - +9% (-195.75ms - +152.17ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -2% - +2% (-20.14ms - +16.01ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -3% - +2% (-34.66ms - +22.20ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 100.0.4896.60
Sample size: 50
Built by: Benchmarks #2678
Commit: f38edba

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	99.38ms - 105.35ms	-	unsure 🔍 -4% - +5% -3.79ms - +4.91ms	faster ✔ 13% - 20% 16.19ms - 24.99ms
tip-of-tree tip-of-tree	98.65ms - 104.97ms	unsure 🔍 -5% - +4% -4.91ms - +3.79ms	-	faster ✔ 14% - 21% 16.63ms - 25.68ms
previous-release previous-release	119.73ms - 126.19ms	slower ❌ 15% - 25% 16.19ms - 24.99ms	slower ❌ 16% - 26% 16.63ms - 25.68ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1010.02ms - 1055.82ms	-	unsure 🔍 -4% - +3% -40.45ms - +26.81ms	faster ✔ 34% - 38% 545.70ms - 612.69ms
tip-of-tree tip-of-tree	1015.12ms - 1064.37ms	unsure 🔍 -3% - +4% -26.81ms - +40.45ms	-	faster ✔ 34% - 37% 537.68ms - 607.07ms
previous-release previous-release	1587.68ms - 1636.55ms	slower ❌ 52% - 60% 545.70ms - 612.69ms	slower ❌ 51% - 59% 537.68ms - 607.07ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	983.31ms - 1010.65ms	-	unsure 🔍 -2% - +2% -20.14ms - +16.01ms	faster ✔ 7% - 10% 73.71ms - 113.34ms
tip-of-tree tip-of-tree	987.23ms - 1010.87ms	unsure 🔍 -2% - +2% -16.01ms - +20.14ms	-	faster ✔ 7% - 10% 72.87ms - 110.05ms
previous-release previous-release	1076.16ms - 1104.85ms	slower ❌ 7% - 11% 73.71ms - 113.34ms	slower ❌ 7% - 11% 72.87ms - 110.05ms	-

lit-html-kitchen-sink

Browser: chrome-headless 100.0.4896.60
Sample size: 30
Built by: Benchmarks #2678
Commit: f38edba

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	38.16ms - 41.08ms	-	unsure 🔍 -3% - +7% -1.02ms - +2.76ms	faster ✔ 6% - 15% 2.74ms - 6.69ms
tip-of-tree tip-of-tree	37.56ms - 39.95ms	unsure 🔍 -7% - +3% -2.76ms - +1.02ms	-	faster ✔ 9% - 16% 3.79ms - 7.37ms
previous-release previous-release	43.00ms - 45.67ms	slower ❌ 7% - 17% 2.74ms - 6.69ms	slower ❌ 9% - 19% 3.79ms - 7.37ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	103.08ms - 110.07ms	-	unsure 🔍 -5% - +4% -5.58ms - +4.81ms	unsure 🔍 -5% - +4% -5.49ms - +4.80ms
tip-of-tree tip-of-tree	103.12ms - 110.80ms	unsure 🔍 -5% - +5% -4.81ms - +5.58ms	-	unsure 🔍 -5% - +5% -5.35ms - +5.43ms
previous-release previous-release	103.14ms - 110.70ms	unsure 🔍 -5% - +5% -4.80ms - +5.49ms	unsure 🔍 -5% - +5% -5.43ms - +5.35ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	32.41ms - 34.84ms	-	unsure 🔍 -7% - +3% -2.24ms - +0.96ms	faster ✔ 7% - 17% 2.34ms - 6.68ms
tip-of-tree tip-of-tree	33.23ms - 35.31ms	unsure 🔍 -3% - +7% -0.96ms - +2.24ms	-	faster ✔ 5% - 15% 1.80ms - 5.94ms
previous-release previous-release	36.35ms - 39.93ms	slower ❌ 7% - 20% 2.34ms - 6.68ms	slower ❌ 5% - 18% 1.80ms - 5.94ms	-

lit-html-repeat

Browser: chrome-headless 100.0.4896.60
Sample size: 30
Built by: Benchmarks #2678
Commit: f38edba

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	13.25ms - 14.24ms	-	unsure 🔍 -9% - +2% -1.29ms - +0.29ms	faster ✔ 7% - 17% 0.98ms - 2.80ms
tip-of-tree tip-of-tree	13.63ms - 14.86ms	unsure 🔍 -2% - +9% -0.29ms - +1.29ms	-	faster ✔ 3% - 15% 0.41ms - 2.37ms
previous-release previous-release	14.87ms - 16.40ms	slower ❌ 7% - 21% 0.98ms - 2.80ms	slower ❌ 3% - 17% 0.41ms - 2.37ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	428.17ms - 473.08ms	-	unsure 🔍 -8% - +9% -34.13ms - +38.58ms	faster ✔ 19% - 28% 109.11ms - 168.38ms
tip-of-tree tip-of-tree	419.80ms - 477.00ms	unsure 🔍 -9% - +8% -38.58ms - +34.13ms	-	faster ✔ 18% - 29% 106.45ms - 175.49ms
previous-release previous-release	570.03ms - 608.71ms	slower ❌ 23% - 39% 109.11ms - 168.38ms	slower ❌ 22% - 41% 106.45ms - 175.49ms	-

lit-html-template-heavy

Browser: chrome-headless 100.0.4896.60
Sample size: 50
Built by: Benchmarks #2678
Commit: f38edba

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	67.93ms - 72.27ms	-	unsure 🔍 -4% - +5% -2.53ms - +3.47ms	faster ✔ 12% - 20% 9.94ms - 17.12ms
tip-of-tree tip-of-tree	67.55ms - 71.71ms	unsure 🔍 -5% - +4% -3.47ms - +2.53ms	-	faster ✔ 13% - 21% 10.46ms - 17.54ms
previous-release previous-release	80.76ms - 86.50ms	slower ❌ 14% - 25% 9.94ms - 17.12ms	slower ❌ 15% - 26% 10.46ms - 17.54ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	151.78ms - 160.96ms	-	unsure 🔍 -5% - +5% -7.53ms - +7.44ms	faster ✔ 9% - 17% 16.36ms - 30.68ms
tip-of-tree tip-of-tree	150.51ms - 162.34ms	unsure 🔍 -5% - +5% -7.44ms - +7.53ms	-	faster ✔ 9% - 17% 15.40ms - 31.55ms
previous-release previous-release	174.40ms - 185.39ms	slower ❌ 10% - 20% 16.36ms - 30.68ms	slower ❌ 9% - 21% 15.40ms - 31.55ms	-

reactive-element-list

Browser: chrome-headless 100.0.4896.60
Sample size: 50
Built by: Benchmarks #2678
Commit: f38edba

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	74.93ms - 87.87ms	-	unsure 🔍 -4% - +20% -2.52ms - +14.89ms	unsure 🔍 -13% - +9% -11.32ms - +7.50ms
tip-of-tree tip-of-tree	69.40ms - 81.03ms	unsure 🔍 -18% - +3% -14.89ms - +2.52ms	-	unsure 🔍 -20% - +0% -17.07ms - +0.88ms
previous-release previous-release	76.47ms - 90.15ms	unsure 🔍 -9% - +14% -7.50ms - +11.32ms	unsure 🔍 -2% - +23% -0.88ms - +17.07ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1473.07ms - 1716.44ms	-	unsure 🔍 -12% - +9% -195.75ms - +152.17ms	unsure 🔍 -8% - +14% -126.00ms - +216.58ms
tip-of-tree tip-of-tree	1492.22ms - 1740.86ms	unsure 🔍 -10% - +12% -152.17ms - +195.75ms	-	unsure 🔍 -7% - +16% -106.09ms - +240.25ms
previous-release previous-release	1428.91ms - 1670.01ms	unsure 🔍 -13% - +8% -216.58ms - +126.00ms	unsure 🔍 -15% - +6% -240.25ms - +106.09ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1042.48ms - 1074.75ms	-	unsure 🔍 -3% - +2% -34.66ms - +22.20ms	unsure 🔍 -3% - +1% -36.59ms - +11.15ms
tip-of-tree tip-of-tree	1041.44ms - 1088.26ms	unsure 🔍 -2% - +3% -22.20ms - +34.66ms	-	unsure 🔍 -3% - +2% -35.77ms - +22.79ms
previous-release previous-release	1053.75ms - 1088.92ms	unsure 🔍 -1% - +3% -11.15ms - +36.59ms	unsure 🔍 -2% - +3% -22.79ms - +35.77ms	-

_{tachometer-reporter-action v2 for Benchmarks}

Update chromedriver to 100

c06acde

AndrewJakubowicz requested a review from justinfagnani as a code owner April 6, 2022 00:42

AndrewJakubowicz requested a review from augustjk April 6, 2022 00:42

AndrewJakubowicz requested a review from aomarks April 6, 2022 00:43

aomarks approved these changes Apr 6, 2022

View reviewed changes

augustjk approved these changes Apr 6, 2022

View reviewed changes

AndrewJakubowicz merged commit c52a163 into main Apr 6, 2022

AndrewJakubowicz deleted the update-chromedriver-2 branch April 6, 2022 16:18

[chore] Fix package/benchmarks by updating chromedriver and package-lock #2705

[chore] Fix package/benchmarks by updating chromedriver and package-lock #2705

Uh oh!

Conversation

AndrewJakubowicz commented Apr 6, 2022

Testing

Risk

Changelog

Uh oh!

changeset-bot bot commented Apr 6, 2022

⚠️ No Changeset found

Uh oh!

github-actions bot commented Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Apr 6, 2022 •

edited

Loading